https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107858&action=edit Bug 26154: Remove the use of jquery.checkboxes plugin from batch item deletion and modification This patch removes the use of the jquery.checkboxes plugin from the batch item modification and batch item deletion pages. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes. - On the results page, test the "Select all" and "Clear all" controls at the top of the page. These should work correctly on the checkboxes in the table of results. - Test that the "Clear on loan" control still works to uncheck checkboxes corresponding to items which are checked out. - Test the "Show all columns" and "Hide all columns" checkboxes in the "Show/hide columns" section. These should work correctly on the checkboxes for showing and hiding columns in the table. - Go to Tools -> Batch item deletion. - Submit a batch of barcodes. - Repeat the same testing steps above (except the "Clear on loan" step). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107858|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110832&action=edit Bug 26154: Remove the use of jquery.checkboxes plugin from batch item deletion and modification This patch removes the use of the jquery.checkboxes plugin from the batch item modification and batch item deletion pages. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes. - On the results page, test the "Select all" and "Clear all" controls at the top of the page. These should work correctly on the checkboxes in the table of results. - Test that the "Clear on loan" control still works to uncheck checkboxes corresponding to items which are checked out. - Test the "Show all columns" and "Hide all columns" checkboxes in the "Show/hide columns" section. These should work correctly on the checkboxes for showing and hiding columns in the table. - Go to Tools -> Batch item deletion. - Submit a batch of barcodes. - Repeat the same testing steps above (except the "Clear on loan" step). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110832|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 110833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110833&action=edit Bug 26154: Remove the use of jquery.checkboxes plugin from batch item deletion and modification This patch removes the use of the jquery.checkboxes plugin from the batch item modification and batch item deletion pages. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes. - On the results page, test the "Select all" and "Clear all" controls at the top of the page. These should work correctly on the checkboxes in the table of results. - Test that the "Clear on loan" control still works to uncheck checkboxes corresponding to items which are checked out. - Test the "Show all columns" and "Hide all columns" checkboxes in the "Show/hide columns" section. These should work correctly on the checkboxes for showing and hiding columns in the table. - Go to Tools -> Batch item deletion. - Submit a batch of barcodes. - Repeat the same testing steps above (except the "Clear on loan" step). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110833|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111444&action=edit Bug 26154: Remove the use of jquery.checkboxes plugin from batch item deletion and modification This patch removes the use of the jquery.checkboxes plugin from the batch item modification and batch item deletion pages. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes. - On the results page, test the "Select all" and "Clear all" controls at the top of the page. These should work correctly on the checkboxes in the table of results. - Test that the "Clear on loan" control still works to uncheck checkboxes corresponding to items which are checked out. - Test the "Show all columns" and "Hide all columns" checkboxes in the "Show/hide columns" section. These should work correctly on the checkboxes for showing and hiding columns in the table. - Go to Tools -> Batch item deletion. - Submit a batch of barcodes. - Repeat the same testing steps above (except the "Clear on loan" step). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.