[Bug 6687] New: cannot move people in the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Bug #: 6687 Summary: cannot move people in the holds queue Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: cgi-bin/koha/reserve/request.pl?biblionumber=4091 OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Hold requests AssignedTo: ian.walls@bywatersolutions.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com When viewing the holds queue clicking the arrows to move people around the queue causes an error message saying that the patron already has the item on hold. "Cannot Place Hold Olga Rivera already has a hold on this item" This could be a T:T issue (actually I hope it is). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6526 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-08-09 15:58:08 UTC --- I rolled back reserve/request.pl to the state it was in before Bug 6526 and found that the arrows were working again. I'm guessing a change in that patch (now pushed) is the cause. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-09-06 16:21:39 UTC --- I agree with owen's assessment. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 dev_patches@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dev_patches@biblibre.com AssignedTo|ian.walls@bywatersolutions. |sophie.meynieux@biblibre.co |com |m -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz AssignedTo|sophie.meynieux@biblibre.co |robin@catalyst.net.nz |m | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> 2011-09-06 23:58:05 UTC --- Rats, I guess that'll make it my problem then. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> 2011-09-07 01:27:22 UTC --- I note that the change does apply, it's just also putting up the error message. (still going to fix it proper though.) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> 2011-09-07 01:50:03 UTC --- Created attachment 5328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5328 Bug 6687 - allow people to be moved in the holds queue This fixes a regression introduced by Bug 6526 that told you someone already had a reserve if you attempted to move their ordering in the hold queue. (note: it also cleans a host of trailing whitespace errors that were in that file) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5328|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-09-07 15:44:11 UTC --- Created attachment 5340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5340 [SIGNED-OFF] Bug 6687 - allow people to be moved in the holds queue This fixes a regression introduced by Bug 6526 that told you someone already had a reserve if you attempted to move their ordering in the hold queue. (note: it also cleans a host of trailing whitespace errors that were in that file) Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-07 15:48:20 UTC --- Primarily white space changes, which are okay. The core content of the file adds a simple additional check to the conditional, which seems okay. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-08 01:50:02 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #9 from Liz Rea <wizzyrea@gmail.com> 2011-09-20 21:43:44 UTC --- Works great, thanks! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6687 Bug 6687 depends on bug 6526, which changed state. Bug 6526 Summary: Hold requests require cardnumbers to be set http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6526 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org