[Bug 17332] New: Memcached configuration missing in koha-conf* files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 Bug ID: 17332 Summary: Memcached configuration missing in koha-conf* files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 11921 makes the code look for memcached configuration into the koha-conf* files, but missed to patch koha-conf* files! To test: - Run: $ $ git grep memcached_servers => FAIL: no memcached_servers entry on etc/koha-conf.xml or debian/templates/koha-conf-site.xml.in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com Depends on| |11921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 [Bug 11921] memcached configuration should be moved back to koha-conf.xml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 55776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55776&action=edit Bug 17332: Include memcached configuration in koha-conf files This patch introduces the memcached_servers and memcached_namespace configuration entries as expected by 11921. Note: better test this one and the followup together to ease the process. To test: - Do a source Koha install (dev, standard, single) => SUCCESS: The resulting koha-conf.xml file includes the memcached_* entries which are filled with the right values. - In kohadevbox (packages setup): - Replace /etc/koha/koha-conf-site.xml.in with the one from this patch - Create a new koha instance => SUCCESS: The instance's koha-conf.xml includes the relevant entries - Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 55777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55777&action=edit Bug 17332: Remove memcached config from apache files This patch removes Memcached configurations from the shipped apache files. Note: testing is not actually needed for this patch, as it is really trivial. But I include testing steps, just in case QA members require it. To test: - Apply the patch - Do a (standard/dev/single) Koah install => SUCCESS: Verify the resulting koha-httpd.conf file doens't include memcached data - Have a packages install - Replace * /etc/koha/apache-site-https.conf.in * /etc/koha/apache-site.conf.in with the ones from this patch - Create an instance => SUCCESS: The apache configuration doesn't include memcached configurations - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55776|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 55784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55784&action=edit Bug 17332: Include memcached configuration in koha-conf files This patch introduces the memcached_servers and memcached_namespace configuration entries as expected by 11921. Note: better test this one and the followup together to ease the process. To test: - Do a source Koha install (dev, standard, single) => SUCCESS: The resulting koha-conf.xml file includes the memcached_* entries which are filled with the right values. - In kohadevbox (packages setup): - Replace /etc/koha/koha-conf-site.xml.in with the one from this patch - Create a new koha instance => SUCCESS: The instance's koha-conf.xml includes the relevant entries - Sign off Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55777|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 55785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55785&action=edit Bug 17332: Remove memcached config from apache files This patch removes Memcached configurations from the shipped apache files. Note: testing is not actually needed for this patch, as it is really trivial. But I include testing steps, just in case QA members require it. To test: - Apply the patch - Do a (standard/dev/single) Koah install => SUCCESS: Verify the resulting koha-httpd.conf file doens't include memcached data - Have a packages install - Replace * /etc/koha/apache-site-https.conf.in * /etc/koha/apache-site.conf.in with the ones from this patch - Create an instance => SUCCESS: The apache configuration doesn't include memcached configurations - Sign off :-D Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 [Bug 17336] api_secret_passphrase missing in packages setup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55784|0 |1 is obsolete| | Attachment #55785|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55828&action=edit Bug 17332: Include memcached configuration in koha-conf files This patch introduces the memcached_servers and memcached_namespace configuration entries as expected by 11921. Note: better test this one and the followup together to ease the process. To test: - Do a source Koha install (dev, standard, single) => SUCCESS: The resulting koha-conf.xml file includes the memcached_* entries which are filled with the right values. - In kohadevbox (packages setup): - Replace /etc/koha/koha-conf-site.xml.in with the one from this patch - Create a new koha instance => SUCCESS: The instance's koha-conf.xml includes the relevant entries - Sign off Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55829&action=edit Bug 17332: Remove memcached config from apache files This patch removes Memcached configurations from the shipped apache files. Note: testing is not actually needed for this patch, as it is really trivial. But I include testing steps, just in case QA members require it. To test: - Apply the patch - Do a (standard/dev/single) Koah install => SUCCESS: Verify the resulting koha-httpd.conf file doens't include memcached data - Have a packages install - Replace * /etc/koha/apache-site-https.conf.in * /etc/koha/apache-site.conf.in with the ones from this patch - Create an instance => SUCCESS: The apache configuration doesn't include memcached configurations - Sign off :-D Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Won't be pushed to 16.05 as bug 11921. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org