[Bug 10464] New: Patron search on placing a hold doesn't use jqueryui.autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Bug ID: 10464 Summary: Patron search on placing a hold doesn't use jqueryui.autocomplete Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com We should provide the autocomplete feature present for the circulation search box if CircAutocompl set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 18946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18946&action=edit Bug 10464 - Patron search on placing a hold should provide autocomplete We should provide the autocomplete feature, already present for the circulation search box, if CircAutocompl is properly set; and leave as it currently works otherwise of course. This patch grabs the autocomplete handling javascript stuff from patron-search-box.inc and puts an adjusted version on reserve/request.tt and also adjusts form and input id's to match those configured in the autocomplete call. This changes where needed due to name collisions with the patron-search-box.inc that is present everywhere. To test: - On a biblio record, go to the Holds tab, mine looks like /cgi-bin/koha/reserve/request.pl?biblionumber=2 - A search box is shown for patron searching. - Search for a patron: it works as usual. - Make sure CircAutocompl is 'Don\'t try' - Apply the patch - Click the Holds tab again, and do the same search: functionality should remain intact. - Change CircAutocompl to 'Try' - Click the Holds tab again - Autocomplete should show you the possible options, and once you choose one result, it should work as usual. Note: once you apply the patch the width of the search input field will be doubled. If you are oleonard and prefer to stick with size=20, please amend the patch, I just prefered how it looked at size=40. Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18946|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 18947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18947&action=edit Bug 10464 - Patron search on placing a hold should provide autocomplete We should provide the autocomplete feature, already present for the circulation search box, if CircAutocompl is properly set; and leave as it currently works otherwise of course. This patch grabs the autocomplete handling javascript stuff from patron-search-box.inc and puts an adjusted version on reserve/request.tt and also adjusts form and input id's to match those configured in the autocomplete call. This changes where needed due to name collisions with the patron-search-box.inc that is present everywhere. To test: - On a biblio record, go to the Holds tab, mine looks like /cgi-bin/koha/reserve/request.pl?biblionumber=2 - A search box is shown for patron searching. - Search for a patron: it works as usual. - Make sure CircAutocompl is 'Don\'t try' - Apply the patch - Click the Holds tab again, and do the same search: functionality should remain intact. - Change CircAutocompl to 'Try' - Click the Holds tab again - Autocomplete should show you the possible options, and once you choose one result, it should work as usual. Note: once you apply the patch the width of the search input field will be doubled. If you are oleonard and prefer to stick with size=20, please amend the patch, I just prefered how it looked at size=40. Regards To+ Edit: Wrapped the JavaScript code with [% UNLESS ( borrowernumber ) %] to fix the behaviour on the case of rendering the placing hold page instead. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18947|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18982&action=edit Bug 10464 - Patron search on placing a hold should provide autocomplete We should provide the autocomplete feature, already present for the circulation search box, if CircAutocompl is properly set; and leave as it currently works otherwise of course. This patch grabs the autocomplete handling javascript stuff from patron-search-box.inc and puts an adjusted version on reserve/request.tt and also adjusts form and input id's to match those configured in the autocomplete call. This changes where needed due to name collisions with the patron-search-box.inc that is present everywhere. To test: - On a biblio record, go to the Holds tab, mine looks like /cgi-bin/koha/reserve/request.pl?biblionumber=2 - A search box is shown for patron searching. - Search for a patron: it works as usual. - Make sure CircAutocompl is 'Don\'t try' - Apply the patch - Click the Holds tab again, and do the same search: functionality should remain intact. - Change CircAutocompl to 'Try' - Click the Holds tab again - Autocomplete should show you the possible options, and once you choose one result, it should work as usual. Note: once you apply the patch the width of the search input field will be doubled. If you are oleonard and prefer to stick with size=20, please amend the patch, I just prefered how it looked at size=40. Regards To+ Edit: Wrapped the JavaScript code with [% UNLESS ( borrowernumber ) %] to fix the behaviour on the case of rendering the placing hold page instead. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de Assignee|oleonard@myacpl.org |tomascohen@gmail.com --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Tomas, I really like the idea :) But I have found something that I'd like you to investigate: When sending the form without waiting for the autocomplete to take place (I used 's') you get to the suggestion list that Koha already did before your patch. This is good because I think it works without Javascript, so is a good fallback. But when I am on this screen, there is a Javascript error in my Firebug console: $(...).autocomplete(...).data(...) is undefined Line 335 Could you take a look? If it's not too much of a rewrite to fix, you can switch back to 'signed off'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18982|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 19041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19041&action=edit Bug 10464 - Patron search on placing a hold should provide autocomplete We should provide the autocomplete feature, already present for the circulation search box, if CircAutocompl is properly set; and leave as it currently works otherwise of course. This patch grabs the autocomplete handling javascript stuff from patron-search-box.inc and puts an adjusted version on reserve/request.tt and also adjusts form and input id's to match those configured in the autocomplete call. This changes where needed due to name collisions with the patron-search-box.inc that is present everywhere. To test: - On a biblio record, go to the Holds tab, mine looks like /cgi-bin/koha/reserve/request.pl?biblionumber=2 - A search box is shown for patron searching. - Search for a patron: it works as usual. - Make sure CircAutocompl is 'Don\'t try' - Apply the patch - Click the Holds tab again, and do the same search: functionality should remain intact. - Change CircAutocompl to 'Try' - Click the Holds tab again - Autocomplete should show you the possible options, and once you choose one result, it should work as usual. Note: once you apply the patch the width of the search input field will be doubled. If you are oleonard and prefer to stick with size=20, please amend the patch, I just prefered how it looked at size=40. Regards To+ Edit: Wrapped the JavaScript code with [% UNLESS ( borrowernumber || borrower_list ) %] to fix the behaviour on the case of rendering the placing hold page instead. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19042&action=edit [PASSED QA] Bug 10464 - Patron search on placing a hold should provide autocomplete We should provide the autocomplete feature, already present for the circulation search box, if CircAutocompl is properly set; and leave as it currently works otherwise of course. This patch grabs the autocomplete handling javascript stuff from patron-search-box.inc and puts an adjusted version on reserve/request.tt and also adjusts form and input id's to match those configured in the autocomplete call. This changes where needed due to name collisions with the patron-search-box.inc that is present everywhere. To test: - On a biblio record, go to the Holds tab, mine looks like /cgi-bin/koha/reserve/request.pl?biblionumber=2 - A search box is shown for patron searching. - Search for a patron: it works as usual. - Make sure CircAutocompl is 'Don\'t try' - Apply the patch - Click the Holds tab again, and do the same search: functionality should remain intact. - Change CircAutocompl to 'Try' - Click the Holds tab again - Autocomplete should show you the possible options, and once you choose one result, it should work as usual. Note: once you apply the patch the width of the search input field will be doubled. If you are oleonard and prefer to stick with size=20, please amend the patch, I just prefered how it looked at size=40. Regards To+ Edit: Wrapped the JavaScript code with [% UNLESS ( borrowernumber || borrower_list ) %] to fix the behaviour on the case of rendering the placing hold page instead. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Adding a nice new autocomplete feature. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19041|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Tomás! A refactoring to consider in the near future is tweaking the patron search auto-complete JavaScript so that it can be contained in an include template rather than duplicating it among the following templates: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt p Local template variables can be set via a TT include directive to set the form element IDs to apply the JavaScript to. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #10 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org