[Bug 26964] New: The option to Save is not showing on the Advanced Editor when created a Macro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Bug ID: 26964 Summary: The option to Save is not showing on the Advanced Editor when created a Macro Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In 20.05.05, the ability to save a new macro is not visible. One needs to create the name of the macro, it will appear on the left, then click that new macro name, and then the options to save and to create the macro public. Seems to need the page refreshed during this process in some way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Depends on| |17268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Bug 26964 depends on bug 17268, which changed state. Bug 17268 Summary: Advanced cataloging editor - rancor - macros are lost when browser storage cleared https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 117404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117404&action=edit Bug 26964: Newly created macros should be selected in the Advanced editor The problem is that the newly created macro isn't selected, because the return values from the call to create it are accidentally thrown away. There isn't actually any option to save, just a timeout that automatically saves, but you can tell you are in this broken state because the Delete macro button is disabled. Test plan: 1. Prior to applying the patch, Administration - set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - Macros... - New macro... 3. Give it a name, click OK, notice that the Delete macro button is disabled 4. Apply patch, shift+reload 5. Macros... - New macro... 6. Give it a name, click OK, notice that the Delete macro button is enabled 7. Type something in the editor, delete 999 will do nicely, wait half a second to see Saved appear at the far right, close the macro popup 8. Macros..., click the name of your macro, verify it really was saved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117404|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 117405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117405&action=edit Bug 26964: Newly created macros should be selected in the Advanced editor The problem is that the newly created macro isn't selected, because the return values from the call to create it are accidentally thrown away. There isn't actually any option to save, just a timeout that automatically saves, but you can tell you are in this broken state because the Delete macro button is disabled. Test plan: 1. Prior to applying the patch, Administration - set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - Macros... - New macro... 3. Give it a name, click OK, notice that the Delete macro button is disabled 4. Apply patch, shift+reload 5. Macros... - New macro... 6. Give it a name, click OK, notice that the Delete macro button is enabled 7. Type something in the editor, delete 999 will do nicely, wait half a second to see Saved appear at the far right, close the macro popup 8. Macros..., click the name of your macro, verify it really was saved Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Summary|The option to Save is not |Advanced editor no longer |showing on the Advanced |selects newly created |Editor when created a Macro |macros -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Changed status to signed off - looks like Andrew signed off on 26 February 2021. Please change back if that is not the case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Oh, yes, thanks! I must have missed the status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27890 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This looks like a duplicate to bug 27890 and implements the same solution afaikt? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 27890 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117405|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117891&action=edit Bug 26964: Newly created macros should be selected in the Advanced editor The problem is that the newly created macro isn't selected, because the return values from the call to create it are accidentally thrown away. There isn't actually any option to save, just a timeout that automatically saves, but you can tell you are in this broken state because the Delete macro button is disabled. Test plan: 1. Prior to applying the patch, Administration - set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - Macros... - New macro... 3. Give it a name, click OK, notice that the Delete macro button is disabled 4. Apply patch, shift+reload 5. Macros... - New macro... 6. Give it a name, click OK, notice that the Delete macro button is enabled 7. Type something in the editor, delete 999 will do nicely, wait half a second to see Saved appear at the far right, close the macro popup 8. Macros..., click the name of your macro, verify it really was saved Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes the release notes| |behaviour for saving of new | |macros using the advanced | |editor. Before this fix the | |newly created macro wasn't | |selected and the automatic | |save (there isn't a save | |option) had nothing to | |save. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.04 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.04 |21.05.00,20.11.04,20.05.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org