[Bug 17666] New: .perl atomic update does not work under kohadevbox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Bug ID: 17666 Summary: .perl atomic update does not work under kohadevbox Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org % perl installer/data/mysql/updatedatabase.pl DEV atomic update: bug_xxxx.perl Error flock (1) on '/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_xxxx.perl': No locks available at installer/data/mysql/updatedatabase.pl line 13637. This is because Path::Tiny->slurp[_utf8] uses flocks which does not work with NFS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16685 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Can we remove Tiny::slurp in the meantime ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #1)
Can we remove Tiny::slurp in the meantime ?
Path::Tiny you mean? Which alternative do you suggest? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I also get lockd: cannot monitor kohadevbox in /var/log/messages of the host. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #2)
(In reply to Marcel de Rooy from comment #1)
Can we remove Tiny::slurp in the meantime ?
Path::Tiny you mean? Which alternative do you suggest?
The old way is fine too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Do you mean using do instead of eval (i.e. revert of bug 16685)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Strange. It works for my windows box vagrant. Oh right, doesn't use NFS, uses built-in virtualbox driver. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57727&action=edit Bug 17666 - .perl atomic update does not work under kohadevbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Jonathan, does it work for you with this patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #8)
Jonathan, does it work for you with this patch?
Yes of course it works but in that case it's certainly better to use File::Slurp::read_file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #9)
(In reply to Kyle M Hall from comment #8)
Jonathan, does it work for you with this patch?
Yes of course it works but in that case it's certainly better to use File::Slurp::read_file
File::Slurp is packaged on Debian. It calls sysopen with O_RDONLY. So no flock. So, it seems to be the best choice here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 [Bug 17762] Ability to translate notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57727|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58151&action=edit Bug 17666: Revert "Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp" This reverts commit 7ac1bc35372990520a7c67870b2c702c41bbebcc. On a kohadevbox: Error flock (1) on '/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_xxxx.perl': No locks available at installer/data/mysql/updatedatabase.pl line 13637. This is because Path::Tiny->slurp[_utf8] uses flocks which does not work with NFS Test plan: Execute a .perl atomic update file on a kohadevbox => Without this patch you should get the flock error => With this patch the update should work fine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58151|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58193&action=edit [SIGNED-OFF] Bug 17666: Revert "Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp" This reverts commit 7ac1bc35372990520a7c67870b2c702c41bbebcc. On a kohadevbox: Error flock (1) on '/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_xxxx.perl': No locks available at installer/data/mysql/updatedatabase.pl line 13637. This is because Path::Tiny->slurp[_utf8] uses flocks which does not work with NFS Test plan: Execute a .perl atomic update file on a kohadevbox => Without this patch you should get the flock error => With this patch the update should work fine Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58193|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 58196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58196&action=edit Bug 17666: Revert "Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp" This reverts commit 7ac1bc35372990520a7c67870b2c702c41bbebcc. On a kohadevbox: Error flock (1) on '/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_xxxx.perl': No locks available at installer/data/mysql/updatedatabase.pl line 13637. This is because Path::Tiny->slurp[_utf8] uses flocks which does not work with NFS Test plan: Execute a .perl atomic update file on a kohadevbox => Without this patch you should get the flock error => With this patch the update should work fine Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 58197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58197&action=edit Bug 17666: [QA Follow-up] Mark File::Slurp as required Not optional since we are 'using' it in updatedatabase.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note: Has been packaged for Jessie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org