[Bug 19039] New: Results of virtual shelves (lists) not sortable by date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Bug ID: 19039 Summary: Results of virtual shelves (lists) not sortable by date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To verify: In staff client, create a list with several items and display it. Verify that the table is sortable by 'Title', 'Author', 'Call number', but not by 'Date added' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18698 [Bug 18698] Get rid of [%% in translation for shelves-result.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18698 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18698 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18985 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 --- Comment #1 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 76313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76313&action=edit Bug 19039: Results of virtual shelves (lists) not sortable by date In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'. Test plan: 1) In the staff client, view a list containing several items 2) Notice that you can't sort by 'date added' 3) Apply the patch 4) Repeat step 1 5) The list can now be sorted by 'date added' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |maryse.simard@inlibro.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76313|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 76663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76663&action=edit Bug 19039: Results of virtual shelves (lists) not sortable by date In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'. Test plan: 1) In the staff client, view a list containing several items 2) Notice that you can't sort by 'date added' 3) Apply the patch 4) Repeat step 1 5) The list can now be sorted by 'date added' Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |maryse.simard@inlibro.com |ity.org | Patch complexity|--- |Small patch Severity|minor |enhancement --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Not a bugfix but an enhancement. This field is important for the release maintainers. Please check next time. Assignee was not filled. Patch complexity not filled. These fields are helpful for QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: When you edit a list, you can define its sort order: title, author, copyright date or callnumber. All other (sortable) columns in the staff list view are in that group. Dateadded is not. Somehow it feels inconsistent not to add this column to that group. And allow the same sort order on OPAC. Not a blocker for me but at least reason for feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 --- Comment #5 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 77319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77319&action=edit Bug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'. This patch adds 'date added' as an option for default sorting of lists. It also makes it available as a sorting option while viewing lists. Test plan: In the staff client and the opac: 1) View a list containing several items => Notice that you can't sort by 'date added' 2) Try to edit the list or create a new one => Notice you can't choose date added as the default sort order 3) Apply the patch 4) When viewing the list you should now be able to sort by date added => Make sure it orders correctly 5) Edit or create a list and choose date added as default sorting order => Make sure it uses date added as default => On the staff client: test that the filter for 'sort by' works for date added => On the opac: test that, while viewing the contents, choosing 'default sorting' in the dropdown menu sorts correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- After creating a list which is sorted by default by date added, when I view it in the OPAC the "Sort by" dropdown doesn't have "Date added" preselected. Everything else looks good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Maryse Simard <maryse.simard@inlibro.com> --- (In reply to Owen Leonard from comment #6)
After creating a list which is sorted by default by date added, when I view it in the OPAC the "Sort by" dropdown doesn't have "Date added" preselected.
Hmm... when I test it myself, I do not encounter this problem ("Date added" is properly preselected). Also, looking at the patch, it seems as though the situation should be handled correctly... Could I have you look at it one more time and confirm the problem does occur for you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76663|0 |1 is obsolete| | Attachment #77319|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77535&action=edit Bug 19039: Results of virtual shelves (lists) not sortable by date In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'. Test plan: 1) In the staff client, view a list containing several items 2) Notice that you can't sort by 'date added' 3) Apply the patch 4) Repeat step 1 5) The list can now be sorted by 'date added' Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77536&action=edit Bug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'. This patch adds 'date added' as an option for default sorting of lists. It also makes it available as a sorting option while viewing lists. Test plan: In the staff client and the opac: 1) View a list containing several items => Notice that you can't sort by 'date added' 2) Try to edit the list or create a new one => Notice you can't choose date added as the default sort order 3) Apply the patch 4) When viewing the list you should now be able to sort by date added => Make sure it orders correctly 5) Edit or create a list and choose date added as default sorting order => Make sure it uses date added as default => On the staff client: test that the filter for 'sort by' works for date added => On the opac: test that, while viewing the contents, choosing 'default sorting' in the dropdown menu sorts correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Maryse Simard from comment #7)
Could I have you look at it one more time and confirm the problem does occur for you?
I guess I was wrong! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77535|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77669&action=edit Bug 19039: Results of virtual shelves (lists) not sortable by date In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'. Test plan: 1) In the staff client, view a list containing several items 2) Notice that you can't sort by 'date added' 3) Apply the patch 4) Repeat step 1 5) The list can now be sorted by 'date added' Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77536|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77670&action=edit Bug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'. This patch adds 'date added' as an option for default sorting of lists. It also makes it available as a sorting option while viewing lists. Test plan: In the staff client and the opac: 1) View a list containing several items => Notice that you can't sort by 'date added' 2) Try to edit the list or create a new one => Notice you can't choose date added as the default sort order 3) Apply the patch 4) When viewing the list you should now be able to sort by date added => Make sure it orders correctly 5) Edit or create a list and choose date added as default sorting order => Make sure it uses date added as default => On the staff client: test that the filter for 'sort by' works for date added => On the opac: test that, while viewing the contents, choosing 'default sorting' in the dropdown menu sorts correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Results of virtual shelves |Results of virtual shelves |(lists) not sortable by |(lists) not sortable by |date |date added -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, won't be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17772 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org