[Bug 39692] New: With OnSiteCheckoutsForce the due date should be set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 Bug ID: 39692 Summary: With OnSiteCheckoutsForce the due date should be set Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: januszop@gmail.com Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When OnSiteCheckoutsForce is set it is possible to on-site checkout an item to a restricted patron. But the due data that is labelled with "Automatic due date:" is not being set. As a result, when such a checkout is performed and you do not set the date manually, the due date will be set as for normal checkout (even if it is marked as on-site checkout). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 181212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181212&action=edit Bug 39692: With OnSiteCheckoutsForce the due date should be set When OnSiteCheckoutsForce is set it is possible to on-site checkout an item to a restricted patron. But the due data that is labelled with "Automatic due date:" is not being set. As a result, when such a checkout is performed and you do not set the date manually, the due date will be set as for normal checkout (even if it is marked as on-site checkout). Test plan: ========== 1. Enable OnSiteCheckouts and OnSiteCheckoutsForce; manually restrict a patron. 2. Go to checkout page for this patron. You will notice: "On-site checkouts only. Automatic due date:" with an empty input field for the date. Perform the checkout (pick any existing barcode). Note the due date in patron's checkouts. In standard ktd it will be +5 days from today, as for a regular checkuot (cf. Circulation and fine rules) and the checkout will be marked as on-site checkout. 3. Apply the patch ; restart_all. 4. Repeat p. 2 (with another barcode or after checking-in). The date in the date input field should be set to today's date and after performing the checkout the sue date should also be set to the current date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181212|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 181213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181213&action=edit Bug 39692: With OnSiteCheckoutsForce the due date should be set When OnSiteCheckoutsForce is set it is possible to on-site checkout an item to a restricted patron. But the due data that is labelled with "Automatic due date:" is not being set. As a result, when such a checkout is performed and you do not set the date manually, the due date will be set as for normal checkout (even if it is marked as on-site checkout). Test plan: ========== 1. Enable OnSiteCheckouts and OnSiteCheckoutsForce; manually restrict a patron. 2. Go to checkout page for this patron. You will notice: "On-site checkouts only. Automatic due date:" with an empty input field for the date. Perform the checkout (pick any existing barcode). Note the due date in patron's checkouts. In standard ktd it will be +5 days from today, as for a regular checkuot (cf. Circulation and fine rules) and the checkout will be marked as on-site checkout. 3. Apply the patch ; restart_all. 4. Repeat p. 2 (with another barcode or after checking-in). The date in the date input field should be set to today's date and after performing the checkout the sue date should also be set to the current date. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181213|0 |1 is obsolete| | --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181653&action=edit Bug 39692: With OnSiteCheckoutsForce the due date should be set When OnSiteCheckoutsForce is set it is possible to on-site checkout an item to a restricted patron. But the due data that is labelled with "Automatic due date:" is not being set. As a result, when such a checkout is performed and you do not set the date manually, the due date will be set as for normal checkout (even if it is marked as on-site checkout). Test plan: ========== 1. Enable OnSiteCheckouts and OnSiteCheckoutsForce; manually restrict a patron. 2. Go to checkout page for this patron. You will notice: "On-site checkouts only. Automatic due date:" with an empty input field for the date. Perform the checkout (pick any existing barcode). Note the due date in patron's checkouts. In standard ktd it will be +5 days from today, as for a regular checkuot (cf. Circulation and fine rules) and the checkout will be marked as on-site checkout. 3. Apply the patch ; restart_all. 4. Repeat p. 2 (with another barcode or after checking-in). The date in the date input field should be set to today's date and after performing the checkout the sue date should also be set to the current date. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Yup, that makes no sense to have a default value different from 0 days I think. Patch small and clean. PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181660&action=edit Bug 39692: [23.11] With OnSiteCheckoutsForce the due date should be set When OnSiteCheckoutsForce is set it is possible to on-site checkout an item to a restricted patron. But the due data that is labelled with "Automatic due date:" is not being set. As a result, when such a checkout is performed and you do not set the date manually, the due date will be set as for normal checkout (even if it is marked as on-site checkout). Test plan: ========== 1. Enable OnSiteCheckouts and OnSiteCheckoutsForce; manually restrict a patron. 2. Go to checkout page for this patron. You will notice: "On-site checkouts only. Automatic due date:" with an empty input field for the date. Perform the checkout (pick any existing barcode). Note the due date in patron's checkouts. In standard ktd it will be +5 days from today, as for a regular checkuot (cf. Circulation and fine rules) and the checkout will be marked as on-site checkout. 3. Apply the patch ; restart_all. 4. Repeat p. 2 (with another barcode or after checking-in). The date in the date input field should be set to today's date and after performing the checkout the sue date should also be set to the current date. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- The 23.11 patch might not be necessary. The code has moved but it is very similar to the old one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.10 released in| | Status|Pushed to main |Pushed to stable --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39692 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org