http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-10 12:13:35 UTC --- Created attachment 4932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4932 screenshot of details page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4950|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-08-15 18:27:28 UTC --- Created attachment 5021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5021 Revised fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-18 05:43:12 UTC --- Sorry Owen - I missed testing this earlier. Patch will doesn't apply using 'git bz apply' and gives me a conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt with 'git am -is3'. Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Fix for Bug 6698, Detail page for organisations should show only valid fields Using index info to reconstruct a base tree... <stdin>:105: trailing whitespace. $template->param( $data->{'category_type'} => 1 ); warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging members/moremember.pl Failed to merge in the changes. Patch failed at 0001 Fix for Bug 6698, Detail page for organisations should show only valid fields -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5021|0 |1 is obsolete| | --- Comment #7 from MJ Ray (software.coop) <mjr@software.coop> --- Created attachment 10122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10122&action=edit Fix for Bug 6698, Detail page for organisations should show only valid fields The output of moremember.pl is supposed to change if the patron in question is an organization (has a category which is of type "I"). The script was checking borrowers.categorycode when it should have been checking categories.category_type. With this correction the right variable is passed to the template. The template needed additional corrections to be sure the correct fields were appearing. The patron entry form offers only phonepro and emailpro, so moremember.pl should output those fields in particular. This patch hides other fields as suggested by the Bug report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, the rebased patch form MJ applied, but I am wondering about the memberentry screen. In the past it was possible to add as many email addresses and phone numbers to an organisational patron as to a normal patron. After the patch, the number is reduced to one email and one phone number. I am not sure, we can make this change without disconnecting libraries from their entered data. Maybe keep all fields in the screen, but make display on the summary dependent on existance? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.