[Bug 13293] New: Regression: Override renewal limit option broken with AJAX circ
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Bug ID: 13293 Summary: Regression: Override renewal limit option broken with AJAX circ Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 11703 The "Override renewal limit" checkbox no longer works to un-hide the renewal checkboxes in the table of checkouts. I assume this is because the script works in such a way that it is looking for the checkboxes before they are part of the document. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Should be easy enough to work around. We found a way to get at stuff on the check out table with jQuery. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33676&action=edit Bug 13293 - Regression: Override renewal limit option broken with AJAX circ The "Override renewal limit" checkbox no longer works to un-hide the renewal checkboxes in the table of checkouts. I assume this is because the script works in such a way that it is looking for the checkboxes before they are part of the document. Test Plan: 1) Apply this patch 2) Check the "Override renewal limit" checkbox 3) Note the checkbox now appears Note, this change allows the "X of Y renewals remaining" to be displayed for non-renewable items. I left this as it is for two reasons: 1) it gives the librarian more information that may be useful, and 2) it looks nicer and more uniform. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Please check the behavior in 3.14.x. The purpose of the "Override renewal limit" option to allow the librarian (if AllowRenewalLimitOverride is enabled) to renew items even after the patron has exceeded the renewal limit. With this patch I can see the checkboxes, but I can't select them because they are disabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|major |critical --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a major problem - please fix with high priority. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33676|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33787&action=edit Bug 13293 - Regression: Override renewal limit option broken with AJAX circ The "Override renewal limit" checkbox no longer works to un-hide the renewal checkboxes in the table of checkouts. I assume this is because the script works in such a way that it is looking for the checkboxes before they are part of the document. Test Plan: 1) Apply this patch 2) Check the "Override renewal limit" checkbox 3) Note the checkbox now appears Note, this change allows the "X of Y renewals remaining" to be displayed for non-renewable items. I left this as it is for two reasons: 1) it gives the librarian more information that may be useful, and 2) it looks nicer and more uniform. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33787|0 |1 is obsolete| | --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33803&action=edit Bug 13293 - Regression: Override renewal limit option broken with AJAX circ The "Override renewal limit" checkbox no longer works to un-hide the renewal checkboxes in the table of checkouts. I assume this is because the script works in such a way that it is looking for the checkboxes before they are part of the document. Test Plan: 1) Apply this patch 2) Check the "Override renewal limit" checkbox 3) Note the checkbox now appears Note, this change allows the "X of Y renewals remaining" to be displayed for non-renewable items. I left this as it is for two reasons: 1) it gives the librarian more information that may be useful, and 2) it looks nicer and more uniform. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm the bug and the solution. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33803|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33805&action=edit [PASSED QA] Bug 13293 - Regression: Override renewal limit option broken with AJAX circ The "Override renewal limit" checkbox no longer works to un-hide the renewal checkboxes in the table of checkouts. I assume this is because the script works in such a way that it is looking for the checkboxes before they are part of the document. Test Plan: 1) Apply this patch 2) Check the "Override renewal limit" checkbox 3) Note the checkbox now appears Note, this change allows the "X of Y renewals remaining" to be displayed for non-renewable items. I left this as it is for two reasons: 1) it gives the librarian more information that may be useful, and 2) it looks nicer and more uniform. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm the bug and the solution. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, works as described. Exception: on-site checkouts can't be renewed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org