[Bug 21238] New: TemplateToolkit.t is failing on slow server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Bug ID: 21238 Summary: TemplateToolkit.t is failing on slow server Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org It failed 3x in the last 6 runs (on node 1), we should mock DateTime->now to prevent it to fail again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77934&action=edit Bug 21238: Prevent TemplateToolkit.t to fail on slow servers It failed 3x in the last 6 runs (on node 1), we should mock DateTime->now to prevent it to fail again. The error is: koha_1 | # Failed test at t/db_dependent/Letters/TemplateToolkit.t line 724. When comparing <<today>> replacement: koha_1 | # 08/16/2018 14:25<br /> [...] koha_1 | # 08/16/2018 14:24<br /> Let's mock DateTime->now to prevent it to fail again. Test plan: 0. Do not apply this patch 1. Add "sleep(60);" at line ~715, before "# Add a second checkout" 2. Run the tests => Fail! 3. Apply this patch 4. Run the tests again => Pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77934|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77935&action=edit Bug 21238: Prevent TemplateToolkit.t to fail on slow servers It failed 3x in the last 6 runs (on node 1), we should mock DateTime->now to prevent it to fail again. The error is: koha_1 | # Failed test at t/db_dependent/Letters/TemplateToolkit.t line 724. When comparing <<today>> replacement: koha_1 | # 08/16/2018 14:25<br /> [...] koha_1 | # 08/16/2018 14:24<br /> Let's mock DateTime->now to prevent it to fail again. Test plan: 0. Do not apply this patch 1. Add "sleep(60);" at line ~715, before "# Add a second checkout" 2. Run the tests => Fail! 3. Apply this patch 4. Run the tests again => Pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sensible fix, works as expected. Signing Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77935|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77958&action=edit Bug 21238: Prevent TemplateToolkit.t to fail on slow servers It failed 3x in the last 6 runs (on node 1), we should mock DateTime->now to prevent it to fail again. The error is: koha_1 | # Failed test at t/db_dependent/Letters/TemplateToolkit.t line 724. When comparing <<today>> replacement: koha_1 | # 08/16/2018 14:25<br /> [...] koha_1 | # 08/16/2018 14:24<br /> Let's mock DateTime->now to prevent it to fail again. Test plan: 0. Do not apply this patch 1. Add "sleep(60);" at line ~715, before "# Add a second checkout" 2. Run the tests => Fail! 3. Apply this patch 4. Run the tests again => Pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77958|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77959&action=edit Bug 21238: Prevent TemplateToolkit.t to fail on slow servers It failed 3x in the last 6 runs (on node 1), we should mock DateTime->now to prevent it to fail again. The error is: koha_1 | # Failed test at t/db_dependent/Letters/TemplateToolkit.t line 724. When comparing <<today>> replacement: koha_1 | # 08/16/2018 14:25<br /> [...] koha_1 | # 08/16/2018 14:24<br /> Let's mock DateTime->now to prevent it to fail again. Test plan: 0. Do not apply this patch 1. Add "sleep(60);" at line ~715, before "# Add a second checkout" 2. Run the tests => Fail! 3. Apply this patch 4. Run the tests again => Pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21238 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org