[Bug 15228] New: Remove \n from translated strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Bug ID: 15228 Summary: Remove \n from translated strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Found while translating: "Deletion of item from a batch with only one item will delete the batch.\\n \\n If this is what you want, select 'Delete batch' option from toolbar" \n should not be inside translated strings as the translation process breaks them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove \n from translated |Patron card batches - |strings |Improve translatability -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45077&action=edit Bug 15228: Patron card batches - Improve translatability This patch removes the \n\n from a translatable string as those don't translate correctly to new lines. It also switches 'item' for 'patron' to avoid confusion with catalog items. To test: 1) Trigger changed error message - Create a new batch with 1 patron entry - Select patron in list using the checkbox - Click 'Remove selected patrons' in toolbar - Verify alert displays correctly 2) Verify that the page no longer uses "items" but patrons instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45077|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45090&action=edit [SIGNED-OFF]Bug 15228: Patron card batches - Improve translatability This patch removes the \n\n from a translatable string as those don't translate correctly to new lines. It also switches 'item' for 'patron' to avoid confusion with catalog items. To test: 1) Trigger changed error message - Create a new batch with 1 patron entry - Select patron in list using the checkbox - Click 'Remove selected patrons' in toolbar - Verify alert displays correctly 2) Verify that the page no longer uses "items" but patrons instead. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45091&action=edit Bug 15228: Switch "Items in batch number" Yet another line to switch "Items in batch number" to "Patrons in batch number" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45091|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45116&action=edit [SIGNED-OFF] Bug 15228: Switch "Items in batch number" Yet another line to switch "Items in batch number" to "Patrons in batch number" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45090|0 |1 is obsolete| | Attachment #45116|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45166&action=edit Bug 15228: Patron card batches - Improve translatability This patch removes the \n\n from a translatable string as those don't translate correctly to new lines. It also switches 'item' for 'patron' to avoid confusion with catalog items. To test: 1) Trigger changed error message - Create a new batch with 1 patron entry - Select patron in list using the checkbox - Click 'Remove selected patrons' in toolbar - Verify alert displays correctly 2) Verify that the page no longer uses "items" but patrons instead. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45167&action=edit Bug 15228: Switch "Items in batch number" Yet another line to switch "Items in batch number" to "Patrons in batch number" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45166|0 |1 is obsolete| | --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46054&action=edit Bug 15228: Patron card batches - Improve translatability This patch removes the \n\n from a translatable string as those don't translate correctly to new lines. It also switches 'item' for 'patron' to avoid confusion with catalog items. To test: 1) Trigger changed error message - Create a new batch with 1 patron entry - Select patron in list using the checkbox - Click 'Remove selected patrons' in toolbar - Verify alert displays correctly 2) Verify that the page no longer uses "items" but patrons instead. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45167|0 |1 is obsolete| | --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46055&action=edit Bug 15228: Switch "Items in batch number" Yet another line to switch "Items in batch number" to "Patrons in batch number" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #9 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Thanks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15228 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org