[Bug 43480] New: Remove BEGIN block from C4::Tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43480 Bug ID: 43480 Summary: Remove BEGIN block from C4::Tags Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 43330 Target Milestone: --- Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43330 [Bug 43330] C4::Tags fails to compile when TagsExternalDictionary is configured -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43480 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43480 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205176&action=edit Bug 43480: Remove BEGIN block from C4::Tags We do not need to fetch sysprefs from the BEGIN block of C4::Tags This patch suggests to defer the fetch at runtime. Test plan: Create some tags from the OPAC, approve it from the staff interface Set TagsExternalDictionary to "/usr/bin/ispell" Try again QA: We also get rid of the following warning: 'Name "Lingua::Ispell::path" used only once: possible typo' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43480 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 205409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205409&action=edit Bug 43480: Remove exception from xt/pl_valid.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43480 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43505 [Bug 43505] Use Koha::QA from the test suite -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org