[Bug 28079] New: Set focus to search box field when adding an order to basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 Bug ID: 28079 Summary: Set focus to search box field when adding an order to basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org When adding an order to a basket, you have to click in the input box before searching for an existing record. It could be usefull if the cursor was focused on the search box. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126049&action=edit Bug 28079: Set focus to search box field when adding an order to basket This patch modifies the "Add to basket" modal in acquisitions so that focus is automatically moved to the first form field when the modal appears. The patch also corrects the modal markup so that it's more consistent with default Bootstrap markup. To test, apply the patch and go to Acquisitions. - Search for a vendor and, if necessary, create a basket. - Click the "Add to basket" button. The modal which appears should have a header reading "Add order to basket <basketname>" - The form field should have cursor focus. - View the basket and click the "Add to basket" button in the toolbar. - The modal shown should also be correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126049|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 126050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126050&action=edit Bug 28079: Set focus to search box field when adding an order to basket This patch modifies the "Add to basket" modal in acquisitions so that focus is automatically moved to the first form field when the modal appears. The patch also corrects the modal markup so that it's more consistent with default Bootstrap markup. To test, apply the patch and go to Acquisitions. - Search for a vendor and, if necessary, create a basket. - Click the "Add to basket" button. The modal which appears should have a header reading "Add order to basket <basketname>" - The form field should have cursor focus. - View the basket and click the "Add to basket" button in the toolbar. - The modal shown should also be correct. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126050|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126554&action=edit Bug 28079: Set focus to search box field when adding an order to basket This patch modifies the "Add to basket" modal in acquisitions so that focus is automatically moved to the first form field when the modal appears. The patch also corrects the modal markup so that it's more consistent with default Bootstrap markup. To test, apply the patch and go to Acquisitions. - Search for a vendor and, if necessary, create a basket. - Click the "Add to basket" button. The modal which appears should have a header reading "Add order to basket <basketname>" - The form field should have cursor focus. - View the basket and click the "Add to basket" button in the toolbar. - The modal shown should also be correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28079 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org