[Bug 12205] New: It should be possible for Holds charges to count towards blocking checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 Bug ID: 12205 Summary: It should be possible for Holds charges to count towards blocking checkout Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: chris@bigballofwax.co.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com There are currently 2 systempreferences, which are used to determine what charges are counted towards blocking circulation RentalsInNoissueCharge and ManInvInNoissuesCharge Which means that someone may have 10000 in charges for holds, and still be able to checkout just fine. There needs to be a systempreference for this also -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 28001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28001&action=edit Bug 12205 : Add a system preference allowing hold charges to block circ Currently, if you have holds charges, they are not taken into consideration when circulating items. Manual Invoices, and rental charges are governed by a systempreference Holds are never counted And all other charges (overdues, lost items etc) are counted This patch adds a systempreference to allow Hold charges to be counted as well. To test 1/ Set a borrower category to have holds charges 2/ Place a hold for a borrower in that category 3/ Go to checkout, notice that charge is not showing or blocking on that screen 4/ apply patch 5/ notice that charge now shows on checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Chris, I would love to test this, but unfortunately, I have no idea what a hold charge is. Could you help me in this? How does one set hold charges? Obviously this is not something we've touched on our system. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Chris, Never mind. I see the fee setting. I didn't realize we could charge for holds. Interesting. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Christopher Brannon from comment #3)
Chris, Never mind. I see the fee setting. I didn't realize we could charge for holds. Interesting.
Christopher
You can pretty much do everthing. Theres a quote on IRC "rangi: #thingsihavelearnt if there is a mad scheme a library somewhere will be doing it ... except madder" (added by wizzyrea at 09:20 PM, March 30, 2011) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Chris, Either I am missing either missing a step or a cron job. I'm trying to test on a sandbox but no charges appear with or without the patch. Got any ideas? Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- You've set the charge on the borrowers category eh? And placed a hold? There is no cron job needed, you should be able to see the charge in the fines screen with or without the patch. It only doesn't show on the circ screen (without the patch) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- It also might be related to the item being out, so maybe try placing a hold on one that is available, and one that is onloan too. Thanks for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- As far as I can see, I've set it right. I notice you are calling it borrower category, but I am seeing it as patron category. http://screencast.com/t/s0A6mWCZZge I'm stumped on this one. I've tried placing a next available hold, placed item level hold on item that is in, and item level hold on item checked out. I set a 0.50 hold charge for PT patrons, and use the Henry Acevedo (23529000035676) account, set as PT patron. You are welcome to take a look. (Sandbox 8) Not sure why it isn't charging at all. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #9 from Nick Clemens <nick@quecheelibrary.org> --- I tested on Sandbox 1 and had good results though I could only get 1 item to charge for a hold, but I suspect that is more about my understanding of holds charges since I have never used them before. I also had a hard time figuring out why charges weren't showing up on the checkout screen until it occurred to me that the obvious step of turning in the system preference would help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28001|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 28762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28762&action=edit Bug 12205 : Add a system preference allowing hold charges to block circ Currently, if you have holds charges, they are not taken into consideration when circulating items. Manual Invoices, and rental charges are governed by a systempreference Holds are never counted And all other charges (overdues, lost items etc) are counted This patch adds a systempreference to allow Hold charges to be counted as well. To test 1/ Set a borrower category to have holds charges 2/ Place a hold for a borrower in that category 3/ Go to checkout, notice that charge is not showing or blocking on that screen 4/ apply patch 5/ notice that charge now shows on checkout Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28762|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28772&action=edit Bug 12205 : Add a system preference allowing hold charges to block circ Currently, if you have holds charges, they are not taken into consideration when circulating items. Manual Invoices, and rental charges are governed by a systempreference Holds are never counted And all other charges (overdues, lost items etc) are counted This patch adds a systempreference to allow Hold charges to be counted as well. To test 1/ Set a borrower category to have holds charges 2/ Place a hold for a borrower in that category 3/ Go to checkout, notice that charge is not showing or blocking on that screen 4/ apply patch 5/ notice that charge now shows on checkout Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 31321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31321&action=edit Bug 12205: (regression tests) HoldsInNoissuesCharge controls GetMemberAccountBalance behaviour regarding hold charges Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Chris! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org