[Bug 9509] New: batchMod.pl does not ensure each barcode is unique
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 Bug ID: 9509 Summary: batchMod.pl does not ensure each barcode is unique Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com batchMod.pl does not ensure each barcode is unique. This means that if a barcode is list twice, the actions are applied to it twice. This is not a problem, unless the modification is to batch delete items, in which case the batch deletion fails at the first duplicate barcode. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14960&action=edit Bug 9509 - batchMod.pl does not ensure each barcode is unique Test plan: 1) Browse to Tools › Batch item deletion 2) Enter a list of barcodes, make sure you have at least one barcode listed more than once 3) Click continue 4) Verify the duplicated barcode shows up multiple times in the table 5) Apply patch 6) Refresh the page 7) Verify each barcode now displays only once -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14960|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 15020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15020&action=edit Bug 9509 - batchMod.pl does not ensure each barcode is unique Test plan: 1) Browse to Tools › Batch item deletion 2) Enter a list of barcodes, make sure you have at least one barcode listed more than once 3) Click continue 4) Verify the duplicated barcode shows up multiple times in the table 5) Apply patch 6) Refresh the page 7) Verify each barcode now displays only once Signed-off-by: Liz Rea <liz@catalyst.net.nz> verified bug and fix - both good. Nice test plan, thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Simple patch, works as expected. It removes duplicated barcodes. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15020|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15049&action=edit Bug 9509 - batchMod.pl does not ensure each barcode is unique Test plan: 1) Browse to Tools › Batch item deletion 2) Enter a list of barcodes, make sure you have at least one barcode listed more than once 3) Click continue 4) Verify the duplicated barcode shows up multiple times in the table 5) Apply patch 6) Refresh the page 7) Verify each barcode now displays only once Signed-off-by: Liz Rea <liz@catalyst.net.nz> verified bug and fix - both good. Nice test plan, thanks! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm not seeing this commit in master, am I just being impatient? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #6)
I'm not seeing this commit in master, am I just being impatient?
I will be pushing master shortly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9509 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x and 3.10.x will be in 3.8.10 and 3.10.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org