[Bug 38522] New: Increase length of erm_argreements.license_info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Bug ID: 38522 Summary: Increase length of erm_argreements.license_info Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org https://schema.koha-community.org/24_05/tables/erm_agreements.html erm_agreements.license_info is limited to 80 characters. Users would like to be able to store more information here. erm_agreement_licenses.notes and erm_agreement_periods.notes are both MEDIUMTEXT fields allowing up to 16777215 characters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 174946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174946&action=edit Bug 38522: Increase erm_agreements.license_info length to test: 1- try to save an agreement with 81+ characters in License Info 2- it does not save 3- apply patch, updatedatabase 4- repeat 1, it works! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 174947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174947&action=edit Bug 38522: update kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174947|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174948&action=edit Bug 38522: update kohastructure.sql Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174946|0 |1 is obsolete| | --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174949&action=edit Bug 38522: Increase erm_agreements.license_info length to test: 1- try to save an agreement with 81+ characters in License Info 2- it does not save 3- apply patch, updatedatabase 4- repeat 1, it works! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174948|0 |1 is obsolete| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174950&action=edit Bug 38522: update kohastructure.sql Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Database update fails: ERROR: {UNKNOWN}: Undefined subroutine &C4::Installer::say_success called at /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35145_order_patron_attributes.pl line 21. at /kohadevbox/koha/C4/Installer.pm line 743 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #6)
Database update fails:
ERROR: {UNKNOWN}: Undefined subroutine &C4::Installer::say_success called at /kohadevbox/koha/installer/data/mysql/atomicupdate/ bug_35145_order_patron_attributes.pl line 21. at /kohadevbox/koha/C4/Installer.pm line 743
Sorry, commented on the wrong bug. This database update is great. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, please make sure to use the new skeleton.pl as a base for your atomic update files. You should use "say_success" for example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #8)
Hi Andrew, please make sure to use the new skeleton.pl as a base for your atomic update files. You should use "say_success" for example.
Hm, I just realized the file needs some more updating for the examples :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Keywords| |additional_work_needed --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Koha_Main_MariaDB_update/10 is failing because of this. 19:22:12 koha_1 | --- a/Koha/Schema/Result/ErmAgreement.pm 19:22:12 koha_1 | +++ b/Koha/Schema/Result/ErmAgreement.pm 19:22:12 koha_1 | @@ -88,11 +88,8 @@ priority of the renewal 19:22:12 koha_1 | 19:22:12 koha_1 | =head2 license_info 19:22:12 koha_1 | 19:22:12 koha_1 | - data_type: 'varchar' 19:22:12 koha_1 | + data_type: 'mediumtext' 19:22:12 koha_1 | is_nullable: 1 19:22:12 koha_1 | - size: 80 19:22:12 koha_1 | - 19:22:12 koha_1 | -info about the license 19:22:12 koha_1 | 19:22:12 koha_1 | =cut 19:22:12 koha_1 | 19:22:12 koha_1 | @@ -114,7 +111,7 @@ __PACKAGE__->add_columns( 19:22:12 koha_1 | "renewal_priority", 19:22:12 koha_1 | { data_type => "varchar", is_nullable => 1, size => 80 }, 19:22:12 koha_1 | "license_info", 19:22:12 koha_1 | - { data_type => "varchar", is_nullable => 1, size => 80 }, 19:22:12 koha_1 | + { data_type => "mediumtext", is_nullable => 1 }, 19:22:12 koha_1 | ); 19:22:12 koha_1 | 19:22:12 koha_1 | =head1 PRIMARY KEY 19:22:12 koha_1 | @@ -267,8 +264,8 @@ Composing rels: L</erm_eholdings_packages_agreements> -> package 19:22:12 koha_1 | __PACKAGE__->many_to_many("packages", "erm_eholdings_packages_agreements", "package"); 19:22:12 koha_1 | 19:22:12 koha_1 | 19:22:12 koha_1 | -# Created by DBIx::Class::Schema::Loader v0.07049 @ 2022-11-11 11:52:09 19:22:12 koha_1 | -# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:N93LnvdKirtuV6BSrTGzVg 19:22:12 koha_1 | +# Created by DBIx::Class::Schema::Loader v0.07051 @ 2024-12-03 18:22:02 19:22:12 koha_1 | +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:08W7MMLmEW7KvG1GAlLM2w 19:22:12 koha_1 | 19:22:13 koha_1 | __PACKAGE__->has_many( 19:22:13 koha_1 | "user_roles", 19:22:26 koha_1 | ERROR - There is a diff in DBIC schema files This is because the ALTER statement is missing the COMMENT part. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174949|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175327&action=edit Bug 38522: followup to preserve comment in sql structure This patch contains a new database update that corrects the missing comment in the schema structure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I've included a new database update that includes that comment. I wasn't sure if that should be handled here as a followup or go on a new bug. I'm happy to file one as desired. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, as we just started and noone should have run your database update yet, I think we can just adjust the db_rev directly. Please also write "(follow-up)" - the QA tools will complain otherwise :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 175332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175332&action=edit Bug 38522: (follow-up) edit dbrev in preserve comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174949|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175327|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #14)
Hi Andrew, as we just started and noone should have run your database update yet, I think we can just adjust the db_rev directly. Please also write "(follow-up)" - the QA tools will complain otherwise :)
Ok, new follow-up patch attached that just edits the dbrev. I obsoleted the new database update I attached earlier today. Thanks, all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #17 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up pushed to main. Fixed "DEFUALT" and amended the patch before pushing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00,24.11.01 |25.05.00,24.11.01,24.05.06 released in| | CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Pushed to oldstable --- Comment #19 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Backported to 24.05.x for 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00,24.11.01,24.05.06 |25.05.00,24.11.01,24.05.06, released in| |23.11.11 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the ERM release notes| |agreements license | |information field (ERM > | |Agreements) so that more | |than 80 characters can be | |entered. It is now a medium | |text field, which allows | |entering up to 16,777,215 | |characters. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38522 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED CC| |jesse@bywatersolutions.com --- Comment #21 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org