[Bug 17899] New: Show only mine does not work in newordersuggestion.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Bug ID: 17899 Summary: Show only mine does not work in newordersuggestion.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 12775 added a link "Show only mine" in newordersuggestion.pl. This does not work, no results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12775 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12775 [Bug 12775] Only suggestion manager can order from accepted suggestion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 58957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58957&action=edit Bug 17899 - Show only mine does not work in newordersuggestion.pl Bug 12775 added a link "Show only mine" in newordersuggestion.pl. This does not work, no results. Also corrects the fact that click must not do default action by adding e.preventDefault(). Test plan : - You must have suggestions you have accepted - Create a new order from suggestion : /cgi-bin/koha/acqui/newordersuggestion.pl - Click on Show only mine => Without patch the table is empty showing "No matching records found" => With patch you see only suggestions you have accpeted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Zoe Schoeler <crazy.mental.onion@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Zoe Schoeler <crazy.mental.onion@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58957|0 |1 is obsolete| | --- Comment #2 from Zoe Schoeler <crazy.mental.onion@gmail.com> --- Created attachment 59136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59136&action=edit Bug 17899 - Show only mine does not work in newordersuggestion.pl Bug 12775 added a link "Show only mine" in newordersuggestion.pl. This does not work, no results. Also corrects the fact that click must not do default action by adding e.preventDefault(). Test plan : - You must have suggestions you have accepted - Create a new order from suggestion : /cgi-bin/koha/acqui/newordersuggestion.pl - Click on Show only mine => Without patch the table is empty showing "No matching records found" => With patch you see only suggestions you have accpeted Signed-off-by: Zoe Schoeler <crazy.mental.onion@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59136|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59251&action=edit Bug 17899 - Show only mine does not work in newordersuggestion.pl Bug 12775 added a link "Show only mine" in newordersuggestion.pl. This does not work, no results. Also corrects the fact that click must not do default action by adding e.preventDefault(). Test plan : - You must have suggestions you have accepted - Create a new order from suggestion : /cgi-bin/koha/acqui/newordersuggestion.pl - Click on Show only mine => Without patch the table is empty showing "No matching records found" => With patch you see only suggestions you have accpeted Signed-off-by: Zoe Schoeler <crazy.mental.onion@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am sure the link used to work. I don't know for how long it has been broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This definitely works better than before, but there is an oddness. For testing this, I set 'acceptedby' to another use. This made no difference. I had to change 'managedby' as well, then it worked. It appears that the 'order by suggestion' page uses managedby instead of acceptedby for determining if you can see the suggestion? Anyway, improvement! This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 [Bug 22736] Search field on "New order > from suggestion" search for borrowernumber -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org