[Bug 27795] New: Misalignment of TOTAL value in lateorders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Bug ID: 27795 Summary: Misalignment of TOTAL value in lateorders page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org Created attachment 117323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117323&action=edit Bad alignment of Total cost sum On /cgi-bin/koha/acqui/lateorders.pl page, the "Total cost" sum is align with the quantity column. It should be shift by a column to the right (sees screenshot attached). Maybe the occasion to add a total for "Quantity" column ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117331&action=edit Bug 27795: Misalignment of TOTAL value in lateorders page This patch corrects the colspan in the footer of the late orders page. It also adds a quantity total cell to the footer and changes the container of the buttons at the bottom of the page from a <p> tag to the standard <fieldset class="action">. To test, apply the patch and go to Acquisitions -> Late orders. In the footer of the late orders page, there should be a total under the "Quantity" column. The total cost number should be correctly aligned under the "total cost" header cell. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117331|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117431&action=edit Bug 27795: Misalignment of TOTAL value in lateorders page This patch corrects the colspan in the footer of the late orders page. It also adds a quantity total cell to the footer and changes the container of the buttons at the bottom of the page from a <p> tag to the standard <fieldset class="action">. To test, apply the patch and go to Acquisitions -> Late orders. In the footer of the late orders page, there should be a total under the "Quantity" column. The total cost number should be correctly aligned under the "total cost" header cell. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks good, signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117431|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117732&action=edit Bug 27795: Misalignment of TOTAL value in lateorders page This patch corrects the colspan in the footer of the late orders page. It also adds a quantity total cell to the footer and changes the container of the buttons at the bottom of the page from a <p> tag to the standard <fieldset class="action">. To test, apply the patch and go to Acquisitions -> Late orders. In the footer of the late orders page, there should be a total under the "Quantity" column. The total cost number should be correctly aligned under the "total cost" header cell. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.04 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.04 |21.05.00,20.11.04,20.05.10 released in| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27795 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org