[Bug 17153] New: Logging in during a search navigates to account page instead of back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Bug ID: 17153 Summary: Logging in during a search navigates to account page instead of back to search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: ldjamison@marywood.edu QA Contact: testopia@bugs.koha-community.org When a patron logs in the OPAC on any page, except opac-reserve.pl, they are always redirected to opac-user.pl. This can prove to be problematic in regards to tasks such as navigating search results (including both catalog and EDS searches if the EDS plugin is installed), adding tags, adding comments, or nearly any other action which requires a patron to login. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison@marywood.edu --- Comment #1 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 54657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54657&action=edit Forces redirect to search results after logging in on opac-search.pl To test: - Perform a catalog or EDS search - Login from opac-search.pl - Without the patch, the page should redirect to opac-user.pl - Log out - Apply patch - Perform a search again - Login again from opac-search.pl - The page should redirect back to search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ldjamison@marywood.edu | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 --- Comment #2 from Marc Véron <veron@veron.ch> --- Sorry, while applying I get: "fatal: sha1 information is lacking or useless (opac/opac-user.pl)" Can not fall back to 3-way-merge because of missing Blobs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 --- Comment #3 from Lee Jamison <ldjamison@marywood.edu> --- Sorry about that, Marc! I'm uploading an updated patch now which should correct that fatality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54657|0 |1 is obsolete| | --- Comment #4 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 54715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54715&action=edit Bug 17153: Fixed Fail Fail This updated patch should correct fatal error when applying 54657. Forces redirect to search results after logging in on opac-search.pl To test: - Perform a catalog or EDS search - Login from opac-search.pl - Without the patch, the page should redirect to opac-user.pl - Log out - Apply patch - Perform a search again - Login again from opac-search.pl - The page should redirect back to search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54715|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 54719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54719&action=edit [SIGNED-OFF] Bug 17153: Logging in during a search should navigate back to search results Forces redirect to search results after logging in on opac-search.pl To test: - Perform a catalog or EDS search - Login from opac-search.pl - Without the patch, the page should redirect to opac-user.pl - Log out - Apply patch - Perform a search again - Login again from opac-search.pl - The page should redirect back to search results Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Lee, eds-search.pl is not part of Koha and this part of the patch should be removed I'd say. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |ldjamison@marywood.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54719|0 |1 is obsolete| | --- Comment #7 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 54782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54782&action=edit Bug 17153: Simplified redirect To test: - Perform a catalog search - Login from opac-search.pl - Without the patch, the page should redirect to opac-user.pl - Log out - Apply patch - Perform a search again - Login again from opac-search.pl - The page should redirect back to search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- This works for me, but the QA tools warn that the changes to Output.pm introduce tab characters. Indentation should be 4 spaces: https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL6:_Indentation When you modify your patch, please use the bug report title as the commit message's first line: "Bug 17153 - Logging in during a search navigates to account page instead of back to search results" ...and include test plan in your commit message as well. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 --- Comment #9 from Lee Jamison <ldjamison@marywood.edu> --- Owen, Thank you for the constructive criticism! This was my very first attempt at a bug report so I'm still learning. I made a note to myself to make your suggestions a habit from now on! I'll make necessary changes then re-submit. For my own knowledge, when I upload the update, should I put the status to Needs Signoff? Or Signed Off? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lee Jamison from comment #9)
For my own knowledge, when I upload the update, should I put the status to Needs Signoff? Or Signed Off? Thanks!
Set the status back to "needs signoff" so that everyone knows it is ready for testing again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54782|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57549&action=edit Bug 17153 - Add logic to pass URL to output so redirct to search results can occur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57549|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57550&action=edit Bug 17153 - Add logic to pass URL to output so redirct to search results can occur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2093 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 --- Comment #13 from Viktor Sarge <viktor.sarge@regionhalland.se> --- I would love to see this bug fixed. It's quite annoying to lose your context and having to search again for the book you were about to tag/comment etc. When no longer being taken to opac-user.pl when logging in it will be less obvious for end users how to get to their account. Hence the tagging of 2093 as a "see also". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, is this patch ready for signoff? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54782|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a small conflict, can you please rebase? Applying: Bug 17153 - Add logic to pass URL to output so redirct to search results can occur Using index info to reconstruct a base tree... M C4/Output.pm M opac/opac-search.pl M opac/opac-user.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-user.pl CONFLICT (content): Merge conflict in opac/opac-user.pl Auto-merging opac/opac-search.pl Auto-merging C4/Output.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 17153 - Add logic to pass URL to output so redirct to search results can occur The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17153---Add-logic-to-pass-URL-to-output-so-red-YH0gjy.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54782|0 |1 is obsolete| | Attachment #57550|0 |1 is obsolete| | --- Comment #16 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 75714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75714&action=edit Bug 17153: Login during search rebase and fix This patch is a fresh attempt at redirecting back to search results after logging in on opac-search.pl To test: - Perform an OPAC search - Login on opac-search.pl with the search results displayed - The page is redirected to opac-user.pl - Log out - Apply the patch - Perform a new OPAC search - Note the URL query string - Login on opac-search.pl with the search results displayed - The opac-search.pl page should be displayed with the correct query string and the page should indicate a logged in status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Maryse, did you mean to sign off on this patch? I see that you changed the status. Did you test and can you add your sign-off line to the patch plz? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75714|0 |1 is obsolete| | --- Comment #18 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 75933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75933&action=edit Bug 17153: Login during search rebase and fix This patch is a fresh attempt at redirecting back to search results after logging in on opac-search.pl To test: - Perform an OPAC search - Login on opac-search.pl with the search results displayed - The page is redirected to opac-user.pl - Log out - Apply the patch - Perform a new OPAC search - Note the URL query string - Login on opac-search.pl with the search results displayed - The opac-search.pl page should be displayed with the correct query string and the page should indicate a logged in status Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75933|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76429&action=edit Bug 17153: Login during search rebase and fix This patch is a fresh attempt at redirecting back to search results after logging in on opac-search.pl To test: - Perform an OPAC search - Login on opac-search.pl with the search results displayed - The page is redirected to opac-user.pl - Log out - Apply the patch - Perform a new OPAC search - Note the URL query string - Login on opac-search.pl with the search results displayed - The opac-search.pl page should be displayed with the correct query string and the page should indicate a logged in status Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76429|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76430&action=edit Bug 17153: Redirect to search when logging in from search This patch is a fresh attempt at redirecting back to search results after logging in on opac-search.pl To test: - Perform an OPAC search - Login on opac-search.pl with the search results displayed - The page is redirected to opac-user.pl - Log out - Apply the patch - Perform a new OPAC search - Note the URL query string - Login on opac-search.pl with the search results displayed - The opac-search.pl page should be displayed with the correct query string and the page should indicate a logged in status Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and the patch works. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please always describe your change in your subject line :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, changes behaviour, not backporting for 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org