https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68167&action=edit Bug 19469 - Add ability to split view of holds view on record by pickup library and/or itemtype Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68169&action=edit Bug 19469 - Add ability to split view of holds view on record by pickup library and/or itemtype It is possible to set up circulation rules to limit trapping of holds by pickup library and itemtype. To make it easier to understand which holds will be trapped in a given circumstance, it would be nice if we could optionally group holds by pickup library and/or itemtype. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable AllowHoldItemTypeSelection 4) Pick a record and create holds with various pickup libraries and itemtype combinations 5) Enable HoldsSplitQueueNumbering 6) Try the different combinations of HoldsSplitQueue 7) Ensure the hold "arrows" move the items correctly * Up and down arrows should move hold above or below the adjacent hold within a hold fieldset * Top and borrom arrows should move hold to the top or bottom within a hold fieldset Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68348|0 |1 is obsolete| | --- Comment #8 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- Created attachment 68609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68609&action=edit Bug 19469 - Add ability to split view of holds view on record by pickup library and/or itemtype It is possible to set up circulation rules to limit trapping of holds by pickup library and itemtype. To make it easier to understand which holds will be trapped in a given circumstance, it would be nice if we could optionally group holds by pickup library and/or itemtype. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable AllowHoldItemTypeSelection 4) Pick a record and create holds with various pickup libraries and itemtype combinations 5) Enable HoldsSplitQueueNumbering 6) Try the different combinations of HoldsSplitQueue 7) Ensure the hold "arrows" move the items correctly * Up and down arrows should move hold above or below the adjacent hold within a hold fieldset * Top and borrom arrows should move hold to the top or bottom within a hold fieldset Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68347|0 |1 is obsolete| | Attachment #68609|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 72304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72304&action=edit Bug 19469 - Clean up template whitespace Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace@sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72305|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 72442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72442&action=edit Bug 19469: Add ability to split view of holds view on record by pickup library and/or itemtype It is possible to set up circulation rules to limit trapping of holds by pickup library and itemtype. To make it easier to understand which holds will be trapped in a given circumstance, it would be nice if we could optionally group holds by pickup library and/or itemtype. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable AllowHoldItemTypeSelection 4) Pick a record and create holds with various pickup libraries and itemtype combinations 5) Enable HoldsSplitQueueNumbering 6) Try the different combinations of HoldsSplitQueue 7) Ensure the hold "arrows" move the items correctly * Up and down arrows should move hold above or below the adjacent hold within a hold fieldset * Top and borrom arrows should move hold to the top or bottom within a hold fieldset Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think I found few inconsistencies. Try with HoldsSplitQueue = both and HoldsSplitQueueNumbering = actual.

From this starting point: https://screenshots.firefox.com/TX15YNJl7t9SF3LD/pro.kohadev.org

1. Last lines of the 2 blocks have the "lowest priority" icon, I would expect only the first one (with priority=9) 2. item-level_itypes=item and all of the items.itype=BK, why do I have the item level holds in the "Any item type" block? 3. If I change one of the priority from x to 9 using the selects, nothing happens (same issue if I change 9 to x). I will continue to test when this will be fixed. It is certainly better for the readability to squash the patches. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #18)

Created attachment 74260 [details] [review] Bug 19469: [DO NOT PUSH] Dump of the reserves table

Here is the content of my table "reserves" (on top of sample data). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72441|0 |1 is obsolete| | Attachment #72442|0 |1 is obsolete| | Attachment #72443|0 |1 is obsolete| | Attachment #72501|0 |1 is obsolete| | Attachment #74260|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74328&action=edit Bug 19469: Clean up template whitespace Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74330&action=edit Bug 19469: Add ability to split view of holds view on record by pickup library and/or itemtype It is possible to set up circulation rules to limit trapping of holds by pickup library and itemtype. To make it easier to understand which holds will be trapped in a given circumstance, it would be nice if we could optionally group holds by pickup library and/or itemtype. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable AllowHoldItemTypeSelection 4) Pick a record and create holds with various pickup libraries and itemtype combinations 5) Enable HoldsSplitQueueNumbering 6) Try the different combinations of HoldsSplitQueue 7) Ensure the hold "arrows" move the items correctly * Up and down arrows should move hold above or below the adjacent hold within a hold fieldset * Top and borrom arrows should move hold to the top or bottom within a hold fieldset Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74332&action=edit Bug 19469: Remove use of Dumper on request.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74334&action=edit Bug 19469 [QA Followup]: Use hold item's itemtype if available, fix priority changing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I wanted to retest but stopped quickly because I either do not understand how it is supposed to work or it is buggy: I am using the same reserves.sql data, with HoldsSplitQueue=pickup, HoldsSplitQueueNumbering=actual On the reserve page, I see that: https://screenshots.firefox.com/DDTe7dEmVOK4regX/pro.kohadev.org First line of Franklin, I select 9, and I get: https://screenshots.firefox.com/r8FS1f2Q3SFw9Ngg/pro.kohadev.org (without resubmitting the form, just selecting a value in the dropdown list). Moreover I am wondering why we have the column with "go lowest" and "go bottom" (before the red X to cancel). Is not it redundant with the other 4 arrows column? Same behaviour in master, just wondering if we should not remove this column on a separate bug report. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> ---

Moreover I am wondering why we have the column with "go lowest" and "go bottom" (before the red X to cancel). Is not it redundant with the other 4 arrows column? Same behaviour in master, just wondering if we should not remove this column on a separate bug report.

The 'lowest priority' is a separate feature and is not the same as simply moving the hold to the bottom of the queue. It 'pins' the hold to the bottom so any new holds added are automatically put in front of those holds in the queue. We should not remove this column as it is a feature and is not redundant. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #32 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- (In reply to Jonathan Druart from comment #28)

I am using the same reserves.sql data, with HoldsSplitQueue=pickup, HoldsSplitQueueNumbering=actual On the reserve page, I see that: https://screenshots.firefox.com/DDTe7dEmVOK4regX/pro.kohadev.org

First line of Franklin, I select 9, and I get: https://screenshots.firefox.com/r8FS1f2Q3SFw9Ngg/pro.kohadev.org (without resubmitting the form, just selecting a value in the dropdown list).

I'm a bit confused by these two. So you are using the same setting for the second screenshot, but when editing the first hold of Franklin, instead of showing the actual numbers it reverts to showing separate queue priorities? That does sound like a unwanted behavior, unless I'm missing something... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 74909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74909&action=edit Bug 19469 [QA Followup]: When altering priorities, use the existing priority numbers of the given table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Either it still does not work or it is very confusing (or I do not understand how it is supposed to work). As we are in feature freeze I am not willing to push this one for 18.05 and would recommend another QA stamp. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Patch doesn't apply --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Kyle can you rebase this for SCSS and bug 13618? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74329|0 |1 is obsolete| | Attachment #74330|0 |1 is obsolete| | Attachment #74331|0 |1 is obsolete| | Attachment #74332|0 |1 is obsolete| | Attachment #74333|0 |1 is obsolete| | Attachment #74334|0 |1 is obsolete| | Attachment #74909|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 78506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78506&action=edit Bug 19469: Clean up template whitespace Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 78508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78508&action=edit Bug 19469: Add ability to split view of holds view on record by pickup library and/or itemtype It is possible to set up circulation rules to limit trapping of holds by pickup library and itemtype. To make it easier to understand which holds will be trapped in a given circumstance, it would be nice if we could optionally group holds by pickup library and/or itemtype. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable AllowHoldItemTypeSelection 4) Pick a record and create holds with various pickup libraries and itemtype combinations 5) Enable HoldsSplitQueueNumbering 6) Try the different combinations of HoldsSplitQueue 7) Ensure the hold "arrows" move the items correctly * Up and down arrows should move hold above or below the adjacent hold within a hold fieldset * Top and borrom arrows should move hold to the top or bottom within a hold fieldset Sponsored-by: Stockholm University Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 78510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78510&action=edit Bug 19469: Remove use of Dumper on request.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 78512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78512&action=edit Bug 19469 [QA Followup]: Use hold item's itemtype if available, fix priority changing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78526&action=edit Bug 19469: (RM follow-up) Add filters and fix variable name -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78526|0 |1 is obsolete| | --- Comment #48 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78529&action=edit (RM follow-up) Add filters and fix variable name -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21611 [Bug 21611] Priority in request.pl shows 1 instead of Waiting -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #52)

Links on the "multi holds" view are broken, please fix.

Ok done, it was an easy fix. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #55)

Created attachment 81829 [details] [review] Bug 19469: Fix record links on multi holds

Follow-up pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |ability to visually | |separate the holds list on | |a record by library and/or | |itemtype. | | | |This can make it | |a bit clearer who is in | |line next for a hold at | |each branch or if user has | |specified a specific type. | | | |The system preference | |HoldsSplitQueue and | |HoldsSplitQueueNumbering | |control this behaviour. | |When activated holds can | |only be adjusted using the | |arrows, the dropdown | |priority menu is disabled. -- You are receiving this mail because: You are watching all bug changes.