https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27974 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118427&action=edit Bug 27974: Replace obsolete title-string sorting: Circulation templates This patch modifies several circulation templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Circulation -> Checkout notes - To populate the table, enable the "AllowCheckoutNotes" system preference enabled, log in to the OPAC as a user with checkouts. From the "Your summary" page use the "Report a problem" fields to submit notes. - Circulation -> On-site checkouts - Requires the "OnSiteCheckouts" system preference to be enabled and and for some items to be checked out as on-site checkouts. - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Transfers to send - Requires the "StockRotation" preference to be enabled, some rotas to be set up, and for the stockrotation cron job to be executed. - Circulation -> Transfers to receive - Circulation -> Holds queue -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27974 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118427|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27974 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118437&action=edit Bug 27974: Replace obsolete title-string sorting: Circulation templates This patch modifies several circulation templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Circulation -> Checkout notes - To populate the table, enable the "AllowCheckoutNotes" system preference enabled, log in to the OPAC as a user with checkouts. From the "Your summary" page use the "Report a problem" fields to submit notes. - Circulation -> On-site checkouts - Requires the "OnSiteCheckouts" system preference to be enabled and and for some items to be checked out as on-site checkouts. - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Transfers to send - Requires the "StockRotation" preference to be enabled, some rotas to be set up, and for the stockrotation cron job to be executed. - Circulation -> Transfers to receive - Circulation -> Holds queue -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27974 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118437|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118456&action=edit Bug 27974: Replace obsolete title-string sorting: Circulation templates This patch modifies several circulation templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Circulation -> Checkout notes - To populate the table, enable the "AllowCheckoutNotes" system preference enabled, log in to the OPAC as a user with checkouts. From the "Your summary" page use the "Report a problem" fields to submit notes. - Circulation -> On-site checkouts - Requires the "OnSiteCheckouts" system preference to be enabled and and for some items to be checked out as on-site checkouts. - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Transfers to send - Requires the "StockRotation" preference to be enabled, some rotas to be set up, and for the stockrotation cron job to be executed. - Circulation -> Transfers to receive - Circulation -> Holds queue Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27974 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118798&action=edit Bug 27974: (follow-up) Address missing instance - Circulation -> Article requests - Both the "Pending" and "Processing" tabs. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27974 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118456|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118895&action=edit Bug 27974: Replace obsolete title-string sorting: Circulation templates This patch modifies several circulation templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Circulation -> Checkout notes - To populate the table, enable the "AllowCheckoutNotes" system preference enabled, log in to the OPAC as a user with checkouts. From the "Your summary" page use the "Report a problem" fields to submit notes. - Circulation -> On-site checkouts - Requires the "OnSiteCheckouts" system preference to be enabled and and for some items to be checked out as on-site checkouts. - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Transfers to send - Requires the "StockRotation" preference to be enabled, some rotas to be set up, and for the stockrotation cron job to be executed. - Circulation -> Transfers to receive - Circulation -> Holds queue Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27974 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if we should change the module to Templates as that would make them all sort together in release notes and as we expect no behaviour change. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27974 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Templates -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27974 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27974 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.