[Bug 30093] New: Rewrite some of the patron searches when placing a hold with the REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Bug ID: 30093 Summary: Rewrite some of the patron searches when placing a hold with the REST API route Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094 [Bug 30094] Rewrite some of the patron searches when requesting an article with the REST API route -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rewrite some of the patron |Rewrite the patron search |searches when placing a |when placing a hold with |hold with the REST API |the REST API route |route | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130605&action=edit Bug 30093: Rename patron-search.inc to patron-search-header.inc We will use 'patron-search.inc' in the next patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130606&action=edit Bug 30093: Make patron search from request.pl use the REST API In this patch we want to reuse what has been done in the previous bug report to search patrons using the REST API route. The code is mainly in members/search.tt, for all the patron searches that "add" or "select" a patron (popup windows). The patron search for holds is a bit different, we don't want to open a popup window. We are moving to code to an include file (patron-search.tt) to make it reusable easily. Note that we are improving how the patron's addresses are displayed, and provide a JS equivalent to the TT includes files. Test plan: Search for patrons from the "Place a hold on" view. You should see the same view as behaviour, with more filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30055 |30074, 29136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 [Bug 29136] Patron search on request.pl has performance and display issues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30074 [Bug 30074] Missing extended_attributes relationship in DBIC schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130605|0 |1 is obsolete| | Attachment #130606|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130627&action=edit Bug 30093: Rename patron-search.inc to patron-search-header.inc We will use 'patron-search.inc' in the next patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130628&action=edit Bug 30093: Make patron search from request.pl use the REST API In this patch we want to reuse what has been done in the previous bug report to search patrons using the REST API route. The code is mainly in members/search.tt, for all the patron searches that "add" or "select" a patron (popup windows). The patron search for holds is a bit different, we don't want to open a popup window. We are moving to code to an include file (patron-search.tt) to make it reusable easily. Note that we are improving how the patron's addresses are displayed, and provide a JS equivalent to the TT includes files. Test plan: Search for patrons from the "Place a hold on" view. You should see the same view as behaviour, with more filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- I like it. However, the autocomplete when you start typing a name is no longer working (it was previously the same as when searching from the patron screens or the header box with search patrons selected). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Nind from comment #5)
I like it.
However, the autocomplete when you start typing a name is no longer working (it was previously the same as when searching from the patron screens or the header box with search patrons selected).
As the search is more effective now, with all the filters available, I removed it on purpose. Do you think it's really needed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130628|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130705&action=edit Bug 30093: Make patron search from request.pl use the REST API In this patch we want to reuse what has been done in the previous bug report to search patrons using the REST API route. The code is mainly in members/search.tt, for all the patron searches that "add" or "select" a patron (popup windows). The patron search for holds is a bit different, we don't want to open a popup window. We are moving to code to an include file (patron-search.tt) to make it reusable easily. Note that we are improving how the patron's addresses are displayed, and provide a JS equivalent to the TT includes files. Test plan: Search for patrons from the "Place a hold on" view. You should see the same view as behaviour, with more filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #6)
(In reply to David Nind from comment #5)
I like it.
However, the autocomplete when you start typing a name is no longer working (it was previously the same as when searching from the patron screens or the header box with search patrons selected).
As the search is more effective now, with all the filters available, I removed it on purpose. Do you think it's really needed?
It's usually a feature people quite like independent of the other search options, but hard to tell without testing the patch more closely for comparison. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130627|0 |1 is obsolete| | Attachment #130705|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130944&action=edit Bug 30093: Rename patron-search.inc to patron-search-header.inc We will use 'patron-search.inc' in the next patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130945&action=edit Bug 30093: Make patron search from request.pl use the REST API In this patch we want to reuse what has been done in the previous bug report to search patrons using the REST API route. The code is mainly in members/search.tt, for all the patron searches that "add" or "select" a patron (popup windows). The patron search for holds is a bit different, we don't want to open a popup window. We are moving to code to an include file (patron-search.tt) to make it reusable easily. Note that we are improving how the patron's addresses are displayed, and provide a JS equivalent to the TT includes files. Test plan: Search for patrons from the "Place a hold on" view. You should see the same view as behaviour, with more filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130946&action=edit bug 30093: Restore the autocomplete feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Bug 30093 depends on bug 30074, which changed state. Bug 30074 Summary: Missing extended_attributes relationship in DBIC schema https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30074 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Bug 30093 depends on bug 29136, which changed state. Bug 29136 Summary: Patron search on request.pl has performance and display issues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130944|0 |1 is obsolete| | Attachment #130945|0 |1 is obsolete| | Attachment #130946|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131830&action=edit Bug 30093: Rename patron-search.inc to patron-search-header.inc We will use 'patron-search.inc' in the next patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131831&action=edit Bug 30093: Make patron search from request.pl use the REST API In this patch we want to reuse what has been done in the previous bug report to search patrons using the REST API route. The code is mainly in members/search.tt, for all the patron searches that "add" or "select" a patron (popup windows). The patron search for holds is a bit different, we don't want to open a popup window. We are moving to code to an include file (patron-search.tt) to make it reusable easily. Note that we are improving how the patron's addresses are displayed, and provide a JS equivalent to the TT includes files. Test plan: Search for patrons from the "Place a hold on" view. You should see the same view as behaviour, with more filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131832&action=edit bug 30093: Restore the autocomplete feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131831|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132537&action=edit Bug 30093: Make patron search from request.pl use the REST API In this patch we want to reuse what has been done in the previous bug report to search patrons using the REST API route. The code is mainly in members/search.tt, for all the patron searches that "add" or "select" a patron (popup windows). The patron search for holds is a bit different, we don't want to open a popup window. We are moving to code to an include file (patron-search.tt) to make it reusable easily. Note that we are improving how the patron's addresses are displayed, and provide a JS equivalent to the TT includes files. Test plan: Search for patrons from the "Place a hold on" view. You should see the same view as behaviour, with more filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131832|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132538&action=edit bug 30093: Restore the autocomplete feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Fixing bug 30055 comment 85 point 4. Changes: [% CASE 'branch' %] library_id = $("#branchcode_filter").val() || ""; patrons_table.find('thead tr:eq(1) th[data-filter="libraries"] select').val(library_id); - if (library_id) - table_dt.column([% loop.count - 1 %]).search('^'+library_id+'$'); + table_dt.column([% loop.count - 1 %]).search(library_id ? '^'+library_id+'$' : ''); [% CASE 'category' %] let category_id = $("#categorycode_filter").val() || ""; patrons_table.find('thead tr:eq(1) th[data-filter="categories"] select').val(category_id); - if (category_id) - table_dt.column([% loop.count - 1 %]).search('^'+category_id+'$'); + table_dt.column([% loop.count - 1 %]).search(category_id ? '^'+category_id+'$' : ''); [% END %] [% END %] table_dt.search(""); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131830|0 |1 is obsolete| | Attachment #132537|0 |1 is obsolete| | Attachment #132538|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132540&action=edit Bug 30093: Rename patron-search.inc to patron-search-header.inc We will use 'patron-search.inc' in the next patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132541&action=edit Bug 30093: Make patron search from request.pl use the REST API In this patch we want to reuse what has been done in the previous bug report to search patrons using the REST API route. The code is mainly in members/search.tt, for all the patron searches that "add" or "select" a patron (popup windows). The patron search for holds is a bit different, we don't want to open a popup window. We are moving to code to an include file (patron-search.tt) to make it reusable easily. Note that we are improving how the patron's addresses are displayed, and provide a JS equivalent to the TT includes files. Test plan: Search for patrons from the "Place a hold on" view. You should see the same view as behaviour, with more filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132542&action=edit bug 30093: Restore the autocomplete feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Failed QA --- Comment #21 from Séverine Queune <severine.queune@bulac.fr> --- I failed the patch because the launching the search isn't taken into account anymore, and all users are display. To reproduce : - search for keychain that brings several users ('hen' for example) - in master, only the 2 results matching with 'hen' are displayed - with the patch, all users are displayed I don't think it's the expected behaviour. All the other points are ok for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132541|0 |1 is obsolete| | Attachment #132542|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132647&action=edit Bug 30093: Make patron search from request.pl use the REST API In this patch we want to reuse what has been done in the previous bug report to search patrons using the REST API route. The code is mainly in members/search.tt, for all the patron searches that "add" or "select" a patron (popup windows). The patron search for holds is a bit different, we don't want to open a popup window. We are moving to code to an include file (patron-search.tt) to make it reusable easily. Note that we are improving how the patron's addresses are displayed, and provide a JS equivalent to the TT includes files. Test plan: Search for patrons from the "Place a hold on" view. You should see the same view as behaviour, with more filters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132648&action=edit bug 30093: Restore the autocomplete feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Séverine Queune from comment #21)
I failed the patch because the launching the search isn't taken into account anymore, and all users are display. To reproduce : - search for keychain that brings several users ('hen' for example) - in master, only the 2 results matching with 'hen' are displayed - with the patch, all users are displayed
I don't think it's the expected behaviour. All the other points are ok for me.
It was fixed in a follow-up bugs, but I fixed the patches here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132540|0 |1 is obsolete| | --- Comment #25 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132653&action=edit Bug 30093: Rename patron-search.inc to patron-search-header.inc We will use 'patron-search.inc' in the next patch Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132647|0 |1 is obsolete| | --- Comment #26 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132654&action=edit Bug 30093: Make patron search from request.pl use the REST API In this patch we want to reuse what has been done in the previous bug report to search patrons using the REST API route. The code is mainly in members/search.tt, for all the patron searches that "add" or "select" a patron (popup windows). The patron search for holds is a bit different, we don't want to open a popup window. We are moving to code to an include file (patron-search.tt) to make it reusable easily. Note that we are improving how the patron's addresses are displayed, and provide a JS equivalent to the TT includes files. Test plan: Search for patrons from the "Place a hold on" view. You should see the same view as behaviour, with more filters. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132648|0 |1 is obsolete| | --- Comment #27 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132655&action=edit bug 30093: Restore the autocomplete feature Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #28 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Jonathan Druart from comment #24)
(In reply to Séverine Queune from comment #21)
I failed the patch because the launching the search isn't taken into account anymore, and all users are display. To reproduce : - search for keychain that brings several users ('hen' for example) - in master, only the 2 results matching with 'hen' are displayed - with the patch, all users are displayed
I don't think it's the expected behaviour. All the other points are ok for me.
It was fixed in a follow-up bugs, but I fixed the patches here.
Nice, I works fine now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- One for a later follow-up rather than hold up this series.. but I did a quick poll and so far everyone I aske doesn't like having two search boxes appearing.. especially as they're not synced. We should either introduce an option to remove the search box from the datatable or after initial search submission we should hide the main search box and populate the datatable one with the query we just performed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132699&action=edit Search results view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132700&action=edit Bug 30093: Fix QA failures -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The console.log is expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132655|0 |1 is obsolete| | Attachment #132700|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132701&action=edit Bug 30093: Restore the autocomplete feature Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132702&action=edit Bug 30093: Fix QA failures -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132653|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132724&action=edit Bug 30093: Rename patron-search.inc to patron-search-header.inc We will use 'patron-search.inc' in the next patch Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132654|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132725&action=edit Bug 30093: Make patron search from request.pl use the REST API In this patch we want to reuse what has been done in the previous bug report to search patrons using the REST API route. The code is mainly in members/search.tt, for all the patron searches that "add" or "select" a patron (popup windows). The patron search for holds is a bit different, we don't want to open a popup window. We are moving to code to an include file (patron-search.tt) to make it reusable easily. Note that we are improving how the patron's addresses are displayed, and provide a JS equivalent to the TT includes files. Test plan: Search for patrons from the "Place a hold on" view. You should see the same view as behaviour, with more filters. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132701|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132726&action=edit Bug 30093: Restore the autocomplete feature Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132702|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132727&action=edit Bug 30093: Fix QA failures Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132728&action=edit Bug 30093: (QA follow-up) Final QA Script Fix Just remove a console log that crept in somewhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All looking good again here.. the search box stuff can certainly happen on a later bug report, especially after a little further feedback. QA scripts now happy, though I did have to add another minor follow-up to drop a console.log that was introduced.. feel free to squash or drop that follow-up as required. Great work, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #41 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Bug 30093 depends on bug 30055, which changed state. Bug 30055 Summary: Rewrite some of the patron searches to make them use the REST API routes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36619 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36619 [Bug 36619] Cannot show/hide columns on the patron search table when placing a hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30074 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30074 [Bug 30074] Missing extended_attributes relationship in DBIC schema -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org