[Bug 5928] New: Allow selection of "purchase for" library in Purchase Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Bug #: 5928 Summary: Allow selection of "purchase for" library in Purchase Suggestions Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC Comments AssignedTo: gmcharlt@gmail.com ReportedBy: shelley@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org In the OPAC, allow the patron to choose which branch they wish to make a purchase suggestion for. This should default to their home library. The option to show or hide this dropdown menu should be controllable by a system preference. Adding option to choose branch in purchase suggestion. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Shelley <shelley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored AssignedTo|gmcharlt@gmail.com |chris@bigballofwax.co.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|chris@bigballofwax.co.nz |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-03-22 04:16:12 UTC --- Created attachment 3392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3392 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Does not apply --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-03-22 21:00:58 UTC --- wr77152 (bug 5928): AllowPurchaseSuggestionBranchChoice sys pref -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: wr77152 (bug 5928): AllowPurchaseSuggestionBranchChoice sys pref Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/en/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/en/mandatory/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. Patch failed at 0001 wr77152 (bug 5928): AllowPurchaseSuggestionBranchChoice sys pref When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3392|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-22 21:09:36 UTC --- Created attachment 3404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3404 Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-03-22 21:18:35 UTC --- Signed off on first and submitted a follow up for sign off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-03-22 21:19:23 UTC --- Created attachment 3405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3405 follow up patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-22 21:51:29 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> 2011-04-05 12:27:33 UTC --- This works, but opac-suggestions.pl shows the home branch in "suggested for" column instead of the suggestion branch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 --- Comment #8 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-04-06 05:22:22 UTC --- Created attachment 3721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3721 fix patch Fixed branch display -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Needs Signoff --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-06 07:21:28 UTC --- Fix patch is awaiting sign off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Patch Status|Needs Signoff |Does not apply --- Comment #10 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-04-07 08:14:50 UTC --- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3404 Attachement 3404: conflits -------------------------- Bug 5928 :wr77152 : AllowPurchaseSuggestionBranchChoice sys pref -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5928 :wr77152 : AllowPurchaseSuggestionBranchChoice sys pref Using index info to reconstruct a base tree... <stdin>:26: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging admin/systempreferences.pl Auto-merging installer/data/mysql/en/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/en/mandatory/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tmpl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tmpl Failed to merge in the changes. Patch failed at 0001 Bug 5928 :wr77152 : AllowPurchaseSuggestionBranchChoice sys pref -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 --- Comment #11 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-04-08 03:51:12 UTC --- I've just merged master into my branch cleanly. Can you please try again, and if it's still making problems, I will reformat. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 --- Comment #12 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> 2011-04-08 07:53:24 UTC --- Thanks. Your "fix patch" replace "Patch" attachment? Message I see when I apply it: wr77152 (bug 5928): AllowPurchaseSuggestionBranchChoice sys pref -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: wr77152 (bug 5928): AllowPurchaseSuggestionBranchChoice sys pref Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging admin/systempreferences.pl Auto-merging installer/data/mysql/en/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/en/mandatory/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tmpl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tmpl Failed to merge in the changes. Patch failed at 0001 wr77152 (bug 5928): AllowPurchaseSuggestionBranchChoice sys pref -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC Comments |OPAC -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 --- Comment #13 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-09 09:25:23 UTC --- This bug is mentioned in: Bug 5928 :wr77152 : AllowPurchaseSuggestionBranchChoice sys pref http://lists.koha-community.org/pipermail/koha-patches/2011-March/014194.htm... Bug 5928 follow up remove branchcode label http://lists.koha-community.org/pipermail/koha-patches/2011-March/014195.htm... wr77152 (bug 5928): AllowPurchaseSuggestionBranchChoice sys pref http://lists.koha-community.org/pipermail/koha-patches/2011-March/014257.htm... Bug 5928 :wr77152 : AllowPurchaseSuggestionBranchChoice sys pref http://lists.koha-community.org/pipermail/koha-patches/2011-March/014193.htm... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-08 00:02:03 UTC --- Needs to be rebased onto master for Template::Toolkit -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3721|0 |1 is obsolete| | --- Comment #15 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-07-22 01:00:51 UTC --- Created attachment 4705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4705 patch Depends on bug 5917 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5917 Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 --- Comment #16 from Nicole C. Engard <nengard@gmail.com> 2011-07-22 01:15:24 UTC --- I'm confused by this patch - the preference is already there, but this patch adds it again (I think) and also it doesn't look like it's Template Toolkit but the old templating system (I did not try to apply the patch). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4705|0 |1 is obsolete| | --- Comment #17 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-07-22 04:11:15 UTC --- Created attachment 4708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4708 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 --- Comment #18 from Nicole C. Engard <nengard@gmail.com> 2011-07-22 16:56:36 UTC --- Can you please include more of a description on the patch here? What does this do and how do I test it? Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 --- Comment #19 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-07-25 23:05:48 UTC --- In the OPAC, allow the patron to choose which branch they wish to make a purchase suggestion for. This should default to their home library. The option to show or hide this dropdown menu should be controllable by a system preference. The preference is AllowPurchaseSuggestionBranchChoice -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 --- Comment #20 from Nicole C. Engard <nengard@gmail.com> 2011-08-01 13:33:40 UTC --- Okay, that's what I thought it did, but that preference already exists, so now I'm confused. Has this patch been pushed? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Patch Pushed --- Comment #21 from Owen Leonard <oleonard@myacpl.org> 2011-08-12 15:37:54 UTC --- Looks to me like this has been pushed but I don't see any changes to the administrative side to make this information available to the staff. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5917 | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5928 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #21)
Looks to me like this has been pushed but I don't see any changes to the administrative side to make this information available to the staff.
Seems to be working fine now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org