[Bug 11194] New: Add a new index for edition of a document
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Bug ID: 11194 Summary: Add a new index for edition of a document Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org Edition of a document (205 in UNIMARC) could be indexed in a specific index. "Edition" index exists in bib1 for this purpose, but is not used in Koha M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi Summary|Add a new index for edition |Add a new index for |of a document |"Edition Statement" of a | |MARC Record -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 36978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36978&action=edit Bug 11194 - Add a new index for "Edition Statement" of a MARC Record Adds the "Edition Statement" MARC-field as a sortable search index in Koha. This Field is also used by the MARC::Record->edition(). It is mapped to search keyword "edition" and it targets the following MARC-fields: UNIMARC: all 205-subfields concatenated MARC21 : all 250-subfields concatenated NORMARC: all 250-subfields concatenated After applying this patch a full biblio reindexing needs to be done to make old records searchable. New Biblios, and Biblios that are part of some operations (checkin/out/hold/...), are searchable. These generate good test data to test this feature without fully reindexing the search index. TEST PLAN: 1. Find a record with some data in the "Edition Statement" -field. 2. Modify that Record and reindex it. 3. Search with the keyword "edition='<edition_statement>'" where <edition_statement> is the stuff you wrote in the MARC-field. 4. Observe the found record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36978|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 36979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36979&action=edit Bug 11194 - Add a new index for "Edition Statement" of a MARC Record Adds the "Edition Statement" MARC-field as a sortable search index in Koha. This Field is also used by the MARC::Record->edition(). It is mapped to search keyword "edition" and it targets the following MARC-fields: UNIMARC: all 205-subfields concatenated MARC21 : all 250-subfields concatenated NORMARC: all 250-subfields concatenated After applying this patch a full biblio reindexing needs to be done to make old records searchable. New Biblios, and Biblios that are part of some operations (checkin/out/hold/...), are searchable. These generate good test data to test this feature without fully reindexing the search index. TEST PLAN: 0. Move the search index and search word definitions from the koha source code to the directory where Zebra uses them. This is most easiest to do by reinstalling Koha, but can be manually moved as well. 1. Find a record with some data in the "Edition Statement" -field. 2. Modify that Record and reindex it. 3. Search with the keyword "edition='<edition_statement>'" where <edition_statement> is the stuff you wrote in the MARC-field. 4. Observe the found record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- There is still an issue regarding sorting this index. Editions can be given in many ways, eg. 1. 2. 3. I II VI 2nd 3rd 1-2. ... How to sort them smartly? This is something for a followup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |olli-antti.kivilahti@jns.fi -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36979|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 40321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40321&action=edit [SIGNED-OFF] Bug 11194: Add a new index for "Edition Statement" of a MARC Record Adds the "Edition Statement" MARC-field as a sortable search index in Koha. This Field is also used by the MARC::Record->edition(). It is mapped to search keyword "edition" and it targets the following MARC-fields: UNIMARC: all 205-subfields concatenated MARC21 : all 250-subfields concatenated NORMARC: all 250-subfields concatenated After applying this patch a full biblio reindexing needs to be done to make old records searchable. New Biblios, and Biblios that are part of some operations (checkin/out/hold/...), are searchable. These generate good test data to test this feature without fully reindexing the search index. TEST PLAN: 0. Move the search index and search word definitions from the koha source code to the directory where Zebra uses them. This is most easiest to do by reinstalling Koha, but can be manually moved as well. 1. Find a record with some data in the "Edition Statement" -field. 2. Modify that Record and reindex it. 3. Search with the keyword "edition='<edition_statement>'" where <edition_statement> is the stuff you wrote in the MARC-field. 4. Observe the found record. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested on MARC21 and UNIMARC, works No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Olli, You have to provide changes for the record.abs file, have a look at this wiki page: http://wiki.koha-community.org/wiki/MRenvoize/zebra#DOM_indexing to generate the xsl and xml files from record.abs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Maybe not, waiting for an answer from Tomas. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- I know nothing about the record.abs Is that something new? I haven't seen other bugs that modify indexes to modify record.abs? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Olli-Antti Kivilahti from comment #7)
I know nothing about the record.abs Is that something new? I haven't seen other bugs that modify indexes to modify record.abs?
It's used for GRS1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Just a note for people interested on this bug, we don't touch GRS1-related stuff anymore as of the 3.16 release. record.abs is the file used in GRS-1 for defining indexes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40939&action=edit [PASSED QA] Bug 11194: Add a new index for "Edition Statement" of a MARC Record Adds the "Edition Statement" MARC-field as a sortable search index in Koha. This Field is also used by the MARC::Record->edition(). It is mapped to search keyword "edition" and it targets the following MARC-fields: UNIMARC: all 205-subfields concatenated MARC21 : all 250-subfields concatenated NORMARC: all 250-subfields concatenated After applying this patch a full biblio reindexing needs to be done to make old records searchable. New Biblios, and Biblios that are part of some operations (checkin/out/hold/...), are searchable. These generate good test data to test this feature without fully reindexing the search index. TEST PLAN: 0. Move the search index and search word definitions from the koha source code to the directory where Zebra uses them. This is most easiest to do by reinstalling Koha, but can be manually moved as well. 1. Find a record with some data in the "Edition Statement" -field. 2. Modify that Record and reindex it. 3. Search with the keyword "edition='<edition_statement>'" where <edition_statement> is the stuff you wrote in the MARC-field. 4. Observe the found record. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested on MARC21 and UNIMARC, works No errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Attachment #40321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40321|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40321|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41376&action=edit Bug 11194: Add a new index for "Edition Statement" of a MARC Record Adds the "Edition Statement" MARC-field as a sortable search index in Koha. This Field is also used by the MARC::Record->edition(). It is mapped to search keyword "edition" and it targets the following MARC-fields: UNIMARC: all 205-subfields concatenated MARC21 : all 250-subfields concatenated NORMARC: all 250-subfields concatenated After applying this patch a full biblio reindexing needs to be done to make old records searchable. New Biblios, and Biblios that are part of some operations (checkin/out/hold/...), are searchable. These generate good test data to test this feature without fully reindexing the search index. TEST PLAN: 0. Move the search index and search word definitions from the koha source code to the directory where Zebra uses them. This is most easiest to do by reinstalling Koha, but can be manually moved as well. 1. Find a record with some data in the "Edition Statement" -field. 2. Modify that Record and reindex it. 3. Search with the keyword "edition='<edition_statement>'" where <edition_statement> is the stuff you wrote in the MARC-field. 4. Observe the found record. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested on MARC21 and UNIMARC, works No errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Olli, can u add it to queryparser.yml also please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I see problems with this patch: - It forgets to add to queryparser.yml - It adds to the QueryParser test code, but the numbers look weird. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org