[Bug 9210] New: Automatic carriage return are missing in print letters generated for holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Bug ID: 9210 Summary: Automatic carriage return are missing in print letters generated for holds Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: sophie.meynieux@biblibre.com When you generate print letters (pdf) for holds with gather_print_notices.pl, lines that are too long are truncated and not automatically wrapped to another line. This patch modify styles in the template used for generation of pdf files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6030 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 13884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13884&action=edit Bug 9210 : letters generated for holds are missing wrapping for words and lines. This commit adds wrapping styles to print-notices.tt template -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13884|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13934&action=edit Bug 9210 : letters generated for holds are missing wrapping for words and lines. This commit adds wrapping styles to print-notices.tt template Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13934|0 |1 is obsolete| | --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14225&action=edit Bug 9210 : letters generated for holds are missing wrapping for words and lines. This commit adds wrapping styles to print-notices.tt template Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny patch, css only, no side effect risk passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Could you please provide a detailed test plan for this patch? The description talks about gather_print_notices.pl producing a PDF, but it doesn't seem to do that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Marking as "Failed QA" until I have an answer about the test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |sophie.meynieux@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14225|0 |1 is obsolete| | --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14398&action=edit Bug 9210 : letters generated for holds are missing wrapping for words and lines. This commit adds wrapping styles to print-notices.tt template Test plan: * place a hold on a title with a very very long title or author * mark it as "waiting for pickup" by doing a checkin * go to command line interface, and run * misc/cronjobs/gather_print_notices.pl /tmp * misc/cronjobs/printoverdues.sh /tmp * if your title/author is long enough, it's splitted on 2 lines with this patch (it is not before this patch) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- test plan now attached to the bug -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The script misc/cronjobs/printoverdues.sh does not work at all for me: jcamins@kohadev:~/kohaclone$ sh -v misc/cronjobs/printoverdues.sh /tmp [9/1955] #!/bin/bash print_usage(){ echo "$0 : generates PDF files from html files in directorys and prints them"; echo "usage :"; echo "$0 directory [css [printer_host [printername]]]" echo " - directory directory to use to apply html2pdf transform"; echo " - css css file to apply to html "; echo " - printer_host Network Name or IP of the printer (port possibly included) "; echo " - printer_name printername "; echo "Note that css printerhost and printername are optional parameters "; echo "Note that this script uses xhtml2pdf command "; echo " xhtml2pdf command comes with pisa (a python library) To install you need setuptools library for python then type easy_install pisa "; exit 1; } if [ $# -lt 1 ] then print_usage fi if [[ ! -d $1 ]] then echo "$1 : directory expected"; exit 1; fi misc/cronjobs/printoverdues.sh: 23: misc/cronjobs/printoverdues.sh: [[: not found if [[ -n $2 && -f $2 ]] then optpisa="--css $2"; fi misc/cronjobs/printoverdues.sh: 28: misc/cronjobs/printoverdues.sh: [[: not found if [[ -n $3 ]] then optprinter="-h $3"; fi misc/cronjobs/printoverdues.sh: 32: misc/cronjobs/printoverdues.sh: [[: not found if [[ -n $4 ]] then optprinter="$optprinter -d $4"; fi misc/cronjobs/printoverdues.sh: 36: misc/cronjobs/printoverdues.sh: [[: not found for i in $1/*.html do xhtml2pdf $optpisa $i; done if [[ -n $optprinter ]] then lp $optprinter $1/*.pdf; fi misc/cronjobs/printoverdues.sh: 45: misc/cronjobs/printoverdues.sh: [[: not found tar cvfz $directory`date "+%Y%m%d"`.tar.gz $directory; tar: Cowardly refusing to create an empty archive Try `tar --help' or `tar --usage' for more information. A fix to the syntax so that the script works on current master will be needed before I can push this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Sorry Jared, but I don't understand your last comment. What's your problem ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #10)
Sorry Jared, but I don't understand your last comment. What's your problem ?
There's a syntax error in the printoverdues.sh script, on line 45, and I won't push a patch that can't be tested. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Okay, the problem was that I was using sh when printoverdues.sh is actually a bash script. However, the patch results in a major regression. Instead of having a formatted hold notice with one line going off the edge of the paper, all the text is run together: http://kohadev.cpbibliography.com/holdnotices-2013-01-24.pdf -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #13 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Jared, I can't see your generated pdf file. Could you attach it and also the html file, please. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #14 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Jared, with the html file you send me, I can't generate a formatted pdf file even without the patch. This patch only deals with wrapping long lines, not carriage return (title is confusing) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #15 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 16414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16414&action=edit html file used to test pdf generation This file is mentionned in comments -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m QA Contact|paul.poulain@biblibre.com |jonathan.druart@biblibre.co | |m --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- I don't know why this one is still needs signoff. It has been signed off twice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: The patch works great, see the 2 pdf I will send. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14398|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24394&action=edit Bug 9210 : letters generated for holds are missing wrapping for words and lines. This commit adds wrapping styles to print-notices.tt template Test plan: * place a hold on a title with a very very long title or author * mark it as "waiting for pickup" by doing a checkin * go to command line interface, and run * misc/cronjobs/gather_print_notices.pl /tmp * misc/cronjobs/printoverdues.sh /tmp * if your title/author is long enough, it's splitted on 2 lines with this patch (it is not before this patch) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24395&action=edit pdf generated without the patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24396&action=edit pdf generated with the patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #21 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #22 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #23 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.12.x will be in 3.12.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org