[Bug 5681] New: Autobarcode using C4::Barcode has issues with leading zeros and large values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 Summary: Autobarcode using C4::Barcode has issues with leading zeros and large values Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Estimated Hours: 0.0 This results in leading zeros being trimmed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5574 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-02 02:50:21 UTC --- Created attachment 3048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3048 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-02 03:40:00 UTC --- I have tested this patch, Before patch ok 32 - (incremental ) Barcode Creation : new(incremental) ok 33 - (incremental ) autoBarcode() : incremental ok 34 - (incremental ) initial() : 0000001 # . (incremental ) db_max() : 0000001 ok 35 - (incremental ) max() : 2 ok 36 - (incremental ) value() : 2 After patch ok 32 - (incremental ) Barcode Creation : new(incremental) ok 33 - (incremental ) autoBarcode() : incremental ok 34 - (incremental ) initial() : 0000001 # . (incremental ) db_max() : 0000001 ok 35 - (incremental ) max() : 0000002 ok 36 - (incremental ) value() : 0000002 I also checked the annual ones Before ok 2 - (annual ) Barcode Creation : new(annual) ok 3 - (annual ) autoBarcode() : annual ok 4 - (annual ) initial() : 2011-0001 # . (annual ) db_max() : 2011-18918291 ok 5 - (annual ) max() : 2011-18918292 ok 6 - (annual ) value() : 2011-18918292 after ok 2 - (annual ) Barcode Creation : new(annual) ok 3 - (annual ) autoBarcode() : annual ok 4 - (annual ) initial() : 2011-0001 # . (annual ) db_max() : 2011-18918291 ok 5 - (annual ) max() : 2011-18918292 ok 6 - (annual ) value() : 2011-18918292 So patch does what it says it does, and does fix the stripping of leading zeros Will sign off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3048|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-02 03:45:05 UTC --- Created attachment 3049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3049 Signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-02 21:13:46 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |paul.poulain@biblibre.com Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org