https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |black23@gmail.com, | |josef.moravec@gmail.com, | |magnus@libriotech.no, | |martin.renvoize@ptfs-europe | |.com, rbit@rbit.cz Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #1 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Function send_digests contains hard-coded value "advance_notice" in messge_name (line 552 of advance_notice.pl), but it should be passed-in as a parameter, because it's called for Advance_Notice as well as for Item_Due message attributes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96238|0 |1 is obsolete| | --- Comment #4 from Michal Denar <black23@gmail.com> --- Created attachment 96240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96240&action=edit Bug 24235: Do not use hardcoded message_name Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Are you sure about this patch? It sounds like a duplicate of bug 24072. I setup: https://snipboard.io/NfnZeG.jpg Then run advance_notices.pl Withtout this patch: MariaDB [koha_kohadev]> select * from message_queue\G *************************** 1. row *************************** message_id: 33 borrowernumber: 5 subject: Item Due Reminder content: You have 1 items due metadata: letter_code: DUEDGST message_transport_type: email status: pending time_queued: 2019-12-13 10:02:38 to_address: NULL from_address: root@localhost content_type: NULL *************************** 2. row *************************** message_id: 34 borrowernumber: 5 subject: duegst content: duedgst sms metadata: letter_code: DUEDGST message_transport_type: sms status: pending time_queued: 2019-12-13 10:02:38 to_address: NULL from_address: root@localhost content_type: NULL 2 rows in set (0.00 sec) With this patch: nothing is generated -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96240|0 |1 is obsolete| | --- Comment #7 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 96279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96279&action=edit Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off DUEDGST notice required PREDUEDGST to be on, but both messages have to be generated independently Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|josef.moravec@gmail.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96283|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96308&action=edit Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off DUEDGST notice required PREDUEDGST to be on, but both messages have to be generated independently Test plan: 0) Do not apply the patch and reproduce the bug - turn OFF sms PREDUEDGST and turn ON sms DUEDGST for a given borrower - Sms version of DUEDGST is never generated into the message queue. 1) Apply the patch 2) Ensure that the bug is fixed Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #14 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Hi, Backporting this to 18.11.x resulted in conflicts which I don't know how to resolve. Can somebody please rebase for 18.11.x? -- You are receiving this mail because: You are watching all bug changes.