[Bug 30972] New: "Replace existing covers" checkbox in upload-cover-image.pl now replaces ALL covers for a biblio, not only the specific item's covers.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Bug ID: 30972 Summary: "Replace existing covers" checkbox in upload-cover-image.pl now replaces ALL covers for a biblio, not only the specific item's covers. Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: egpetridis@yahoo.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl It seems that the "Replace existing covers" checkbox in /cgi-bin/koha/tools/upload-cover-image.pl?itemnumber=2385&filetype=image# now replaces ALL covers for a biblio, not only the specific item's cover(s). This is a departure from how koha worked in the past, is undocumented and could become a major problem for libraries keeping Continuing Resources local cover images, discarding years' work in an instance. When one uploads a cover for a specific issue, replace should work for only the cover(s) linked to that specific issue. The problem may also be related to issue cover images now appearing as alternate cover images for the biblio. In the past if one wanted the biblio to have a cover image attached, one had to upload an image to the biblio itself. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Manos PETRIDIS <egpetridis@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Tools -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC| |jonathan.druart+koha@gmail. | |com Version|22.05 |unspecified Depends on| |30234 Status|NEW |ASSIGNED --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Are talking about cover images you attached to an *item* (vs bibliographic record)? This feature has been added by bug 26145 and is not in Koha "for years" ;) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 [Bug 30234] Serial local covers do not appear in the administrative interface, unless their home library is the same as the one selected by the user upon entry. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136145&action=edit Bug 30972: Don't replace biblio's local cover images when uploading an image's image When attaching a new cover image to an item we should not replace cover images attached to the bibliographic record if "Replace existing covers" is ticked. Test plan: Attach 1+ image to a bibliographic record Attach 1 image to an item of this biblio Attach another image to the item and seect "replace existing covers" => Without this patch the images attached to the biblio are removed => With this patch applied only the images attached to the image are removed Same if you tick the checkbox when attaching an image to the biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30976 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136145|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 136160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136160&action=edit Bug 30972: Don't replace biblio's local cover images when uploading an image's image When attaching a new cover image to an item we should not replace cover images attached to the bibliographic record if "Replace existing covers" is ticked. Test plan: Attach 1+ image to a bibliographic record Attach 1 image to an item of this biblio Attach another image to the item and seect "replace existing covers" => Without this patch the images attached to the biblio are removed => With this patch applied only the images attached to the image are removed Same if you tick the checkbox when attaching an image to the biblio Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 --- Comment #4 from Manos PETRIDIS <egpetridis@yahoo.com> --- (In reply to Jonathan Druart from comment #1)
Are talking about cover images you attached to an *item* (vs bibliographic record)? This feature has been added by bug 26145 and is not in Koha "for years" ;)
Well, if left unresolved, it could very well ruin many a years' work in the future ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136160|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136322&action=edit Bug 30972: Don't replace biblio's local cover images when uploading an image's image When attaching a new cover image to an item we should not replace cover images attached to the bibliographic record if "Replace existing covers" is ticked. Test plan: Attach 1+ image to a bibliographic record Attach 1 image to an item of this biblio Attach another image to the item and seect "replace existing covers" => Without this patch the images attached to the biblio are removed => With this patch applied only the images attached to the image are removed Same if you tick the checkbox when attaching an image to the biblio Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Replace existing covers" |"Replace existing covers" |checkbox in |checkbox replaces ALL local |upload-cover-image.pl now |covers for a biblio, not |replaces ALL covers for a |only the specific item's |biblio, not only the |covers |specific item's covers. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |arthur.suzuki@biblibre.com --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- I don't reproduce the issue on 21.11.x. not backporting :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Bug 30972 depends on bug 30234, which changed state. Bug 30234 Summary: Serial local covers don't appear in the staff interface for other libraries with SeparateHoldings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972 Manos PETRIDIS <egpetridis@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis@yahoo.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org