[Bug 34345] New: 'Circulation and fine rules' vs 'Circulation and fines rules'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 Bug ID: 34345 Summary: 'Circulation and fine rules' vs 'Circulation and fines rules' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org In some places, 'fines' is plural and in other places, it is singular. There might be a reason a native English speaker could explain. Plural "Circulation and fines rules" - Administration page - Administration menu bar on the left Singular "Circulation and fine rules" - Circulation and fine rules page title tag - Circulation and fine rules page breadcrumbs - Circulation and fine rules page header ("Defining circulation and fine rules") - Everywhere else on that page... Singular seems to be used more, should we change the administration page and administration menu? Feel free to close if this is normal and I'm making a mountain out of a molehill :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153836&action=edit Bug 34345: 'Circulation and fine rules' vs 'Circulation and fines rules' This patch corrects two instances of the phrase "Circulation and fines rules" in favor of the more common "Circulation and fine rules" for consistency's sake. To test, apply the patch and go to Administration. - In the description under the "Circulation and fine rules" link it should read, "Define circulation and fine rules..." - Open the Circulation and fine rules page and confirm that the link in the sidebar menu is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153836|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 153933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153933&action=edit Bug 34345: 'Circulation and fine rules' vs 'Circulation and fines rules' This patch corrects two instances of the phrase "Circulation and fines rules" in favor of the more common "Circulation and fine rules" for consistency's sake. To test, apply the patch and go to Administration. - In the description under the "Circulation and fine rules" link it should read, "Define circulation and fine rules..." - Open the Circulation and fine rules page and confirm that the link in the sidebar menu is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153933|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154112&action=edit Bug 34345: 'Circulation and fine rules' vs 'Circulation and fines rules' This patch corrects two instances of the phrase "Circulation and fines rules" in favor of the more common "Circulation and fine rules" for consistency's sake. To test, apply the patch and go to Administration. - In the description under the "Circulation and fine rules" link it should read, "Define circulation and fine rules..." - Open the Circulation and fine rules page and confirm that the link in the sidebar menu is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154113&action=edit Bug 34345: (QA follow-up) Fix some more occurrences Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.04 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org