[Bug 40134] New: Fix and optimise 'Any item' functionality of bookings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Bug ID: 40134 Summary: Fix and optimise 'Any item' functionality of bookings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 29002 The 'Any item' option in the bookings modal is currently not correctly calculating maximum available booking window correctly and we have older code left behind that attempted to allow any item at a biblio level without taking into account item type limitations. This bug acts to correct that by implementing an optimized algorithm for picking the item at booking time to try and maximize the pool of available items for future bookings. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29002 |39916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 [Bug 39916] The 'Place booking' modal should have cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |Bookings function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183211&action=edit Bug 40134: Implement dynamic item assignment with smart window maximization This patch implements smart window maximization for "any item of itemtype X" bookings using dynamic item pool reduction. The core principle is "never re-add items to pool" - once an item is removed from the available pool because it becomes unavailable, it's never re-added even if it becomes available again later. This ensures optimal resource allocation and maximum booking windows. Key features: - Dynamic item pool reduction algorithm in isDateInMaximumWindow() - Smart itemtype availability calculation in isDateDisabledForItemtype() - Optimal item selection for booking submission in selectOptimalItem() - Future availability calculation to choose best items - Comprehensive JSDoc documentation with detailed examples The algorithm works by: 1. Starting with items available on the selected start date 2. Walking through each day from start to target end date 3. Removing items from pool when they become unavailable 4. Never re-adding items even if they become available again later 5. Disabling dates when no items remain in pool This maximizes booking windows while preventing conflicts by being conservative about item availability. Test plan: 1. Apply patch and restart services 2. Navigate to a biblio detail page with bookable items of multiple types 3. Click "Place booking" and select a patron and pickup location 4. Select an itemtype (not a specific item) to enable "any item" mode 5. Select a start date - verify end date options are maximized based on available items across the booking period 6. Test with complex booking scenarios where items have overlapping bookings 7. Verify that the algorithm correctly reduces the item pool as items become unavailable and extends booking windows as far as possible 8. Confirm that items which become available again later in the period are not re-added to the pool (key algorithm principle) 9. Submit booking and verify optimal item is selected automatically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183211|0 |1 is obsolete| | --- Comment #2 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 186371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186371&action=edit Bug 40134: Implement dynamic item assignment with smart window maximization This patch implements smart window maximization for "any item of itemtype X" bookings using dynamic item pool reduction. The core principle is "never re-add items to pool" - once an item is removed from the available pool because it becomes unavailable, it's never re-added even if it becomes available again later. This ensures optimal resource allocation and maximum booking windows. Key features: - Dynamic item pool reduction algorithm in isDateInMaximumWindow() - Smart itemtype availability calculation in isDateDisabledForItemtype() - Optimal item selection for booking submission in selectOptimalItem() - Future availability calculation to choose best items - Comprehensive JSDoc documentation with detailed examples The algorithm works by: 1. Starting with items available on the selected start date 2. Walking through each day from start to target end date 3. Removing items from pool when they become unavailable 4. Never re-adding items even if they become available again later 5. Disabling dates when no items remain in pool This maximizes booking windows while preventing conflicts by being conservative about item availability. Test plan: 1. Apply patch and restart services 2. Navigate to a biblio detail page with bookable items of multiple types 3. Click "Place booking" and select a patron and pickup location 4. Select an itemtype (not a specific item) to enable "any item" mode 5. Select a start date - verify end date options are maximized based on available items across the booking period 6. Test with complex booking scenarios where items have overlapping bookings 7. Verify that the algorithm correctly reduces the item pool as items become unavailable and extends booking windows as far as possible 8. Confirm that items which become available again later in the period are not re-added to the pool (key algorithm principle) 9. Submit booking and verify optimal item is selected automatically Signed-off-by: Thibaud Guillot <thibaud.guillot@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39584 [Bug 39584] Booking post-processing time cuts into circulation period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|BLOCKED |Needs Signoff QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190800&action=edit Bug 40134: Implement optimal item selection for 'any item' bookings This patch implements an algorithm for selecting the item that would leave the largest gap after the proposed booking to maximize the opportunity for future bookings. Key Changes: Koha::Booking: - Added set_itemtype_filter() method for transient itemtype parameter - Added _select_optimal_item() method using single aggregated query * Groups bookings by item_id with MIN(start_date) * Selects items with no future bookings (optimal) * Among items with bookings, selects one with latest next booking * O(1) complexity - single database query with GROUP BY - Updated _assign_item_for_booking() to use optimal selection * Filters by itemtype when itemtype_id is provided * Replaces previous random selection (RAND()) API Changes: - Added itemtype_id parameter support to add() endpoint - Added itemtype_id parameter support to update() endpoint - Validates exactly one of item_id or itemtype_id is provided - itemtype_id is transient - not persisted to database - Extracted and applied via set_itemtype_filter() before store() Architecture: - itemtype_id is NOT a database column (transient only) - Used as selection criterion, then discarded Test plan: 1. Apply patch and restart services 2. Create "any item" booking via staff interface 3. Verify item with longest future availability is selected 4. Test via API with itemtype_id parameter 5. Verify itemtype_id is not persisted to database 6. Run t/db_dependent/Koha/Booking.t 7. Run t/db_dependent/api/v1/bookings.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190801&action=edit Bug 40134: Add unit tests for optimal item selection This patch adds unit tests for the server-side optimal item selection functionality. t/db_dependent/Koha/Booking.t: - Added subtest for _select_optimal_item() method (7 tests) * Tests with no items (returns undef) * Tests with single item (returns that item) * Tests with multiple items (selects item with longest future availability) * Tests optimal selection across items with different booking patterns * Tests handling of cancelled bookings (ignored in selection) * Tests iterator reset after selection - Added subtest for _assign_item_for_booking() with itemtype filtering (6 tests) * Tests booking without item_id or itemtype_id (selects any available) * Tests booking with itemtype_id (filters by type) * Tests optimal selection within filtered itemtype * Tests exception when no items of specified type available - Added integration test for full optimal selection workflow (5 tests) * Creates 3 items with different future booking patterns * Verifies items selected in optimal order (B→C→A) * Demonstrates preservation of constrained resources * Validates complete algorithm chain * Tests booking failure when all items exhausted t/db_dependent/api/v1/bookings.t: - Added subtest for itemtype_id parameter validation (16 tests) * Tests successful booking creation with itemtype_id * Tests that item is automatically assigned * Tests validation: cannot specify both item_id and itemtype_id * Tests validation: must specify either item_id or itemtype_id * Tests clash detection with itemtype-based bookings - Fixed duplicate booking_id test to use different dates * Prevents clash detection from masking duplicate ID constraint - Updated test count from 3 to 8 subtests in Booking.t - Updated test count to match actual assertions (16 not 18) Test Coverage: - Internal method testing: _select_optimal_item() - Integration testing: _assign_item_for_booking() - API endpoint testing: add() with itemtype_id - End-to-end workflow validation - Edge cases: empty sets, single items, ties, cancelled bookings Test plan: 1. prove t/db_dependent/Koha/Booking.t 2. prove t/db_dependent/api/v1/bookings.t 3. Verify all tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190802&action=edit Bug 40134: Implement client-side improvements for bookings This patch implements client-side improvements for the bookings modal, including smart window maximization and hybrid submission logic that delegates optimal item selection to the server. Smart Window Maximization: - Implements "never re-add items to pool" algorithm - Dynamic item pool reduction based on availability - isDateDisabledForItemtype() calculates available dates - isDateInMaximumWindow() validates end dates against item pool - Provides real-time calendar feedback to users Hybrid Submission Logic: For "any item" bookings, the client now uses a smart hybrid approach: 1. Filters items by selected itemtype 2. Checks availability for the booking period 3. If 0 items available: Shows error (no suitable item) 4. If 1 item available: Sends item_id (optimization - skips server) 5. If 2+ items available: Sends itemtype_id (delegates to server) This minimizes server round-trips while delegating complex optimal selection logic to the server when multiple choices exist. Test plan: 1. Navigate to biblio detail page with bookable items 2. Click "Place booking" and select patron/pickup location 3. Select itemtype (not specific item) - "any item" mode 4. Select start date - verify end dates are maximized 5. Verify calendar disables dates when no items available 6. Submit booking - verify it succeeds 7. Check that optimal item was selected (server-side) 8. Test edit mode with "any item" selection 9. Verify both create and edit use same logic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190803&action=edit Bug 40134: Add Cypress tests for booking improvements This patch adds end-to-end Cypress tests for the booking modal improvements, including smart window maximization and server-side optimal item selection. New Tests: 1. "should successfully submit an 'Any item' booking with server-side optimal item selection" - Tests the complete "any item" booking workflow - Selects itemtype and "Any item" option (item_id = 0) - Submits booking form - Verifies modal closes without errors - Validates booking created in database - Confirms item was assigned by server - Verifies server-side optimal selection completed - Test status: PASSING 2. "should maximize booking window by dynamically reducing available items during overlaps" - Creates 4 items with strategic booking patterns - Tests "never re-add items to pool" algorithm - Validates 5 scenarios: a) Full window when all items available b) Reduced window when Item 1 becomes unavailable c) Further reduction when Items 1&2 unavailable d) Minimal window with Items 1,2,3 unavailable e) No availability when all items booked - Demonstrates smart window maximization - Test status: PASSING 3. "should handle edit mode date initialization correctly" - Tests fix for edit mode race condition - Verifies dates populate correctly when editing booking - Ensures itemtype is set before date initialization - Tests that flatpickr dates are set properly - Test status: PASSING Updated Tests: - "should successfully submit a booking" * Updated to use day+5 start date (accounts for 3-day lead period) * Ensures test doesn't fail on past-date constraint - Updated test comments and log messages to reflect server-side selection * Changed from "client-side selectOptimalItem()" references * Updated to "server-side optimal item selection" * Clarified that server performs the optimal selection Test Coverage: - End-to-end "any item" booking submission - Smart window maximization algorithm - Edit mode date initialization - Server-side optimal selection validation - Database verification of assigned items - Modal interaction and form submission Test plan: 1. Start KTD environment 2. Ensure Cypress is installed: yarn install 3. Run: npx cypress run --spec "t/cypress/integration/Circulation/bookingsModalBasic_spec.ts" 4. Verify all 11 tests pass 5. Optionally run in interactive mode: npx cypress open -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186371|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|39584 | Depends on| |39584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39584 [Bug 39584] Booking post-processing time cuts into circulation period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|39584 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39584 [Bug 39584] Booking post-processing time cuts into circulation period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37707 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37707 [Bug 37707] Lead/Trail times should work in combination -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|39916 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 [Bug 39916] The 'Place booking' modal should have cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190800|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190801|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190863&action=edit Bug 40134: Implement optimal item selection for 'any item' bookings This patch implements an algorithm for selecting the item that would leave the largest gap after the proposed booking to maximize the opportunity for future bookings. Key Changes: Koha::Booking: - Added set_itemtype_filter() method for transient itemtype parameter - Added _select_optimal_item() method using single aggregated query * Groups bookings by item_id with MIN(start_date) * Selects items with no future bookings (optimal) * Among items with bookings, selects one with latest next booking * O(1) complexity - single database query with GROUP BY - Updated _assign_item_for_booking() to use optimal selection * Filters by itemtype when itemtype_id is provided * Replaces previous random selection (RAND()) API Changes: - Added itemtype_id parameter support to add() endpoint - Added itemtype_id parameter support to update() endpoint - Validates exactly one of item_id or itemtype_id is provided - itemtype_id is transient - not persisted to database - Extracted and applied via set_itemtype_filter() before store() Architecture: - itemtype_id is NOT a database column (transient only) - Used as selection criterion, then discarded Test plan: 1. Apply patch and restart services 2. Create "any item" booking via staff interface 3. Verify item with longest future availability is selected 4. Test via API with itemtype_id parameter 5. Verify itemtype_id is not persisted to database 6. Run t/db_dependent/Koha/Booking.t 7. Run t/db_dependent/api/v1/bookings.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190864&action=edit Bug 40134: Add unit tests for optimal item selection This patch adds unit tests for the server-side optimal item selection functionality. t/db_dependent/Koha/Booking.t: - Added subtest for _select_optimal_item() method (7 tests) * Tests with no items (returns undef) * Tests with single item (returns that item) * Tests with multiple items (selects item with longest future availability) * Tests optimal selection across items with different booking patterns * Tests handling of cancelled bookings (ignored in selection) * Tests iterator reset after selection - Added subtest for _assign_item_for_booking() with itemtype filtering (6 tests) * Tests booking without item_id or itemtype_id (selects any available) * Tests booking with itemtype_id (filters by type) * Tests optimal selection within filtered itemtype * Tests exception when no items of specified type available - Added integration test for full optimal selection workflow (5 tests) * Creates 3 items with different future booking patterns * Verifies items selected in optimal order (B→C→A) * Demonstrates preservation of constrained resources * Validates complete algorithm chain * Tests booking failure when all items exhausted t/db_dependent/api/v1/bookings.t: - Added subtest for itemtype_id parameter validation (16 tests) * Tests successful booking creation with itemtype_id * Tests that item is automatically assigned * Tests validation: cannot specify both item_id and itemtype_id * Tests validation: must specify either item_id or itemtype_id * Tests clash detection with itemtype-based bookings - Fixed duplicate booking_id test to use different dates * Prevents clash detection from masking duplicate ID constraint - Updated test count from 3 to 8 subtests in Booking.t - Updated test count to match actual assertions (16 not 18) Test Coverage: - Internal method testing: _select_optimal_item() - Integration testing: _assign_item_for_booking() - API endpoint testing: add() with itemtype_id - End-to-end workflow validation - Edge cases: empty sets, single items, ties, cancelled bookings Test plan: 1. prove t/db_dependent/Koha/Booking.t 2. prove t/db_dependent/api/v1/bookings.t 3. Verify all tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190865&action=edit Bug 40134: Implement client-side improvements for bookings This patch implements client-side improvements for the bookings modal, including smart window maximization and hybrid submission logic that delegates optimal item selection to the server. Smart Window Maximization: - Implements "never re-add items to pool" algorithm - Dynamic item pool reduction based on availability - isDateDisabledForItemtype() calculates available dates - isDateInMaximumWindow() validates end dates against item pool - Provides real-time calendar feedback to users Hybrid Submission Logic: For "any item" bookings, the client now uses a smart hybrid approach: 1. Filters items by selected itemtype 2. Checks availability for the booking period 3. If 0 items available: Shows error (no suitable item) 4. If 1 item available: Sends item_id (optimization - skips server) 5. If 2+ items available: Sends itemtype_id (delegates to server) This minimizes server round-trips while delegating complex optimal selection logic to the server when multiple choices exist. Test plan: 1. Navigate to biblio detail page with bookable items 2. Click "Place booking" and select patron/pickup location 3. Select itemtype (not specific item) - "any item" mode 4. Select start date - verify end dates are maximized 5. Verify calendar disables dates when no items available 6. Submit booking - verify it succeeds 7. Check that optimal item was selected (server-side) 8. Test edit mode with "any item" selection 9. Verify both create and edit use same logic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190866&action=edit Bug 40134: Add Cypress tests for booking improvements This patch adds end-to-end Cypress tests for the booking modal improvements, including smart window maximization and server-side optimal item selection. New Tests: 1. "should successfully submit an 'Any item' booking with server-side optimal item selection" - Tests the complete "any item" booking workflow - Selects itemtype and "Any item" option (item_id = 0) - Submits booking form - Verifies modal closes without errors - Validates booking created in database - Confirms item was assigned by server - Verifies server-side optimal selection completed - Test status: PASSING 2. "should maximize booking window by dynamically reducing available items during overlaps" - Creates 4 items with strategic booking patterns - Tests "never re-add items to pool" algorithm - Validates 5 scenarios: a) Full window when all items available b) Reduced window when Item 1 becomes unavailable c) Further reduction when Items 1&2 unavailable d) Minimal window with Items 1,2,3 unavailable e) No availability when all items booked - Demonstrates smart window maximization - Test status: PASSING 3. "should handle edit mode date initialization correctly" - Tests fix for edit mode race condition - Verifies dates populate correctly when editing booking - Ensures itemtype is set before date initialization - Tests that flatpickr dates are set properly - Test status: PASSING Updated Tests: - "should successfully submit a booking" * Updated to use day+5 start date (accounts for 3-day lead period) * Ensures test doesn't fail on past-date constraint - Updated test comments and log messages to reflect server-side selection * Changed from "client-side selectOptimalItem()" references * Updated to "server-side optimal item selection" * Clarified that server performs the optimal selection Test Coverage: - End-to-end "any item" booking submission - Smart window maximization algorithm - Edit mode date initialization - Server-side optimal selection validation - Database verification of assigned items - Modal interaction and form submission Test plan: 1. Start KTD environment 2. Ensure Cypress is installed: yarn install 3. Run: npx cypress run --spec "t/cypress/integration/Circulation/bookingsModalBasic_spec.ts" 4. Verify all 11 tests pass 5. Optionally run in interactive mode: npx cypress open -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41129 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41129 [Bug 41129] Migrate place_booking.js to a Vue island. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190863|0 |1 is obsolete| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190962&action=edit Bug 40134: Implement optimal item selection for 'any item' bookings This patch implements an algorithm for selecting the item that would leave the largest gap after the proposed booking to maximize the opportunity for future bookings. Key Changes: Koha::Booking: - Added set_itemtype_filter() method for transient itemtype parameter - Added _select_optimal_item() method using single aggregated query * Groups bookings by item_id with MIN(start_date) * Selects items with no future bookings (optimal) * Among items with bookings, selects one with latest next booking * O(1) complexity - single database query with GROUP BY - Updated _assign_item_for_booking() to use optimal selection * Filters by itemtype when itemtype_id is provided * Replaces previous random selection (RAND()) API Changes: - Added itemtype_id parameter support to add() endpoint - Added itemtype_id parameter support to update() endpoint - Validates exactly one of item_id or itemtype_id is provided - itemtype_id is transient - not persisted to database - Extracted and applied via set_itemtype_filter() before store() Architecture: - itemtype_id is NOT a database column (transient only) - Used as selection criterion, then discarded Test plan: 1. Apply patch and restart services 2. Create "any item" booking via staff interface 3. Verify item with longest future availability is selected 4. Test via API with itemtype_id parameter 5. Verify itemtype_id is not persisted to database 6. Run t/db_dependent/Koha/Booking.t 7. Run t/db_dependent/api/v1/bookings.t Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190864|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190963&action=edit Bug 40134: Add unit tests for optimal item selection This patch adds unit tests for the server-side optimal item selection functionality. t/db_dependent/Koha/Booking.t: - Added subtest for _select_optimal_item() method (7 tests) * Tests with no items (returns undef) * Tests with single item (returns that item) * Tests with multiple items (selects item with longest future availability) * Tests optimal selection across items with different booking patterns * Tests handling of cancelled bookings (ignored in selection) * Tests iterator reset after selection - Added subtest for _assign_item_for_booking() with itemtype filtering (6 tests) * Tests booking without item_id or itemtype_id (selects any available) * Tests booking with itemtype_id (filters by type) * Tests optimal selection within filtered itemtype * Tests exception when no items of specified type available - Added integration test for full optimal selection workflow (5 tests) * Creates 3 items with different future booking patterns * Verifies items selected in optimal order (B→C→A) * Demonstrates preservation of constrained resources * Validates complete algorithm chain * Tests booking failure when all items exhausted t/db_dependent/api/v1/bookings.t: - Added subtest for itemtype_id parameter validation (16 tests) * Tests successful booking creation with itemtype_id * Tests that item is automatically assigned * Tests validation: cannot specify both item_id and itemtype_id * Tests validation: must specify either item_id or itemtype_id * Tests clash detection with itemtype-based bookings - Fixed duplicate booking_id test to use different dates * Prevents clash detection from masking duplicate ID constraint - Updated test count from 3 to 8 subtests in Booking.t - Updated test count to match actual assertions (16 not 18) Test Coverage: - Internal method testing: _select_optimal_item() - Integration testing: _assign_item_for_booking() - API endpoint testing: add() with itemtype_id - End-to-end workflow validation - Edge cases: empty sets, single items, ties, cancelled bookings Test plan: 1. prove t/db_dependent/Koha/Booking.t 2. prove t/db_dependent/api/v1/bookings.t 3. Verify all tests pass Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190865|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190964&action=edit Bug 40134: Implement client-side improvements for bookings This patch implements client-side improvements for the bookings modal, including smart window maximization and hybrid submission logic that delegates optimal item selection to the server. Smart Window Maximization: - Implements "never re-add items to pool" algorithm - Dynamic item pool reduction based on availability - isDateDisabledForItemtype() calculates available dates - isDateInMaximumWindow() validates end dates against item pool - Provides real-time calendar feedback to users Hybrid Submission Logic: For "any item" bookings, the client now uses a smart hybrid approach: 1. Filters items by selected itemtype 2. Checks availability for the booking period 3. If 0 items available: Shows error (no suitable item) 4. If 1 item available: Sends item_id (optimization - skips server) 5. If 2+ items available: Sends itemtype_id (delegates to server) This minimizes server round-trips while delegating complex optimal selection logic to the server when multiple choices exist. Test plan: 1. Navigate to biblio detail page with bookable items 2. Click "Place booking" and select patron/pickup location 3. Select itemtype (not specific item) - "any item" mode 4. Select start date - verify end dates are maximized 5. Verify calendar disables dates when no items available 6. Submit booking - verify it succeeds 7. Check that optimal item was selected (server-side) 8. Test edit mode with "any item" selection 9. Verify both create and edit use same logic Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190866|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190965&action=edit Bug 40134: Add Cypress tests for booking improvements This patch adds end-to-end Cypress tests for the booking modal improvements, including smart window maximization and server-side optimal item selection. New Tests: 1. "should successfully submit an 'Any item' booking with server-side optimal item selection" - Tests the complete "any item" booking workflow - Selects itemtype and "Any item" option (item_id = 0) - Submits booking form - Verifies modal closes without errors - Validates booking created in database - Confirms item was assigned by server - Verifies server-side optimal selection completed - Test status: PASSING 2. "should maximize booking window by dynamically reducing available items during overlaps" - Creates 4 items with strategic booking patterns - Tests "never re-add items to pool" algorithm - Validates 5 scenarios: a) Full window when all items available b) Reduced window when Item 1 becomes unavailable c) Further reduction when Items 1&2 unavailable d) Minimal window with Items 1,2,3 unavailable e) No availability when all items booked - Demonstrates smart window maximization - Test status: PASSING 3. "should handle edit mode date initialization correctly" - Tests fix for edit mode race condition - Verifies dates populate correctly when editing booking - Ensures itemtype is set before date initialization - Tests that flatpickr dates are set properly - Test status: PASSING Updated Tests: - "should successfully submit a booking" * Updated to use day+5 start date (accounts for 3-day lead period) * Ensures test doesn't fail on past-date constraint - Updated test comments and log messages to reflect server-side selection * Changed from "client-side selectOptimalItem()" references * Updated to "server-side optimal item selection" * Clarified that server performs the optimal selection Test Coverage: - End-to-end "any item" booking submission - Smart window maximization algorithm - Edit mode date initialization - Server-side optimal selection validation - Database verification of assigned items - Modal interaction and form submission Test plan: 1. Start KTD environment 2. Ensure Cypress is installed: yarn install 3. Run: npx cypress run --spec "t/cypress/integration/Circulation/bookingsModalBasic_spec.ts" 4. Verify all 11 tests pass 5. Optionally run in interactive mode: npx cypress open Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190962|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190963|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190964|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190965|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191004&action=edit Bug 40134: Implement optimal item selection for 'any item' bookings This patch implements an algorithm for selecting the item that would leave the largest gap after the proposed booking to maximize the opportunity for future bookings. Key Changes: Koha::Booking: - Added set_itemtype_filter() method for transient itemtype parameter - Added _select_optimal_item() method using single aggregated query * Groups bookings by item_id with MIN(start_date) * Selects items with no future bookings (optimal) * Among items with bookings, selects one with latest next booking * O(1) complexity - single database query with GROUP BY - Updated _assign_item_for_booking() to use optimal selection * Filters by itemtype when itemtype_id is provided * Replaces previous random selection (RAND()) API Changes: - Added itemtype_id parameter support to add() endpoint - Added itemtype_id parameter support to update() endpoint - Validates exactly one of item_id or itemtype_id is provided - itemtype_id is transient - not persisted to database - Extracted and applied via set_itemtype_filter() before store() Architecture: - itemtype_id is NOT a database column (transient only) - Used as selection criterion, then discarded Test plan: 1. Apply patch and restart services 2. Create "any item" booking via staff interface 3. Verify item with longest future availability is selected 4. Test via API with itemtype_id parameter 5. Verify itemtype_id is not persisted to database 6. Run t/db_dependent/Koha/Booking.t 7. Run t/db_dependent/api/v1/bookings.t Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191005&action=edit Bug 40134: Add unit tests for optimal item selection This patch adds unit tests for the server-side optimal item selection functionality. t/db_dependent/Koha/Booking.t: - Added subtest for _select_optimal_item() method (7 tests) * Tests with no items (returns undef) * Tests with single item (returns that item) * Tests with multiple items (selects item with longest future availability) * Tests optimal selection across items with different booking patterns * Tests handling of cancelled bookings (ignored in selection) * Tests iterator reset after selection - Added subtest for _assign_item_for_booking() with itemtype filtering (6 tests) * Tests booking without item_id or itemtype_id (selects any available) * Tests booking with itemtype_id (filters by type) * Tests optimal selection within filtered itemtype * Tests exception when no items of specified type available - Added integration test for full optimal selection workflow (5 tests) * Creates 3 items with different future booking patterns * Verifies items selected in optimal order (B→C→A) * Demonstrates preservation of constrained resources * Validates complete algorithm chain * Tests booking failure when all items exhausted t/db_dependent/api/v1/bookings.t: - Added subtest for itemtype_id parameter validation (16 tests) * Tests successful booking creation with itemtype_id * Tests that item is automatically assigned * Tests validation: cannot specify both item_id and itemtype_id * Tests validation: must specify either item_id or itemtype_id * Tests clash detection with itemtype-based bookings - Fixed duplicate booking_id test to use different dates * Prevents clash detection from masking duplicate ID constraint - Updated test count from 3 to 8 subtests in Booking.t - Updated test count to match actual assertions (16 not 18) Test Coverage: - Internal method testing: _select_optimal_item() - Integration testing: _assign_item_for_booking() - API endpoint testing: add() with itemtype_id - End-to-end workflow validation - Edge cases: empty sets, single items, ties, cancelled bookings Test plan: 1. prove t/db_dependent/Koha/Booking.t 2. prove t/db_dependent/api/v1/bookings.t 3. Verify all tests pass Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191006&action=edit Bug 40134: Implement client-side improvements for bookings This patch implements client-side improvements for the bookings modal, including smart window maximization and hybrid submission logic that delegates optimal item selection to the server. Smart Window Maximization: - Implements "never re-add items to pool" algorithm - Dynamic item pool reduction based on availability - isDateDisabledForItemtype() calculates available dates - isDateInMaximumWindow() validates end dates against item pool - Provides real-time calendar feedback to users Hybrid Submission Logic: For "any item" bookings, the client now uses a smart hybrid approach: 1. Filters items by selected itemtype 2. Checks availability for the booking period 3. If 0 items available: Shows error (no suitable item) 4. If 1 item available: Sends item_id (optimization - skips server) 5. If 2+ items available: Sends itemtype_id (delegates to server) This minimizes server round-trips while delegating complex optimal selection logic to the server when multiple choices exist. Test plan: 1. Navigate to biblio detail page with bookable items 2. Click "Place booking" and select patron/pickup location 3. Select itemtype (not specific item) - "any item" mode 4. Select start date - verify end dates are maximized 5. Verify calendar disables dates when no items available 6. Submit booking - verify it succeeds 7. Check that optimal item was selected (server-side) 8. Test edit mode with "any item" selection 9. Verify both create and edit use same logic Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191007&action=edit Bug 40134: Add Cypress tests for booking improvements This patch adds end-to-end Cypress tests for the booking modal improvements, including smart window maximization and server-side optimal item selection. New Tests: 1. "should successfully submit an 'Any item' booking with server-side optimal item selection" - Tests the complete "any item" booking workflow - Selects itemtype and "Any item" option (item_id = 0) - Submits booking form - Verifies modal closes without errors - Validates booking created in database - Confirms item was assigned by server - Verifies server-side optimal selection completed - Test status: PASSING 2. "should maximize booking window by dynamically reducing available items during overlaps" - Creates 4 items with strategic booking patterns - Tests "never re-add items to pool" algorithm - Validates 5 scenarios: a) Full window when all items available b) Reduced window when Item 1 becomes unavailable c) Further reduction when Items 1&2 unavailable d) Minimal window with Items 1,2,3 unavailable e) No availability when all items booked - Demonstrates smart window maximization - Test status: PASSING 3. "should handle edit mode date initialization correctly" - Tests fix for edit mode race condition - Verifies dates populate correctly when editing booking - Ensures itemtype is set before date initialization - Tests that flatpickr dates are set properly - Test status: PASSING Updated Tests: - "should successfully submit a booking" * Updated to use day+5 start date (accounts for 3-day lead period) * Ensures test doesn't fail on past-date constraint - Updated test comments and log messages to reflect server-side selection * Changed from "client-side selectOptimalItem()" references * Updated to "server-side optimal item selection" * Clarified that server performs the optimal selection Test Coverage: - End-to-end "any item" booking submission - Smart window maximization algorithm - Edit mode date initialization - Server-side optimal selection validation - Database verification of assigned items - Modal interaction and form submission Test plan: 1. Start KTD environment 2. Ensure Cypress is installed: yarn install 3. Run: npx cypress run --spec "t/cypress/integration/Circulation/bookingsModalBasic_spec.ts" 4. Verify all 11 tests pass 5. Optionally run in interactive mode: npx cypress open Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|37707 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37707 [Bug 37707] Lead/Trail times should work in combination -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39584 [Bug 39584] Booking post-processing time cuts into circulation period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37707 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37707 [Bug 37707] Lead/Trail times should work in combination -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41129 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41129 [Bug 41129] Migrate place_booking.js to a Vue island. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191006|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191007|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191954&action=edit Bug 40134: Implement optimal item selection for 'any item' bookings This patch implements an algorithm for selecting the item that would leave the largest gap after the proposed booking to maximize the opportunity for future bookings. Key Changes: Koha::Booking: - Added set_itemtype_filter() method for transient itemtype parameter - Added _select_optimal_item() method using single aggregated query * Groups bookings by item_id with MIN(start_date) * Selects items with no future bookings (optimal) * Among items with bookings, selects one with latest next booking * O(1) complexity - single database query with GROUP BY - Updated _assign_item_for_booking() to use optimal selection * Filters by itemtype when itemtype_id is provided * Replaces previous random selection (RAND()) API Changes: - Added itemtype_id parameter support to add() endpoint - Added itemtype_id parameter support to update() endpoint - Validates exactly one of item_id or itemtype_id is provided - itemtype_id is transient - not persisted to database - Extracted and applied via set_itemtype_filter() before store() Architecture: - itemtype_id is NOT a database column (transient only) - Used as selection criterion, then discarded Test plan: 1. Apply patch and restart services 2. Create "any item" booking via staff interface 3. Verify item with longest future availability is selected 4. Test via API with itemtype_id parameter 5. Verify itemtype_id is not persisted to database 6. Run t/db_dependent/Koha/Booking.t 7. Run t/db_dependent/api/v1/bookings.t Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191955&action=edit Bug 40134: Add unit tests for optimal item selection This patch adds unit tests for the server-side optimal item selection functionality. t/db_dependent/Koha/Booking.t: - Added subtest for _select_optimal_item() method (7 tests) * Tests with no items (returns undef) * Tests with single item (returns that item) * Tests with multiple items (selects item with longest future availability) * Tests optimal selection across items with different booking patterns * Tests handling of cancelled bookings (ignored in selection) * Tests iterator reset after selection - Added subtest for _assign_item_for_booking() with itemtype filtering (6 tests) * Tests booking without item_id or itemtype_id (selects any available) * Tests booking with itemtype_id (filters by type) * Tests optimal selection within filtered itemtype * Tests exception when no items of specified type available - Added integration test for full optimal selection workflow (5 tests) * Creates 3 items with different future booking patterns * Verifies items selected in optimal order (B→C→A) * Demonstrates preservation of constrained resources * Validates complete algorithm chain * Tests booking failure when all items exhausted t/db_dependent/api/v1/bookings.t: - Added subtest for itemtype_id parameter validation (16 tests) * Tests successful booking creation with itemtype_id * Tests that item is automatically assigned * Tests validation: cannot specify both item_id and itemtype_id * Tests validation: must specify either item_id or itemtype_id * Tests clash detection with itemtype-based bookings - Fixed duplicate booking_id test to use different dates * Prevents clash detection from masking duplicate ID constraint - Updated test count from 3 to 8 subtests in Booking.t - Updated test count to match actual assertions (16 not 18) Test Coverage: - Internal method testing: _select_optimal_item() - Integration testing: _assign_item_for_booking() - API endpoint testing: add() with itemtype_id - End-to-end workflow validation - Edge cases: empty sets, single items, ties, cancelled bookings Test plan: 1. prove t/db_dependent/Koha/Booking.t 2. prove t/db_dependent/api/v1/bookings.t 3. Verify all tests pass Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191956&action=edit Bug 40134: Implement client-side improvements for bookings This patch implements client-side improvements for the bookings modal, including smart window maximization and hybrid submission logic that delegates optimal item selection to the server. Smart Window Maximization: - Implements "never re-add items to pool" algorithm - Dynamic item pool reduction based on availability - isDateDisabledForItemtype() calculates available dates - isDateInMaximumWindow() validates end dates against item pool - Provides real-time calendar feedback to users Hybrid Submission Logic: For "any item" bookings, the client now uses a smart hybrid approach: 1. Filters items by selected itemtype 2. Checks availability for the booking period 3. If 0 items available: Shows error (no suitable item) 4. If 1 item available: Sends item_id (optimization - skips server) 5. If 2+ items available: Sends itemtype_id (delegates to server) This minimizes server round-trips while delegating complex optimal selection logic to the server when multiple choices exist. Test plan: 1. Navigate to biblio detail page with bookable items 2. Click "Place booking" and select patron/pickup location 3. Select itemtype (not specific item) - "any item" mode 4. Select start date - verify end dates are maximized 5. Verify calendar disables dates when no items available 6. Submit booking - verify it succeeds 7. Check that optimal item was selected (server-side) 8. Test edit mode with "any item" selection 9. Verify both create and edit use same logic Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 191957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191957&action=edit Bug 40134: Add Cypress tests for booking improvements This patch adds end-to-end Cypress tests for the booking modal improvements, including smart window maximization and server-side optimal item selection. New Tests: 1. "should successfully submit an 'Any item' booking with server-side optimal item selection" - Tests the complete "any item" booking workflow - Selects itemtype and "Any item" option (item_id = 0) - Submits booking form - Verifies modal closes without errors - Validates booking created in database - Confirms item was assigned by server - Verifies server-side optimal selection completed - Test status: PASSING 2. "should maximize booking window by dynamically reducing available items during overlaps" - Creates 4 items with strategic booking patterns - Tests "never re-add items to pool" algorithm - Validates 5 scenarios: a) Full window when all items available b) Reduced window when Item 1 becomes unavailable c) Further reduction when Items 1&2 unavailable d) Minimal window with Items 1,2,3 unavailable e) No availability when all items booked - Demonstrates smart window maximization - Test status: PASSING 3. "should handle edit mode date initialization correctly" - Tests fix for edit mode race condition - Verifies dates populate correctly when editing booking - Ensures itemtype is set before date initialization - Tests that flatpickr dates are set properly - Test status: PASSING Updated Tests: - "should successfully submit a booking" * Updated to use day+5 start date (accounts for 3-day lead period) * Ensures test doesn't fail on past-date constraint - Updated test comments and log messages to reflect server-side selection * Changed from "client-side selectOptimalItem()" references * Updated to "server-side optimal item selection" * Clarified that server performs the optimal selection Test Coverage: - End-to-end "any item" booking submission - Smart window maximization algorithm - Edit mode date initialization - Server-side optimal selection validation - Database verification of assigned items - Modal interaction and form submission Test plan: 1. Start KTD environment 2. Ensure Cypress is installed: yarn install 3. Run: npx cypress run --spec "t/cypress/integration/Circulation/bookingsModalBasic_spec.ts" 4. Verify all 11 tests pass 5. Optionally run in interactive mode: npx cypress open Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|nick@bywatersolutions.com |me@paulderscheid.xyz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191954|0 |1 is obsolete| | --- Comment #23 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192796&action=edit Bug 40134: Implement optimal item selection for 'any item' bookings This patch implements an algorithm for selecting the item that would leave the largest gap after the proposed booking to maximize the opportunity for future bookings. Key Changes: Koha::Booking: - Added set_itemtype_filter() method for transient itemtype parameter - Added _select_optimal_item() method using single aggregated query * Groups bookings by item_id with MIN(start_date) * Selects items with no future bookings (optimal) * Among items with bookings, selects one with latest next booking * O(1) complexity - single database query with GROUP BY - Updated _assign_item_for_booking() to use optimal selection * Filters by itemtype when itemtype_id is provided * Replaces previous random selection (RAND()) API Changes: - Added itemtype_id parameter support to add() endpoint - Added itemtype_id parameter support to update() endpoint - Validates exactly one of item_id or itemtype_id is provided - itemtype_id is transient - not persisted to database - Extracted and applied via set_itemtype_filter() before store() Architecture: - itemtype_id is NOT a database column (transient only) - Used as selection criterion, then discarded Test plan: 1. Apply patch and restart services 2. Create "any item" booking via staff interface 3. Verify item with longest future availability is selected 4. Test via API with itemtype_id parameter 5. Verify itemtype_id is not persisted to database 6. Run t/db_dependent/Koha/Booking.t 7. Run t/db_dependent/api/v1/bookings.t Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191955|0 |1 is obsolete| | --- Comment #24 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192797&action=edit Bug 40134: Add unit tests for optimal item selection This patch adds unit tests for the server-side optimal item selection functionality. t/db_dependent/Koha/Booking.t: - Added subtest for _select_optimal_item() method (7 tests) * Tests with no items (returns undef) * Tests with single item (returns that item) * Tests with multiple items (selects item with longest future availability) * Tests optimal selection across items with different booking patterns * Tests handling of cancelled bookings (ignored in selection) * Tests iterator reset after selection - Added subtest for _assign_item_for_booking() with itemtype filtering (6 tests) * Tests booking without item_id or itemtype_id (selects any available) * Tests booking with itemtype_id (filters by type) * Tests optimal selection within filtered itemtype * Tests exception when no items of specified type available - Added integration test for full optimal selection workflow (5 tests) * Creates 3 items with different future booking patterns * Verifies items selected in optimal order (B→C→A) * Demonstrates preservation of constrained resources * Validates complete algorithm chain * Tests booking failure when all items exhausted t/db_dependent/api/v1/bookings.t: - Added subtest for itemtype_id parameter validation (16 tests) * Tests successful booking creation with itemtype_id * Tests that item is automatically assigned * Tests validation: cannot specify both item_id and itemtype_id * Tests validation: must specify either item_id or itemtype_id * Tests clash detection with itemtype-based bookings - Fixed duplicate booking_id test to use different dates * Prevents clash detection from masking duplicate ID constraint - Updated test count from 3 to 8 subtests in Booking.t - Updated test count to match actual assertions (16 not 18) Test Coverage: - Internal method testing: _select_optimal_item() - Integration testing: _assign_item_for_booking() - API endpoint testing: add() with itemtype_id - End-to-end workflow validation - Edge cases: empty sets, single items, ties, cancelled bookings Test plan: 1. prove t/db_dependent/Koha/Booking.t 2. prove t/db_dependent/api/v1/bookings.t 3. Verify all tests pass Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191956|0 |1 is obsolete| | --- Comment #25 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192798&action=edit Bug 40134: Implement client-side improvements for bookings This patch implements client-side improvements for the bookings modal, including smart window maximization and hybrid submission logic that delegates optimal item selection to the server. Smart Window Maximization: - Implements "never re-add items to pool" algorithm - Dynamic item pool reduction based on availability - isDateDisabledForItemtype() calculates available dates - isDateInMaximumWindow() validates end dates against item pool - Provides real-time calendar feedback to users Hybrid Submission Logic: For "any item" bookings, the client now uses a smart hybrid approach: 1. Filters items by selected itemtype 2. Checks availability for the booking period 3. If 0 items available: Shows error (no suitable item) 4. If 1 item available: Sends item_id (optimization - skips server) 5. If 2+ items available: Sends itemtype_id (delegates to server) This minimizes server round-trips while delegating complex optimal selection logic to the server when multiple choices exist. Test plan: 1. Navigate to biblio detail page with bookable items 2. Click "Place booking" and select patron/pickup location 3. Select itemtype (not specific item) - "any item" mode 4. Select start date - verify end dates are maximized 5. Verify calendar disables dates when no items available 6. Submit booking - verify it succeeds 7. Check that optimal item was selected (server-side) 8. Test edit mode with "any item" selection 9. Verify both create and edit use same logic Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191957|0 |1 is obsolete| | --- Comment #26 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192799&action=edit Bug 40134: Add Cypress tests for booking improvements This patch adds end-to-end Cypress tests for the booking modal improvements, including smart window maximization and server-side optimal item selection. New Tests: 1. "should successfully submit an 'Any item' booking with server-side optimal item selection" - Tests the complete "any item" booking workflow - Selects itemtype and "Any item" option (item_id = 0) - Submits booking form - Verifies modal closes without errors - Validates booking created in database - Confirms item was assigned by server - Verifies server-side optimal selection completed - Test status: PASSING 2. "should maximize booking window by dynamically reducing available items during overlaps" - Creates 4 items with strategic booking patterns - Tests "never re-add items to pool" algorithm - Validates 5 scenarios: a) Full window when all items available b) Reduced window when Item 1 becomes unavailable c) Further reduction when Items 1&2 unavailable d) Minimal window with Items 1,2,3 unavailable e) No availability when all items booked - Demonstrates smart window maximization - Test status: PASSING 3. "should handle edit mode date initialization correctly" - Tests fix for edit mode race condition - Verifies dates populate correctly when editing booking - Ensures itemtype is set before date initialization - Tests that flatpickr dates are set properly - Test status: PASSING Updated Tests: - "should successfully submit a booking" * Updated to use day+5 start date (accounts for 3-day lead period) * Ensures test doesn't fail on past-date constraint - Updated test comments and log messages to reflect server-side selection * Changed from "client-side selectOptimalItem()" references * Updated to "server-side optimal item selection" * Clarified that server performs the optimal selection Test Coverage: - End-to-end "any item" booking submission - Smart window maximization algorithm - Edit mode date initialization - Server-side optimal selection validation - Database verification of assigned items - Modal interaction and form submission Test plan: 1. Start KTD environment 2. Ensure Cypress is installed: yarn install 3. Run: npx cypress run --spec "t/cypress/integration/Circulation/bookingsModalBasic_spec.ts" 4. Verify all 11 tests pass 5. Optionally run in interactive mode: npx cypress open Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #27 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 --- Comment #28 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #29 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This appears to be a new feature/enhancement rather than a bugfix, so it is not a suitable candidate for backporting to 25.05.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40134 Bug 40134 depends on bug 39584, which changed state. Bug 39584 Summary: Booking post-processing time cuts into circulation period https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39584 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org