[Bug 20066] New: Remove forbidden patterns from .inc and .tt files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 Bug ID: 20066 Summary: Remove forbidden patterns from .inc and .tt files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: indradg@l2c2.co.in QA Contact: testopia@bugs.koha-community.org The following files contain forbidden patterns a) includes/datatables.inc => [% interface %] instead of [% themelang %] b) modules/opac-auth-MARCdetail.tt => hard-coded path c) modules/opac-auth-detail.tt => hard-coded path This patch removes these. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |indradg@l2c2.co.in See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20053 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 --- Comment #1 from Indranil Das Gupta <indradg@l2c2.co.in> --- Created attachment 70810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70810&action=edit Bug 20066 - Remove forbidden patterns from .inc and .tt files This patch removes the forbidden patterns from the following files: a) datatables.inc => [% interface %] instead of [% themelang %] b) opac-auth-MARCdetail.tt => hard-coded path to JS resource. c) opac-auth-detail.tt => hard-coded path to JS resource. Test plan ========= 1/ Apply the patch from Bug 20053 and run koha-qa.pl. The QA tool will throw up these 3 files as FAIL for forbidden patterns use. 2/ Now apply this patch and run koha-qa.pl. The result should now be OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20053 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 [Bug 20053] Drop type attribute "text/javascript" for <script> elements used in OPAC templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Bug 20053 removed the javascript type, and yet, this keeps it. It does not apply in any order. Please fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 Bug 20066 depends on bug 20053, which changed state. Bug 20053 Summary: Drop type attribute "text/javascript" for <script> elements used in OPAC templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20066 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- While not really a duplicate, the Asset.pm template plugin basically corrected this issue intrinsically. *** This bug has been marked as a duplicate of bug 20538 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org