[Bug 38406] New: Item fields should not be stored on the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38406 Bug ID: 38406 Summary: Item fields should not be stored on the DB Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org After the inclusion of bug 31224, it become clear that Koha is allowing the storage of MARC field 952 in the `biblio_metadatas.metadata` column. I didn't spot it when reviewing bug 29697. To check this, look at Koha::Biblio::Metadata:226~230. In that place, code was added for removing it when retrieving from the DB, so legacy code could be easily ported into using this new code in the Koha::* namespace. Now that we implemented a -somehow- more clear approach, it got highlighted that we should deal with that. In my opinion, we should enforce either rejection, or removal+alert in AddBiblio and ModBiblio instead of the current approach of silently removing them after we allowed to store them. Or maybe we should do both. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38406 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |jonathan.druart@gmail.com, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com Depends on| |31224, 29697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38406 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Surely the inclusion of 952 in biblio_metadata.metadata is an accident? I reckon silent removal is all right. I suppose you never know when someone has sideloaded MARCXML into biblio_metadata.metadata. Surely that would be the most likely scenario of someone adding 952 in the metadata? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item fields should not be |Item fields should not be |stored on the DB |stored in the MARCXML in | |biblio_metadata -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38406 Bug 38406 depends on bug 31224, which changed state. Bug 31224 Summary: Koha::Biblio::Metadata->record should use the EmbedItems filter https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org