[Bug 9782] New: Cancel button doesn't work when importing MARC bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 Bug ID: 9782 Summary: Cancel button doesn't work when importing MARC bibliographic frameworks Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au Currently, when importing a MARC bibliographic framework, you'll get a little animated loading gif and some text saying "Importing into...", as well as a link that says Cancel. I think this is the same Cancel link that is meant to close the pop-up, but it seems like you could use it to Cancel the import. Well, if you click Cancel, the framework is still imported and now the "Importing into" pop-up remains on the page indefinitely regardless of how much you press Cancel. -- I suggest that we remove the Cancel link once the import has begun so as not to mislead users and so that the situation of the indefinite loading box doesn't occur. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20355&action=edit Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks When importing frameworks the "cancel" button should be hidden once an import is initiated since it is not possible to cancel the import in progress. This patch uses this bug as an excuse to replace the old import/export pop-ups with modal dialogs for all import/export functions. To test: - Try exporting both the default framework and at least one other framework. - Try importing both a default framework and at least one other framework. - When importing, observe that the modal dialog controls are hidden as soon as the import is initiated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20355|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 20522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20522&action=edit Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks When importing frameworks the "cancel" button should be hidden once an import is initiated since it is not possible to cancel the import in progress. This patch uses this bug as an excuse to replace the old import/export pop-ups with modal dialogs for all import/export functions. To test: - Try exporting both the default framework and at least one other framework. - Try importing both a default framework and at least one other framework. - When importing, observe that the modal dialog controls are hidden as soon as the import is initiated. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20522|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20607&action=edit [PASSED QA] Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks When importing frameworks the "cancel" button should be hidden once an import is initiated since it is not possible to cancel the import in progress. This patch uses this bug as an excuse to replace the old import/export pop-ups with modal dialogs for all import/export functions. To test: - Try exporting both the default framework and at least one other framework. - Try importing both a default framework and at least one other framework. - When importing, observe that the modal dialog controls are hidden as soon as the import is initiated. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, passes all tests and QA script. Also the modal works better on smaller screens. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org