[Bug 9140] New: Untranslatable strings in item circulation history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Bug ID: 9140 Summary: Untranslatable strings in item circulation history Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/bookcount.pl?&biblionumber=7&bi=7&i tm=26 OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de CC: frederic@tamil.fr Created attachment 13663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13663&action=edit screenshot, untranslatable terms highlighted There are some untranslatable terms on the item circulation history page. - Never - Item has no branch transfers record 1) Create a record with an item 2) Circulate the item a few times, don't transfer to other branches 3) Go to the record detail page 4) Open tab 'items' 5) Open item circulation history by clicking on 'View item's checkout history' 6) Switch to an installed translation (German, French...) Or take a look at the screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- bookcount.pl 115 return ( 0, "Item has no branch transfers record" ) if not $date;
Needs to be moved into the template
bookcount.tt 53 [% ELSE %]Never
Probably needs to be put inside an HTML tag
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #1)
bookcount.tt 53 [% ELSE %]Never
Probably needs to be put inside an HTML tag
Does whitespace affect a problem like this? How do I test if a chnage to the template fixes the problem? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, the way I test it is change the template, then run "perl translate update <lang>" from misc/translator, then check if the string shows up in the po file. I suspect wrapping it in a <span> shoudl probably do the trick. Thx for working on this! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13682&action=edit Bug 9140 - Untranslatable strings in item circulation history This patch removes the text of a message from the script to the template. The lastmove sub now returns either the date or 0, and the template displays the "no transfers" message if the date doesn't exist. To test, view the circulation history for items which do and do not have a transfer history. A date should be displayed for items which have a transfer history. A messages should be displayed for those which do not. This patch also adds a <span> around the text "Never" which was not getting picked up by the translation script. To test this change, run "perl translate update <lang>" from misc/translator, then check if the string shows up in the po file. (Thanks kf!) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13880&action=edit Bug 9140: Followup removes the useless variable $message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13682|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13941&action=edit [SIGNED-OFF] Bug 9140 - Untranslatable strings in item circulation history This patch removes the text of a message from the script to the template. The lastmove sub now returns either the date or 0, and the template displays the "no transfers" message if the date doesn't exist. To test, view the circulation history for items which do and do not have a transfer history. A date should be displayed for items which have a transfer history. A messages should be displayed for those which do not. This patch also adds a <span> around the text "Never" which was not getting picked up by the translation script. To test this change, run "perl translate update <lang>" from misc/translator, then check if the string shows up in the po file. (Thanks kf!) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13880|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13942&action=edit [SIGNED-OFF] Bug 9140: Followup removes the useless variable $message Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * passes koha-qa.pl * no side effect risk * clean some code, ++ passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13941|0 |1 is obsolete| | Attachment #13942|0 |1 is obsolete| | --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14237&action=edit Bug 9140: Followup removes the useless variable $message Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14237|0 |1 is obsolete| | --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14238&action=edit Bug 9140 - Untranslatable strings in item circulation history This patch removes the text of a message from the script to the template. The lastmove sub now returns either the date or 0, and the template displays the "no transfers" message if the date doesn't exist. To test, view the circulation history for items which do and do not have a transfer history. A date should be displayed for items which have a transfer history. A messages should be displayed for those which do not. This patch also adds a <span> around the text "Never" which was not getting picked up by the translation script. To test this change, run "perl translate update <lang>" from misc/translator, then check if the string shows up in the po file. (Thanks kf!) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14239&action=edit Bug 9140: Followup removes the useless variable $message Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x, will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9140 --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.9 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org