[Bug 42875] New: Wrong failure message when adding an item to a bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Bug ID: 42875 Summary: Wrong failure message when adding an item to a bundle Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- If bc_1 is checked out and I try to add bc_2 I get: "Failure: Item 'bc_2' belongs to another bundle" The POST returns 409 {"error":"Bundle is checked out","error_code":"bundle_checked_out"} The JS code: - } else if (response.error_code === "bundle_checkout_out") { - $("#addResult").replaceWith('<div id="addResult" class="alert alert-danger">' + _("Failure: Bundle is currently checked out") + "</div>"); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- % git grep bundle_checkout_out koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: } else if (responseJSON.error_code === "bundle_checkout_out") { koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: if (response.error_code === "bundle_checkout_out") { -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- % git grep bundle_checked_out Koha/REST/V1/Items.pm: error_code => 'bundle_checked_out' Koha/REST/V1/Items.pm: error_code => 'bundle_checked_out' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42732 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Depends on| |33817 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Coming from commit 34b704fb0b9da3d279c4169920d39b286d17fb39 Bug 33817: (follow-up) Fix spec and messages Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 [Bug 33817] Composition of an item bundle can be changed if checked out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201629&action=edit Bug 42875: Correct failure message when adding an item to a bundle If bc_1 is checked out and I try to add bc_2 I get: "Failure: Item 'bc_2' belongs to another bundle" It should be: "Failure: Bundle is currently checked out" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... Test plan so far (using KTD) (not sure I am right yet, as I am not familiar with bundles): 1. Pick a record with items, for example: The definitive guide to Catalyst (146) 2. Edit the record and change 000 (the leader): - Click the tag editor - Change "7- Bibliographic level" to "C- Collection" 3. In the holdings table there is now a "Manage bundle (0|0)" option in the far right column for each item. 4. Check an item out for the record out, for example I checked out 39999000006117 to Mary Burton. 5. In the holdings table for the record, click on "Manage bundle" for the item you checked out (39999000006117). 6. In the expanded text area below the item row, click "+ Add to bundle". 7. In pop-up window, enter 39999000006131 "Item barcode" field (this is one of the other items for the record that is not checked out). 8. Click Submit. 9. You get an error: Failure: Item '39999000006131' belongs to another bundle 10. Apply the patch. 11. Restart everything: restart all 12. Hard refresh the page for the record. 13. Repeat steps 5 to 8. 14. You now get the correct error: "Failure: Bundle is currently checked out" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201629|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204085&action=edit Bug 42875: Correct failure message when adding an item to a bundle If bc_1 is checked out and I try to add bc_2 I get: "Failure: Item 'bc_2' belongs to another bundle" It should be: "Failure: Bundle is currently checked out" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204085|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 204189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204189&action=edit Bug 42875: Correct failure message when adding an item to a bundle If bc_1 is checked out and I try to add bc_2 I get: "Failure: Item 'bc_2' belongs to another bundle" It should be: "Failure: Bundle is currently checked out" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |This fixes the error released in| |message when adding an item | |to a bundle, where the item | |is currently checked out: | |- Incorrect error message: | |"Failure: Item '[barcode]' | |belongs to another bundle" | |- Correct error message: | |"Failure: Bundle is | |currently checked out" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 204244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204244&action=edit Bug 42875: Correct failure message when adding an item to a bundle If bc_1 is checked out and I try to add bc_2 I get: "Failure: Item 'bc_2' belongs to another bundle" It should be: "Failure: Bundle is currently checked out" Test plan (using KTD): 1. Pick a record with items, for example: The definitive guide to Catalyst (146) 2. Edit the record and change 000 (the leader): - Click the tag editor - Change "7- Bibliographic level" to "C- Collection" 3. In the holdings table there is now a "Manage bundle (0|0)" option in the far right column for each item. 4. Check an item out for the record out, for example I checked out 39999000006117 to Mary Burton. 5. In the holdings table for the record, click on "Manage bundle" for the item you checked out (39999000006117). 6. In the expanded text area below the item row, click "+ Add to bundle". 7. In pop-up window, enter 39999000006131 "Item barcode" field (this is one of the other items for the record that is not checked out). 8. Click Submit. 9. You get an error: Failure: Item '39999000006131' belongs to another bundle 10. Apply the patch. 11. Restart everything: restart all 12. Hard refresh the page for the record. 13. Repeat steps 5 to 8. 14. You now get the correct error: "Failure: Bundle is currently checked out" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|This fixes the error |This fixes the error released in|message when adding an item |message when adding an item |to a bundle, where the item |to a bundle,26.11.00, where |is currently checked out: |the item is currently |- Incorrect error message: |checked out: |"Failure: Item '[barcode]' |- Incorrect error message: |belongs to another bundle" |"Failure: Item '[barcode]' |- Correct error message: |belongs to another bundle" |"Failure: Bundle is |- Correct error message: |currently checked out" |"Failure: Bundle is | |currently checked out" Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Version(s)|This fixes the error |26.11.00 released in|message when adding an item | |to a bundle,26.11.00, where | |the item is currently | |checked out: | |- Incorrect error message: | |"Failure: Item '[barcode]' | |belongs to another bundle" | |- Correct error message: | |"Failure: Bundle is | |currently checked out" | Text to go in the| |This fixes the error release notes| |message when adding an item | |to a bundle, where the item | |is currently checked out: | |- Incorrect error message: | |"Failure: Item '[barcode]' | |belongs to another bundle" | |- Correct error message: | |"Failure: Bundle is | |currently checked out" -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org