[Bug 42875] New: Wrong failure message when adding an item to a bundle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Bug ID: 42875 Summary: Wrong failure message when adding an item to a bundle Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- If bc_1 is checked out and I try to add bc_2 I get: "Failure: Item 'bc_2' belongs to another bundle" The POST returns 409 {"error":"Bundle is checked out","error_code":"bundle_checked_out"} The JS code: - } else if (response.error_code === "bundle_checkout_out") { - $("#addResult").replaceWith('<div id="addResult" class="alert alert-danger">' + _("Failure: Bundle is currently checked out") + "</div>"); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- % git grep bundle_checkout_out koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: } else if (responseJSON.error_code === "bundle_checkout_out") { koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: if (response.error_code === "bundle_checkout_out") { -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- % git grep bundle_checked_out Koha/REST/V1/Items.pm: error_code => 'bundle_checked_out' Koha/REST/V1/Items.pm: error_code => 'bundle_checked_out' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42732 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Depends on| |33817 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Coming from commit 34b704fb0b9da3d279c4169920d39b286d17fb39 Bug 33817: (follow-up) Fix spec and messages Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 [Bug 33817] Composition of an item bundle can be changed if checked out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42875 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201629&action=edit Bug 42875: Correct failure message when adding an item to a bundle If bc_1 is checked out and I try to add bc_2 I get: "Failure: Item 'bc_2' belongs to another bundle" It should be: "Failure: Bundle is currently checked out" -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org