[Bug 21765] New: AutoResumeSuspendedHolds actions are not logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Bug ID: 21765 Summary: AutoResumeSuspendedHolds actions are not logged Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: george@nekls.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When HoldsLog is set to "Log," holds that are manually unsuspended by staff or patrons are logged in action_logs, but holds unsuspended by auto_unsuspend_holds.pl are not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8864 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AutoResumeSuspendedHolds |AutoUnsuspendReserves |actions are not logged |manually sets holds fields | |instead of calling ->resume Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This has the side-effect of having holds resuming by the auto_unsuspend_holds.pl script not logging. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84999&action=edit Bug 21765: Regression tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 85000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85000&action=edit Bug 21765: Make AutoUnsuspendReserves call Koha::Hold->resume This patch makes the mentioned method use the biult-in method for resuming a suspended hold, instead of manually setting the specific attributes using the accessors. The side effect for this is that HoldsLog is now honoured. This patchset also refactors the tests a bit so they rely on the exposed methods and thus don't rely on specific implementation details (like suspended hold means a date in suspended_until plus suspended=1). To test: - Apply the regression tests patch - Run: $ kshell k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t => FAIL: It fails loudly because things are done manually - Apply this patch - Run: k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t => SUCCESS: Tests pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84999|0 |1 is obsolete| | Attachment #85000|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85007&action=edit Bug 21765: Regression tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85008&action=edit Bug 21765: Make AutoUnsuspendReserves call Koha::Hold->resume This patch makes the mentioned method use the biult-in method for resuming a suspended hold, instead of manually setting the specific attributes using the accessors. The side effect for this is that HoldsLog is now honoured. This patchset also refactors the tests a bit so they rely on the exposed methods and thus don't rely on specific implementation details (like suspended hold means a date in suspended_until plus suspended=1). To test: - Apply the regression tests patch - Run: $ kshell k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t => FAIL: It fails loudly because things are done manually - Apply this patch - Run: k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t => SUCCESS: Tests pass! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85007|0 |1 is obsolete| | Attachment #85008|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85386&action=edit Bug 21765: Regression tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85387&action=edit Bug 21765: Make AutoUnsuspendReserves call Koha::Hold->resume This patch makes the mentioned method use the biult-in method for resuming a suspended hold, instead of manually setting the specific attributes using the accessors. The side effect for this is that HoldsLog is now honoured. This patchset also refactors the tests a bit so they rely on the exposed methods and thus don't rely on specific implementation details (like suspended hold means a date in suspended_until plus suspended=1). To test: - Apply the regression tests patch - Run: $ kshell k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t => FAIL: It fails loudly because things are done manually - Apply this patch - Run: k$ prove t/db_dependent/Reserves/AutoUnsuspendReserves.t => SUCCESS: Tests pass! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 - I considered the lack of an action log in this case a bug the overriding factor here and so switch back from 'enhancement' to 'bug'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #10 from Jesse Maseto <jesse@bywatersolutions.com> --- Pushed to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org