[Bug 20395] New: Paycollect does not use Price formatter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Bug ID: 20395 Summary: Paycollect does not use Price formatter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: pasi.kallinen@joensuu.fi QA Contact: testopia@bugs.koha-community.org paycollect.tt still uses format('%.2f') instead of $Price -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |pasi.kallinen@joensuu.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- And also these templates are using it too: acqui/parcel.tt admin/smart-rules.tt reserve/request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 --- Comment #2 from paxed <pasi.kallinen@joensuu.fi> --- Created attachment 72903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72903&action=edit Bug 20395: Change paycollect to use Price formatter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Confirmed Josef's comment with: git grep "format(['\"]%.2f['\"])" | grep [.]tt: git show 3910d5e8b I believe the best course of action for the currency line is to cut it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 72976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72976&action=edit Bug 20395: Followup to change format to use price filter See comment #1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72903|0 |1 is obsolete| | --- Comment #5 from Roch D'Amour <roch.damour@inlibro.com> --- Created attachment 73057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73057&action=edit Bug 20395: Change paycollect to use Price formatter Test plan: 1) Apply patch 2) Go to Home -> Patrons -> Patron details (for any patron) 3) Create manual invoice for the patron 4) Pay fines -> Pay -button 5) Check that the currency values look correct 6) Pay fines -> Pay amount -button 7) Check that the currency values look correct 8) Pay fines -> Pay selected -button 9) Check that the currency values look correct 10) Change the CurrencyFormat setting 11) Repeat 2-9 Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72976|0 |1 is obsolete| | --- Comment #6 from Roch D'Amour <roch.damour@inlibro.com> --- Created attachment 73058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73058&action=edit Bug 20395: Followup to change format to use price filter See comment #1. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Josef and others - I think fixing one file here is ok and easier to test. Let's move the others to separate bugs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Paycollect does not use |Use Price formatter in more |Price formatter |templates (paycollect, | |request, parcel, | |smart-rules) --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... Hm, missed the patch was already done. We should change the title in that case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The change on smart rules is incomplete, the fine amount still doesn't use the formatter, so we are getting a mixed display. can you please fix? Everything else appears to work nicely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #9)
The change on smart rules is incomplete, the fine amount still doesn't use the formatter, so we are getting a mixed display. can you please fix?
Anything that was formatted has been fixed already. Are you finding a different bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It might look a little different in the code, but I think still worth fixing as with this patches we have a formatted value appearing right next to an unformatted value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73057|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136484&action=edit Bug 20395: Change paycollect to use Price formatter Test plan: 1) Apply patch 2) Go to Home -> Patrons -> Patron details (for any patron) 3) Create manual invoice for the patron 4) Pay fines -> Pay -button 5) Check that the currency values look correct 6) Pay fines -> Pay amount -button 7) Check that the currency values look correct 8) Pay fines -> Pay selected -button 9) Check that the currency values look correct 10) Change the CurrencyFormat setting 11) Repeat 2-9 Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73058|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136485&action=edit Bug 20395: Followup to change format to use price filter See comment #1. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Failed QA |Passed QA --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Wow, can't believe this is still the case.. all sorted now and rebased. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22112 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 136503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136503&action=edit Bug 20395: (follow-up) Change format to use price filter See comment #1. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.04 released in| | --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 --- Comment #18 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- backported to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org