[Bug 21413] New: Inventory - Skip items with waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Bug ID: 21413 Summary: Inventory - Skip items with waiting holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11405 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 [Bug 11405] Inventory tool enhancements -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 79432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79432&action=edit Bug 21413: Unit tests To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Items/GetItemsForInventory.t => FAIL: Tests fail! - Apply the next patches on the bug - Run: k$ prove t/db_dependent/Items/GetItemsForInventory.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 79433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79433&action=edit Bug 21413: Inventory - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Writing patches under another name? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #3)
Writing patches under another name? :)
I'm splitting bug 11405. On this one I added tests too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inventory - Skip items with |Inventory - Allow skipping |waiting holds |items with waiting holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21419 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21419 [Bug 21419] Inventory - Allow skipping items with in transit holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79432|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81376&action=edit Bug 21413: Unit tests To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Items/GetItemsForInventory.t => FAIL: Tests fail! - Apply the next patches on the bug - Run: k$ prove t/db_dependent/Items/GetItemsForInventory.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81376|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81377&action=edit Bug 21413: Unit tests To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Items/GetItemsForInventory.t => FAIL: Tests fail! - Apply the next patches on the bug - Run: k$ prove t/db_dependent/Items/GetItemsForInventory.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79433|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81378&action=edit Bug 21413: Inventory - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81379&action=edit Bug 21413: (QA follow-up) Rename new option Trying to make the terminology a little more consistent as we already use items instead of copies directly above and leaning on the description of the page it refers to. Old: Skip copies marked as waiting holds New: Skip items on hold awaiting pickup Skip items on hold awaiting pickup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Last patch is a suggestion, leaving it to native-speaker RM to decide :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82040&action=edit Bug 21413: Fix condition to avoid operator bnding isssues The original WHERE condition wasn't enclosed in parenthesis, and hence was subject to binding precedence issues in some situations. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82111&action=edit Bug 21413: Call AddBiblio in list context Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #12)
Created attachment 82111 [details] [review] Bug 21413: Call AddBiblio in list context
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Follow up pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 82168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82168&action=edit Bug 21413: (QA follow-up) Fix tests No assumption on the order in which restults are returned should be made (we don't control existing data on the tests). So it should only check existence of expected records in the results, and absense. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The enhancement will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21413 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22219 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org