[Bug 41347] New: Terminology: Item had a reserve waiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 Bug ID: 41347 Summary: Terminology: Item had a reserve waiting Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Found while translating: Item had a reserve waiting koha-tmpl/intranet-tmpl/prog/js/transport_status.js:2 reserve should be changed to hold or maybe booking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Same here: Item was reserved koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc:225 Item was placed on hold Item was booked ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I don't see a reserve string in koha-tmpl/intranet-tmpl/prog/js/transport_status.js anymore. However there are two in koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc 'Item had a reserve waiting' should be changed to 'Hold waiting on item' 'Item was reserved' should be changed to 'Hold placed on item' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 22264cc@hvhs.school.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 --- Comment #3 from 22264cc@hvhs.school.nz --- Created attachment 191734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191734&action=edit Bug 41347: Terminology: Item had a reserve waiting "Item had a reserve waiting" changed to "Hold waiting on item" "Item was reserved" changed to "hold placed on item" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Catalyst list of Sponsors| | Text to go in the| |This fixes the terminology release notes| |for two log viewer | |messages: | |- "Item had a reserve | |waiting" to "Hold waiting | |on item" | |- "Item was reserved" to | |"Hold placed on item" Severity|enhancement |trivial Assignee|oleonard@myacpl.org |22264cc@hvhs.school.nz CC| |david@davidnind.com QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | Sponsorship status|--- |Sponsored Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|david@davidnind.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191734|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 191814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191814&action=edit Bug 41347: Terminology: Item had a reserve waiting "Item had a reserve waiting" changed to "Hold waiting on item" "Item was reserved" changed to "hold placed on item" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 --- Comment #5 from David Nind <david@davidnind.com> --- Hi. Thanks for the patch! Entirely option, but if you would like your real name associated with the patch then let me know, and I'll update the patch author information. This shows up in the Koha timeline page under about Koha, with new developer names shown (once a patch is pushed and included in a release). It might also look good on your CV! David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I notice that the patch changes the strings from past to present tense: Item had a reserve waiting --> Hold waiting on item As these entries are for the action logs, a kind of protocol of actions, I am not sure which is better. Leasing final decision to native speakers :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191814|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 191833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191833&action=edit Bug 41347: Terminology: Item had a reserve waiting "Item had a reserve waiting" changed to "Hold waiting on item" "Item was reserved" changed to "hold placed on item" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #6)
I notice that the patch changes the strings from past to present tense:
Item had a reserve waiting --> Hold waiting on item
As these entries are for the action logs, a kind of protocol of actions, I am not sure which is better. Leasing final decision to native speakers :)
If the normal approach for log messages is the past tense, then we should change it to keep it consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41347 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |CLOSED CC| |catrina@bywatersolutions.co | |m --- Comment #12 from Catrina Berka <catrina@bywatersolutions.com> --- No documentation needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org