[Bug 23341] New: Hold Notes should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Bug ID: 23341 Summary: Hold Notes should allow for HTML tags Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: training@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In Koha version in 18.11, HTML tags should be allowed in Hold Notes. THis is similar to bug 23194, 22702, 22501. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Kelly <training@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Kelly <training@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 91609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91609&action=edit Bug 23341: Hold Notes should allow for HTML tags TEST PLAN: 1. place a hold 2. make sure you add a note that includes HTML like "<a href="www.google.com">yolo</a>" 3. notice that HTML displays literally 4. apply patch 5. Now the note field should render the HTML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91609|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 91658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91658&action=edit Bug 23341: Hold Notes should allow for HTML tags Signed-off-by: Jessica Ofsa <jofsa@vt.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Jessica Ofsa <jofsa@vt.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jofsa@vt.edu --- Comment #3 from Jessica Ofsa <jofsa@vt.edu> --- HTML tested: TN 149xxxx <br> Title: <br> Call Number: BF721 .P8 V. 58 <br> Year: 20030101 <br> V. 58 <br> Issue/Part: <br> pg. 35- <br> Article Title: Margo and me. Gender as a cause and solution to unmet needs. <br> Article Author: Knight, Rona, <br> Resulting hold note: TN 149xxxx Title: Call Number: BF721 .P8 V. 58 Year: 20030101 V. 58 Issue/Part: pg. 35- Article Title: Margo and me. Gender as a cause and solution to unmet needs. Article Author: Knight, Rona, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Frédérik Chénier <frederik.chenier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91658|0 |1 is obsolete| | --- Comment #4 from Frédérik Chénier <frederik.chenier@inlibro.com> --- Created attachment 91661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91661&action=edit Bug 23341: Hold Notes should allow for HTML tags Signed-off-by: Jessica Ofsa <jofsa@vt.edu> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- This has one caveat - patrons can enter these notes, not just staff, so this would open possibility of XSS attack Talking internally we think we could filter the patron note on entry Alternatively, we can split the note into a public_note and private_note - filter the public and display it to patrons, but don't filter the private_note and keep it only for staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #5)
This has one caveat - patrons can enter these notes, not just staff, so this would open possibility of XSS attack
Talking internally we think we could filter the patron note on entry
Alternatively, we can split the note into a public_note and private_note - filter the public and display it to patrons, but don't filter the private_note and keep it only for staff
Do we know more about the use case for this? If it's about handling line breaks like in the example from Jessica we could handle this easily without allowing line breaks. Otherwise I really like the idea of splitting into internal and public notes as this would allow for more flexible use. Right now if you use the note publicly, you don't have any way to make internal notes and this could easily go wrong. Should we reset status here to "In discussion"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Moving this to discussion for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #8 from Joy Nelson <joy@bywatersolutions.com> --- see bz 25468 for new approach to solving the problem -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org