https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35289 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33669, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35288 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35289 --- Comment #1 from Mark Hofstetter <koha@trust-box.at> --- Created attachment 158663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158663&action=edit Bug 35289: addbiblio.pl calls generate_subfield_form with inconsistent parameters ApplyFrameworkDefaults works only for tags smaller than 10 this seems to be because addbiblio.pl calls $biblio_form_builder->generate_subfield_form 4 times(!) three of them are missing (at least) the following 3 paramters op => scalar $input->param('op'), changed_framework => scalar $input->param('changed_framework'), breedingid => scalar $input->param('breedingid'), so Koha::UI::Form::Builder::Biblio checks for ( $applydefaults =~ /new/ && !$self->{biblionumber} ) || ( $applydefaults =~ /duplicate/ && $op eq 'duplicate' ) || ( $applydefaults =~ /changed/ && $changed_framework ) || ( $applydefaults =~ /imported/ && $breedingid ) and this works only for the "new" case, this patch fixes this error To test: 1) you need: one record, two frameworks including both of them including a marc field X (tag > 10) 2) record should be in framework A, marcfield X should be empty 3) define a defaultvalue for marcfield X in framework B 4) "edit record", change framework (setting) to framework B 5) marcfield X remains emtpy, which is an error imho 6) Apply patch 7) repeat step 4 8) marcfield X should now have the default value 9) please Sign off Sponsored-by: Styrian State Library Co-authored-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35289 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35288 [Bug 35288] ApplyFrameworkDefaults add plugin to add more fine grained defaults handling -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35289 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |phil@chetcolibrary.org Status|Needs Signoff |RESOLVED --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Somebody beat you to it. *** This bug has been marked as a duplicate of bug 34993 *** -- You are receiving this mail because: You are watching all bug changes.