https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172386&action=edit Bug 38087: Add print template for WELCOME notice at install time This patch adds a default print template for the welcome notice. It will be installed at install time but will not be added at upgrade time. It will also be available as the default under the notice templates tool. Test plan 1) Apply the patch 2) Under 'Tools > Notices and Slips' select the 'WELCOME' notice to edit 3) Click 'View default' under the 'Print' message transport type 4) Note the new default template is shown 5) Use 'Copy to template' to apply it to the notice 6) Use a user (Henry perhaps under sandboxes) without an email address to test the template by 6a) Under 'more' click 'Send welcome notice' 7) Preview the pending print notice under the patrons notices tab by clicking the notice title. 8) Confirm the notice looks reasonable and sign off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com, | |Laura.escamilla@bywatersolu | |tions.com, | |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172386|0 |1 is obsolete| | --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 172398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172398&action=edit Bug 38087: Add print template for WELCOME notice at install time This patch adds a default print template for the welcome notice. It will be installed at install time but will not be added at upgrade time. It will also be available as the default under the notice templates tool. Test plan 1) Apply the patch 2) Under 'Tools > Notices and Slips' select the 'WELCOME' notice to edit 3) Click 'View default' under the 'Print' message transport type 4) Note the new default template is shown 5) Use 'Copy to template' to apply it to the notice 6) Use a user (Henry perhaps under sandboxes) without an email address to test the template by 6a) Under 'more' click 'Send welcome notice' 7) Preview the pending print notice under the patrons notices tab by clicking the notice title. 8) Confirm the notice looks reasonable and sign off Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This patch adds a default print template for the welcome notice. It will be installed at install time but will not be added at upgrade time. That is unusual. Please explain why. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178684&action=edit Bug 38087: Add atomicupdate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178684|0 |1 is obsolete| | --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179200&action=edit Bug 38087: Add atomicupdate Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am pondering the same as Marcel, but in the other direction. I am pondering to drop the second patch and be happy with the new installations + reset option. OK or am I missing something because it's the print one? When updating Koha installations we try to have the "least surprise" and avoid behavior change. Now that we have the notice reset feature (which honestly is awesome) libraries can add a print notice any time from that and it will be also the translated version in their language. We also discussed on another bug how to make the reset feature more prominent for creating notices from scratch. But another question: I notice a lot of unusual CSS classes in the template, can you explain about these? <div class=\"col-6\"> <div class=\"col-6 text-end\"> <div class=\"row mb-4\"> We don't have any of these in other notices and I believe there is no sample CSS to use them, so maybe we should remove from the sample or add some notes on how to make use of them for formatting? Waiting for feedback - will get back to this asap then. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize (ashimema) from comment #10)

I wrote this long enough ago that I can't entirely remember the specifics of the classes.. it was written as a way to easy testing some of the CSS bugs and the staff client notices display and print pages bug... the classes are likely referring to those patches.. and as far as I can tell now they're all just standard bootstrap 5.

I was wondering because it's for the print layout and I think then they probably won't be applied, but I am not sure. We can still simplify later, I won't change the template for now but leave off the database update. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- See screenshot.. that's how the notice looks for the Henry user in KTD with the classes in tact.. personally.. I think that's a reasonable display for a print style notice and would prefer not to remove them. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179587&action=edit Bug 38087: (follow-up) Add missing div to template We lost a closing div somewhere during the life of this patchset -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39410 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39410 [Bug 39410] Notice display modal should use shadow dom -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38087 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.