https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41202 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|koha-bugs@lists.koha-commun |jake.deery@openfifth.co.uk |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41202 --- Comment #1 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 189151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189151&action=edit Bug 41202: Remove hidden negcap for accessibility This patch removes the negcap field on opac-suggestions, as it serves no purpose other than to confuse screen readers. If ncessary, it should be replaced in a follow-up patch with a visually accessible captcha field. == TO TEST == a) go to /cgi-bin/koha/opac-suggestions.pl?op=add_form&biblionumber=56 b) notice as you tab through the form, the focus caret seems to disappear c) inspect the code, and see the negcap field d) complete and submit the form successfully == APPLY PATCH == e) repeat steps a-d f) notice tabbing now works correctly g) notice the negcap field is no longer present h) the form should still successfully submit == SIGN OFF == -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41202 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41202 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off, as what is in the test plan works. However, if anonymous suggestions are allowed (AnonSuggestions = Allow, and AnonymousPatron set (for example, to 19), then the 'negcap' field is also removed from teh form. Testing notes (using KTD): 1. The hidden field is between the 'Notes' and 'Submit your suggestion' fields. When you tab from notes to submit, tab twice to get the submit field to be selected. 2. If you inspect the source before the patch, you will see this HTML markup (after the patch, it is no longer there): <!-- Add a hidden 'negcap' field --> <li id="negcap" style="position: absolute; left: -2000px;"> negcap <input type="text" name="negcap"> </li> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41202 --- Comment #4 from Jake Deery <jake.deery@openfifth.co.uk> --- Hi David, Thanks for the sign-off. I agree with your sentiment around negcap and anonymous access. I think we need a better solution, though – something that doesn't break accessibility. Perhaps a follow-up bug, which addresses reimplementing this using a proper captcha library? We could also then use that on the self-reg form, too. Thanks, Jake -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41202 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3144 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41202 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving to In Discussion given comments 3 and 4. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41202 --- Comment #8 from David Nind <david@davidnind.com> --- Maybe we add something like is on the self-registration form (Verification section - Please type the following characters into the preceding box: XXXX) but only for patrons that aren't logged in. I'm not QAing (I'm not a developer), but I would suggest (as you have): 1. Fixing the accessibility issue with this bug. 2. Another bug to add the verification section for patrons that are not logged in. -- You are receiving this mail because: You are watching all bug changes.