[Bug 33956] New: opac-user.pl should use Koha::Biblio->opac_summary_html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 Bug ID: 33956 Summary: opac-user.pl should use Koha::Biblio->opac_summary_html Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 33954 Added by bug 33954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33954 [Bug 33954] Add Koha::Biblio->opac_summary_html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153042&action=edit Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl This code is currently duplicated in controllers opac-readingrecord.pl and opac-user.pl. After bug 33949 it will be removed from opac-readingrecord.pl, and bug 33956 aims to remove it from opac-user.pl. Final situation will be: we have the code in a module, covered by tests \o/ Test plan: Check an item out Setup OPACMySummaryHTML ("biblionumber: {BIBLIONUMBER}" for instance) Go to the "Your summary" at the OPAC and notice the "Links" column Everything should work identically before and after this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153042|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153074&action=edit Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl This code is currently duplicated in controllers opac-readingrecord.pl and opac-user.pl. After bug 33949 it will be removed from opac-readingrecord.pl, and bug 33956 aims to remove it from opac-user.pl. Final situation will be: we have the code in a module, covered by tests \o/ Test plan: Check an item out Setup OPACMySummaryHTML ("biblionumber: {BIBLIONUMBER}" for instance) Go to the "Your summary" at the OPAC and notice the "Links" column Everything should work identically before and after this patch Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153074|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 153415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153415&action=edit Bug 33956: Use Koha::Biblio->opac_summary_html from opac-user.pl This code is currently duplicated in controllers opac-readingrecord.pl and opac-user.pl. After bug 33949 it will be removed from opac-readingrecord.pl, and bug 33956 aims to remove it from opac-user.pl. Final situation will be: we have the code in a module, covered by tests \o/ Test plan: Check an item out Setup OPACMySummaryHTML ("biblionumber: {BIBLIONUMBER}" for instance) Go to the "Your summary" at the OPAC and notice the "Links" column Everything should work identically before and after this patch Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 Bug 33956 depends on bug 33954, which changed state. Bug 33954 Summary: Add Koha::Biblio->opac_summary_html https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33954 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33956 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Architectural enhancement, not required for 23.05.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org