https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Blocks| |21156 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> ---

Looks like LangInstaller.pm is looking in the wrong dir for the javascript files, @js_dirs is set to

- "$intranetdir/koha-tmpl/intranet-tmpl/prog/js", - "$intranetdir/koha-tmpl/opac-tmpl/bootstrap/js",

when it should be using

+ "$intrahtdocs/prog/js", + "$opachtdocs/bootstrap/js",

Compare @js_dirs with @intranet_tt_files and @opac_tt_files in LangInstaller.

You are right, good catch! That lines belong to Bug 21156, already on master but can be fixed :) They work on a git/dev install but not on a normal one. Will you write the patch? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 99674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99674&action=edit Bug 24734: Fix paths in LangInstaller.pm for JS files Use intrahtdocs and opachtdocs in order to get the correct paths for all kind of installations Test plan: 1. With a dev install, run ./translator create/update/install xx-XX and verify that there is no error message 2. With a standard install, run ./translator create/update/install xx-XX and verify that there is no error message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99674|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 99675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99675&action=edit Bug 24734: Fix paths in LangInstaller.pm for JS files Use intrahtdocs and opachtdocs in order to get the correct paths for all kind of installations Test plan: 1. With a dev install, run ./translator create/update/install xx-XX and verify that there is no error message 2. With a standard install, run ./translator create/update/install xx-XX and verify that there is no error message Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested for dev/single/standard installs, no errors, just a (normal) warn from po2json. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are still some issues, but I believe htem to be unrelated to this patch: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:569: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:858: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:904: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:911: warning: unterminated string koha-tmpl/intranet-tmpl/prog/js/checkouts.js:1095: warning: RegExp literal terminated too early -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99675|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99813&action=edit Bug 24734: Fix paths in LangInstaller.pm for JS files Use intrahtdocs and opachtdocs in order to get the correct paths for all kind of installations Test plan: 1. With a dev install, run ./translator create/update/install xx-XX and verify that there is no error message 2. With a standard install, run ./translator create/update/install xx-XX and verify that there is no error message Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested for dev/single/standard installs, no errors, just a (normal) warn from po2json. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24734 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.04 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.04 -- You are receiving this mail because: You are watching all bug changes.