[Bug 23659] New: Allow hold pickup location to default to item home branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Bug ID: 23659 Summary: Allow hold pickup location to default to item home branch Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Koha defaults hold pickup location to the patron's home branch. Some libraries would prefer that hold pickup default to the item's home branch instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Actually, right now in 21.05, it looks like there is a bug and pickup location for specific items is defaulting to the item's home branch. This is certainly not a desired effect for all libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29349 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29660 CC| |jonathan.druart+koha@gmail. | |com, | |nick@bywatersolutions.com --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Currently in master: If a hold is allowed, we default the pickup location to the item's home library If a hold is allowed via override, we default to the logged in library Before bug 29660: If a hold was allowed, we default the pickup location to the logged in library If a hold was allowed via override, we default to the item's home library This means master and stables have reversed the defaults I think we need to make this configurable and consistent Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 [Bug 29660] reserve/request.pl should not deal with biblioitem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 135120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135120&action=edit Bug 23659: Add DefaultHoldPickupLocation system preference On the staff side behaviour differs for default pickup location when placing a hold or placing an overridden hold. Additionally, the behaviour has changed betwee master and stables We should provide a consistent default, and allow the library to specify their choice Note this only affects staff client as there is only a single dropdown on OPAC and it is not tied to items To test: 1 - Apply patch 2 - Update database 3 - Find a record with items from various branches, and at least one with a different home/holding branch 4 - Ensure there is an item that requires override to hold, and AllowHoldPolicyOverride is enabled 4 - Attempt to place hold 5 - Confirm all dropdowns default to logged in library 6 - Set DefaultHoldPickupLocation to item's home branch 7 - Refresh and confirm all dropdowns match item home library except biblio level hold - still logged in library 8 - Set DefaultHoldPickupLocation to item's holding branch 9 - Refresh and confirm defaults 10 - Mark one of the items holding library as 'not a pickup location' in Admin->Libraries 11 - Refresh and confirm dropdown is now empty for that item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135120|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 135204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135204&action=edit Bug 23659: Add DefaultHoldPickupLocation system preference On the staff side behaviour differs for default pickup location when placing a hold or placing an overridden hold. Additionally, the behaviour has changed betwee master and stables We should provide a consistent default, and allow the library to specify their choice Note this only affects staff client as there is only a single dropdown on OPAC and it is not tied to items To test: 1 - Apply patch 2 - Update database 3 - Find a record with items from various branches, and at least one with a different home/holding branch 4 - Ensure there is an item that requires override to hold, and AllowHoldPolicyOverride is enabled 4 - Attempt to place hold 5 - Confirm all dropdowns default to logged in library 6 - Set DefaultHoldPickupLocation to item's home branch 7 - Refresh and confirm all dropdowns match item home library except biblio level hold - still logged in library 8 - Set DefaultHoldPickupLocation to item's holding branch 9 - Refresh and confirm defaults 10 - Mark one of the items holding library as 'not a pickup location' in Admin->Libraries 11 - Refresh and confirm dropdown is now empty for that item Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow hold pickup location |Allow hold pickup location |to default to item home |to default to item home |branch |branch for item-level holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30811 [Bug 30811] Allow hold pickup location to default to item home/holding branch for bib-level holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 135204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135204 Bug 23659: Add DefaultHoldPickupLocation system preference Review of attachment 135204: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23659&attachment=135204) ----------------------------------------------------------------- ::: installer/data/mysql/mandatory/sysprefs.sql @@ +164,4 @@
('DefaultHoldExpirationdate','0','','Automatically set expiration date for holds','YesNo'), ('DefaultHoldExpirationdatePeriod','0','','How long into the future default expiration date is set to be.','integer'), ('DefaultHoldExpirationdateUnitOfTime','days','days|months|years','Which unit of time is used when setting the default expiration date. ','choice'), +('DefaultHoldPickupLocation','loggedinlibrary','loggedinlibrary|homelibrary','Which branch should a hold pickup location default to. ','choice'),
loggedinlibrary|homelibrary doesn't match the options in the upgrade of 'loggedinlibrary|homebranch|holdingbranch' here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 135263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135263&action=edit Bug 23659: (follow-up) Correct syspref.sql to match atomicupdate Missed updating this file when I added another option and renamed another -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135204|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135278&action=edit Bug 23659: Add DefaultHoldPickupLocation system preference On the staff side behaviour differs for default pickup location when placing a hold or placing an overridden hold. Additionally, the behaviour has changed betwee master and stables We should provide a consistent default, and allow the library to specify their choice Note this only affects staff client as there is only a single dropdown on OPAC and it is not tied to items To test: 1 - Apply patch 2 - Update database 3 - Find a record with items from various branches, and at least one with a different home/holding branch 4 - Ensure there is an item that requires override to hold, and AllowHoldPolicyOverride is enabled 4 - Attempt to place hold 5 - Confirm all dropdowns default to logged in library 6 - Set DefaultHoldPickupLocation to item's home branch 7 - Refresh and confirm all dropdowns match item home library except biblio level hold - still logged in library 8 - Set DefaultHoldPickupLocation to item's holding branch 9 - Refresh and confirm defaults 10 - Mark one of the items holding library as 'not a pickup location' in Admin->Libraries 11 - Refresh and confirm dropdown is now empty for that item Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135263|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135279&action=edit Bug 23659: (follow-up) Correct syspref.sql to match atomicupdate Missed updating this file when I added another option and renamed another Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Nick.. all looking good now.. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a new release notes| |system preference | |'DefaultHoldPickupLocation' | | | |This preference will allow | |the library to determine | |which library is the | |default for pickup location | |dropdowns while placing | |holds in the staff client. | |The options are logged in | |library, homebranch, or | |holdingbranch | | | |Previously | |the behavior was | |inconsistent, and varied | |between versions. Libraries | |may need to adjust this | |preference after upgrade to | |mirror their expected | |workflow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- depends on 29660, not relevant for 21.11. won't backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30990 [Bug 30990] Terminology: DefaultHoldPickupLocation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/616 CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch@interleaf.ie --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 32024 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org