[Bug 13134] New: Add patron category to returns confirmation dialogs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Bug ID: 13134 Summary: Add patron category to returns confirmation dialogs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32617&action=edit Bug 13134 - Add patron category to returns confirmation dialogs Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. This patch adds the patron category to the hold and transfer popups to the patron information already displayed. The li tags that contain the patron category have the class "patron-category" to allow this data to be easily hidden. Test Plan: 1) Apply this patch 2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32617|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32618&action=edit Bug 13134 - Add patron category to returns confirmation dialogs Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. This patch adds the patron category to the hold and transfer popups to the patron information already displayed. The li tags that contain the patron category have the class "patron-category" to allow this data to be easily hidden. Test Plan: 1) Apply this patch 2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- My inclination is to add this to the line with the patron name, similar to the way we do it on the screen where you submit a partial name for checkout and are presented with a multi-select. For example: <li> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %]<span class="patron-category"> - [% borcategory %]</span>) </li> Which would like something like this: - Leonard, Owen (012345 - Adult) Seems more compact and logical to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Owen Leonard from comment #3)
My inclination is to add this to the line with the patron name, similar to the way we do it on the screen where you submit a partial name for checkout and are presented with a multi-select. For example:
<li> <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borsurname %], [% borfirstname %]</a> ([% borcnum %]<span class="patron-category"> - [% borcategory %]</span>) </li>
Which would like something like this:
- Leonard, Owen (012345 - Adult)
Seems more compact and logical to me.
I agree. I think that's a much better idea. I'll update the patch as soon as I can. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32618|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32642&action=edit Bug 13134 - Add patron category to returns confirmation dialogs Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. This patch adds the patron category to the hold and transfer popups to the patron information already displayed. The li tags that contain the patron category have the class "patron-category" to allow this data to be easily hidden. Test Plan: 1) Apply this patch 2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kyle M Hall from comment #5)
2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed
I think there's a copy-paste error. I'm not seeing the patron category in this latest version for either of those cases. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org