[Bug 30784] New: Rephrase OPACMandatoryHoldDates slightly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 Bug ID: 30784 Summary: Rephrase OPACMandatoryHoldDates slightly Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The OPACMandatoryHoldDates system preferen mentions: On the opac-reserve form, make... I think it would be a little nicer to describe the page like we do in other places as not everyone might be used to look at the URL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It might also be nice to add a link to OPACAllowHoldDateInFuture, as this is required in order to set a start date of a hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #1)
It might also be nice to add a link to OPACAllowHoldDateInFuture, as this is required in order to set a start date of a hold.
Scratch that, only needs to be linked, it's mentioned already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 --- Comment #3 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Created attachment 137349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137349&action=edit Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly TEST PLAN: 1. On the Admin page, navigate to Koha Administration > Global System Preferences 2. Search for OPACMandatoryHoldDates 3. In the Value field, check that it now says On the "Placing a hold" form, instead of opac-reserve form. Sponsored by Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137349|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 137351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137351&action=edit Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly TEST PLAN: 1. On the Admin page, navigate to Koha Administration > Global System Preferences 2. Search for OPACMandatoryHoldDates 3. In the Value field, check that it now says On the "Placing a hold" form, instead of opac-reserve form. Sponsored by Catalyst IT Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works as expected, needs indpendent sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137351|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 137358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137358&action=edit Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly TEST PLAN: 1. On the Admin page, navigate to Koha Administration > Global System Preferences 2. Search for OPACMandatoryHoldDates 3. In the Value field, check that it now says On the "Placing a hold" form, instead of opac-reserve form. Sponsored by Catalyst IT Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 137359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137359&action=edit Bug 30784: (follow-up) Addiional rephrasing Add additional clarifcation, format NOTE: similar to most other notes in system preferences (bold, start on a new line), and link to other system preferences mentioned. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 137360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137360&action=edit Bug 30784: (follow-up) Additional rephrasing Add additional clarifcation, format NOTE: similar to most other notes in system preferences (bold, start on a new line), and link to other system preferences mentioned. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #137359|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Comment on attachment 137359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137359 Bug 30784: (follow-up) Addiional rephrasing Fixed spelling error in bug title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the text for release notes| |the OPACMandatoryHoldDates | |system preference. It | |replaces the URL for the | |form (opac-reserve) with a | |description, formats the | |note similar to other | |notes, and links to other | |system preferences | |mentioned in the | |description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl Assignee|oleonard@myacpl.org |danyonsewell@catalyst.net.n | |z Version|20.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137358|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137363&action=edit Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly TEST PLAN: 1. On the Admin page, navigate to Koha Administration > Global System Preferences 2. Search for OPACMandatoryHoldDates 3. In the Value field, check that it now says On the "Placing a hold" form, instead of opac-reserve form. Sponsored by Catalyst IT Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137360|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137364&action=edit Bug 30784: (follow-up) Additional rephrasing Add additional clarifcation, format NOTE: similar to most other notes in system preferences (bold, start on a new line), and link to other system preferences mentioned. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Welcome Danyon Sewell. Please change Assignee when you submit patches. Thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.04 released in| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |arthur.suzuki@biblibre.com --- Comment #14 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Can't find this system preference in Koha 21.11.x. Not backporting, ask if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org