[Bug 40592] New: Fix incorrect row highlighting on patron checkout history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 Bug ID: 40592 Summary: Fix incorrect row highlighting on patron checkout history page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: regression Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 38783 At some point in the rebasing of Bug 38714 a regression happened with members/readingrec.tt https://gitlab.com/koha-community/Koha/-/commit/c0961118625b2d398fba5bbf0960... The <tr> should not have any classes added. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38783 [Bug 38783] Row highlighting in the circulation history table for a patron doesn't look great -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185113&action=edit Bug 40592: Fix incorrect row highlighting on patron checkout history page To test: 1. Check out some items to a patron so they have a circulation history, the check in some of those items.. 2. Look at the patron's "Circulation history" table. There are four possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0, and #FFFFCC. 3. Apply the patch and reload the page. 4. An orange/gold badge will appear under the "Return date" column of the table for items that have been checked out, and there will no longer be alternating, pale yellow rows. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185113|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 185114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185114&action=edit Bug 40592: Fix incorrect row highlighting on patron checkout history page To test: 1. Check out some items to a patron so they have a circulation history, the check in some of those items.. 2. Look at the patron's "Circulation history" table. There are four possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0, and #FFFFCC. 3. Apply the patch and reload the page. 4. An orange/gold badge will appear under the "Return date" column of the table for items that have been checked out, and there will no longer be alternating, pale yellow rows. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185114|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 185263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185263&action=edit Bug 40592: Fix incorrect row highlighting on patron checkout history page To test: 1. Check out some items to a patron so they have a circulation history, the check in some of those items.. 2. Look at the patron's "Circulation history" table. There are four possible background colors for each row: #ffffff, #f3f4f4, #F9FAE0, and #FFFFCC. 3. Apply the patch and reload the page. 4. An orange/gold badge will appear under the "Return date" column of the table for items that have been checked out, and there will no longer be alternating, pale yellow rows. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40592 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not needed for 24.11.x (does not contain Bug 38714) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org